From a4097ba3948ca570321c02a3fe0ca4a681dfa970 Mon Sep 17 00:00:00 2001 From: Martin Pulec Date: Tue, 30 Sep 2025 12:53:16 +0200 Subject: [PATCH] hd-rum-recompress: fix final crash steps to reproduce the fixed behavior: 1) run `hd-rum-transcode 8M 7000 100::` 2) press Ctrl-C There is compress_done() called once - once by the now commented out line and then also with compress_state_deleter::operator(). This problem technically occurs since 2ca38e7c (16th Jun 2025) when module_done() was replaced with compress_done(), which doesn't allow double call (in cotrary to module_done(), which does). The root of the problem is perhaps the commit 7460563 (2022-01-18). --- src/hd-rum-translator/hd-rum-recompress.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hd-rum-translator/hd-rum-recompress.cpp b/src/hd-rum-translator/hd-rum-recompress.cpp index 42ffdfcd7..54b4ec079 100644 --- a/src/hd-rum-translator/hd-rum-recompress.cpp +++ b/src/hd-rum-translator/hd-rum-recompress.cpp @@ -347,7 +347,7 @@ void recompress_done(struct state_recompress *s) { compress_frame(worker.second.compress.get(), nullptr); worker.second.thread.join(); - compress_done(worker.second.compress.get()); + // compress_done(worker.second.compress.get()); } } delete s;