From f9fa06c9ab13c19d2fd5492704910dc30d082db3 Mon Sep 17 00:00:00 2001
From: Martin Pulec <martin.pulec@cesnet.cz>
Date: Tue, 15 Apr 2025 12:45:43 +0200
Subject: [PATCH] acap/sdl_mixer: fix some leaks when init fails

- leaked Mix_Music (always)
- leaked req_filename when init fails (CID 472141)
---
 src/audio/capture/sdl_mixer.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/src/audio/capture/sdl_mixer.c b/src/audio/capture/sdl_mixer.c
index c824caab5..e550c752a 100644
--- a/src/audio/capture/sdl_mixer.c
+++ b/src/audio/capture/sdl_mixer.c
@@ -85,6 +85,7 @@
 #endif
 
 struct state_sdl_mixer_capture {
+        Mix_Music *music;
         struct audio_frame audio;
         struct ring_buffer *sdl_mixer_buf;
         int volume;
@@ -234,7 +235,7 @@ static void * audio_cap_sdl_mixer_init(struct module *parent, const char *cfg)
         int ret = parse_opts(s, ccfg);
         free(ccfg);
         if (ret != 0) {
-                free(s);
+                audio_cap_sdl_mixer_done(s);
                 return ret < 0 ? NULL : INIT_NOERR;
         }
 
@@ -274,11 +275,11 @@ static void * audio_cap_sdl_mixer_init(struct module *parent, const char *cfg)
                 }
         }
         try_open_soundfont();
-        Mix_Music *music = Mix_LoadMUS(filename);
+        s->music = Mix_LoadMUS(filename);
         if (filename != s->req_filename) {
                 unlink(filename);
         }
-        if (music == NULL) {
+        if (s->music == NULL) {
                 log_msg(LOG_LEVEL_ERROR, MOD_NAME "error loading file: %s\n", Mix_GetError());
                 goto error;
         }
@@ -295,7 +296,7 @@ static void * audio_cap_sdl_mixer_init(struct module *parent, const char *cfg)
         }
 
         Mix_VolumeMusic(s->volume);
-        if (Mix_PlayMusic(music, -1) == SDL_ERR) {
+        if (Mix_PlayMusic(s->music, -1) == SDL_ERR) {
                 log_msg(LOG_LEVEL_ERROR, MOD_NAME "error playing file: %s\n", Mix_GetError());
                 goto error;
         }
@@ -320,9 +321,10 @@ static struct audio_frame *audio_cap_sdl_mixer_read(void *state)
 
 static void audio_cap_sdl_mixer_done(void *state)
 {
-        Mix_HaltMusic();
-        Mix_CloseAudio();
         struct state_sdl_mixer_capture *s = state;
+        Mix_HaltMusic();
+        Mix_FreeMusic(s->music);
+        Mix_CloseAudio();
         free(s->audio.data);
         free(s->req_filename);
         free(s);