Not tested but trivially, libgdk-3.so.0 from (build) Ubuntu 22.04
should not be incompatible when running on the same distro.
This is not known to cause issues but better to remove this since it
the original use case seem no longer being valid. Track just the
excludelist from AppImage creator.
commented out libgdk_pixbuf-2.0.so.0
Normal build no longer runs on Rocky Linux 9 but alternative build (built
on centos 7) does. But conversly excluding the files causes dependency
problems for vcap/file vcomp/lavc, vdisp.file, vdisp/gl. Tested on Alma
9.6, which shuld be basically the same as Rocky. After re-adding the
problem disappears.
Doesn't seem to be required and nwo (since the new PPA use) causes following error:
```
ultragrid_vidcap_rtsp.so: /lib/x86_64-linux-gnu/libgnutls.so.30: undefined symbol: nettle_siv_gcm_aes256_decrypt_message, version NETTLE_8
``
(obviously) when libgnutls30 is not installed, eg. in Ubuntu 24.04.
Omit adding --read-only=/tmp fixed - now paths are "-enclosed, handle
eventual mutliplied leading / and evental trailing one and don't assume
space after (not needed now, " delimits that).
ilibpipewire-0.3.so.0 was added to excludelist causing the distcheck fail,
see [1]
We do not need to exclude the lib, because we already handle the preload
in data/scripts/Linux-AppImage/AppRun:282 (the case is similar as for
libjack.so.0 as also mentioned in the related AppImage issue).
[1]:
04af461f47
It is not needed to split the string like this:
```
a="potentially long string on"\
"multiple lines"
```
but it is better rather to put the '\' inside the string:
```
a="potentially long string on\
multiple lines"
```
+ removed the subshell
The redirection is actually no longer neeeded - we do not need to bother
where the output goes but the reason for the redirection is no longer
valid - the created AppImage is no longer outputted.
mkappimage now tries to automatically upload the asset if it detects
running in GitHub CI, which is not the behavior we perhaps want because
it deletes and recreates our _continuous_ release.
See following failed run:
https://github.com/CESNET/UltraGrid/actions/runs/5575039257/jobs/10185765784
+ fixed `wget` presence check in `create-appimage.sh`
The caller can now provide its own FIREJAIL_OPTS (if something is
needed).
+ do not pass explicitly UG_FONT_DIR to firejail - the environment isn't
entirely pruned, the env vars usually pass to the Firejail, except of
some, including LD_PRELOAD, LD_LIBRARY_PATH and TMPDIR, which are
already passed.
- TMPDIR was not writtable - `--read-only=/tmp` after
`--read-write=/tmp/something` overrides read-write, order needs to be
reversed
- for args file, filename, make parent directory writtable - it may not
only be read, but also written (like `--protocol sdp:file=out.sdp`)
+ FIREJAIL_DEBUG to print assembled Firejail arguments
If $ULTRAGRID_AUTOUPDATE is set to >= 0, use it as update interval (in
days).
Since the value 0 was used to suppress the update warning, the value
to suppress the warning was required to change to -1.
The command-line tools used here (eg. stat) may use our custom libraries
(like libselinux) which may not be entirely compatible (it just most
likely ends up with a warning).
+ do the same for get_tools() and set_libva_ld_preload()
+ use original (if any) LD_LIBRARY_PATH for set_ld_preload()
+ removed unneeded `exit $?` (it is implicit)
libpipewire is incompatible with preloaded jack on current Arch and
causes a crash (unsatisfied jack pipewire function dependency).
Anyways, the pipewire screen capture didn't work with the bundled
library, anyways, so we certainly need one from system.
Setting LD_LIBRARY_PATH would override the library path also for tput
executable, leading to possible incompatible version of ncurses in
bundle, leading to following error:
tput: /tmp/.mount_UG-20-oJoJEf/usr/lib/libncursesw.so.6: version `NCURSES6_TINFO_6.2.20211010' not found (required by tput)
(and of course the color escape sequence is not returned)
Don't use bundled Wayland libraries when running on Wayland but use it
otherwise to satisfy possibly unsatisfied dependencies.
See also previous commit - Wayland libraries seem not to be portable and
prevent SDL2 native run on Wayland. After this change, SDL2 runs on
U22.04 in Weston (without Xwayland).
Beware not to add --whitelist=/tmp[something] because that would hide
the actual mounted image (/tmp/.mount_ultragridsomething). As /tmp is
remounted RO, just make the "whitelisted" dirs RW.
+ add to whitelist $DIR (path to executable) if it is not /tmp (eg.
extracted AppImage somewhere)
