Commit Graph

194 Commits

Author SHA1 Message Date
Martin Pulec
183d175d73 fixed some of new Coverity issues 2023-05-10 08:52:02 +02:00
Martin Pulec
01b3f55f9b ~state_root: prevent unserialized var access
The should_exit_callbacks members can be concurrently accessed also from
the should_exit_thread, that has not yet been joined.
2023-04-28 16:08:05 +02:00
Martin Pulec
a233123473 ULTRAGRID_VERBOSE env var: neutralize if empty
While set, user may want to unset it just for one command, for which the
easiest way is to use `ULTRAGRID_VERBOSE= <cmd>`.
2023-04-28 14:32:54 +02:00
Martin Pulec
64688bb4c7 hd-rum-transcode: share signal callbacks with UG
The crash and freeze signal handlers may be useful also for the
reflector.
2023-04-28 13:12:35 +02:00
Martin Pulec
89ac81b0bd hd-rum-translator: fixed messages not delivered
The state_root::new_message is now handled in host.cpp, which processed
all messages, even those intended for reflector.

As a solution, the new_message callback of state_root processes only
messages for it and puts remaining messages back to the pool with the
new function module_store_message() that doesn't call the new_message
callback.
2023-04-28 12:18:52 +02:00
Martin Pulec
81e2920f17 ~state_root: erase should_exit callbacks
erase should_exit_callbacks before calling broadcast_should_exit

The destructor is called after most of the modules are destroyed but the
should_exit callbacks are not unregistered (it is not supposed to be
required since it should be called only to unblock blocking modules
calls to allow destroying them).
2023-04-24 13:44:58 +02:00
Martin Pulec
1ed549df4a separated some common root mod handling to host.cpp
The management of should_exit events should be also be shared with the
transcoding reflector that uses some parts that may depend upon this
functionality.

This is not purely a refactorization but slightly changes behavior,
namely the shared state cleanup is done in a destructor, not by
`uv.stop()` as it used to be.

see GH-307
2023-04-12 16:35:55 +02:00
Martin Pulec
a3daa89ef6 displays: changed api for mainloop
- removed `needs_mainloop` attribute and deduce if mainloop is needed
  from the presence of _run callback (the information is now redundant
  only displays needing/running mainloop should announce _run callback)

- run the custom mainloop (currently only Syphon!) only when display
  doesn't run its mainloop. This allows running Syphon and GL/SDL
  display because it connects to the display mainloop.
2023-03-29 13:39:48 +02:00
Martin Pulec
449251ac3e get rid of global should exit variable 2023-03-24 14:06:50 +01:00
Martin Piatka
68d30a4f6b capabilities: Add device options 2023-03-16 13:20:41 +01:00
Martin Pulec
c9e5f620cd audio/capture: get rid of audio_init_state_ok
replaced with convenient INIT_NOERR

+ removed all remaining references (audio.h, host.cpp)
2023-03-14 10:52:17 +01:00
Martin Pulec
20a331fad1 logging: do not override log_level default val
If user didn't set anything on command line, do not override the default
value of `log_level` specified by the initializer.

This is a bit contraintuitive if a developer sets the value ad hoc to a
different val, it won't take effect.
2023-03-07 16:31:05 +01:00
Martin Pulec
4fe552f225 use common com_[un]initialize 2023-02-24 16:06:42 +01:00
Martin Pulec
8df499ffac merged utils/hresult to utils/windows
These 2 files are relatively small and coherent.

+ fixed hresult_to_str not returning anything on RPC_E_CHANGED_MODE
2023-02-24 15:00:00 +01:00
Martin Pulec
9aef0d6011 common_init: init COM on main thread in Windows
Ensure that COM is intialized as COINIT_MULTITHREADED on main thread
because eg. Portaudio uses COINIT_APARTMENTTHREADED.
2023-02-24 13:47:36 +01:00
Martin Pulec
98805677eb --conv-policy help - improvements 2023-02-23 09:06:49 +01:00
Martin Pulec
fd58880e99 call srand48 in common_preinit
lrand48() is now called in rtp_init_if() prior to init_rng() to get
random port offset. But when not seeded, first call of lrand48() return
always 0 (with glibc 2.37).
2023-02-23 09:06:45 +01:00
Martin Pulec
927842cf43 added pixfmt conversion policy opt
+ changed the default policy to keep bit-depth over color-space

pixfmt_conv_pref is defined in video_codec.c, otherwise tools/convert
won't compile.
2023-02-14 09:49:48 +01:00
Martin Pulec
cac1d11190 updated copyrights of files changed in 2023 2023-02-09 09:19:50 +01:00
Martin Piatka
83d7a28a32 capabilities: Fix printing incorrect module name 2023-02-07 10:44:23 +01:00
Martin Piatka
53ff8e4bbf capabilities: Use explicit type in lambda 2023-02-02 15:54:20 +01:00
Martin Piatka
28797c2246 capabilities: null initialize device list pointer 2023-02-02 15:52:58 +01:00
Martin Piatka
c131e1ebd8 capabilities: Don't print modules when selective querying 2023-02-02 12:27:49 +01:00
Martin Piatka
dfb2bc7519 capabilities: Selective probing 2023-02-02 12:27:49 +01:00
Martin Piatka
278276e109 capabilities: Report audio filters 2023-02-02 12:27:48 +01:00
Martin Piatka
f9bd80bec1 capabilities: factor module probing into a function 2023-01-30 12:41:13 +01:00
Martin Piatka
1bcfbd38f2 audio_playback: Use the unified probe API 2023-01-30 12:41:13 +01:00
Martin Piatka
4e5d329803 audio_capture: Use the unified probe API 2023-01-30 12:41:13 +01:00
Martin Piatka
0920845462 video_capture: New probe API 2023-01-30 12:41:12 +01:00
Martin Piatka
cd6e2dbbf3 capabilities: Added "noprobe" option 2023-01-30 12:41:12 +01:00
Martin Piatka
d51d956817 Fix compile on older gcc
GCC on Ubuntu 18.04 doesn't seem to support the string_view overload of
std::quoted
2023-01-23 16:44:27 +01:00
Martin Piatka
1f45c70c77 capabilities: Move capture printing to host.cpp 2023-01-23 15:28:32 +01:00
Martin Piatka
f2d03285b3 host/capabilities: Factor device print into a function 2023-01-23 14:20:09 +01:00
Martin Pulec
be39092cda rename double-framerate.cpp -> temporal-deint.c
The original name was now slightly misleading since there is also bob
and linear deinterlators.

Also for user it is "double_framerate", not corresponding with the
original file name (underscore instead of minus sign).

+ moved to C
2023-01-18 11:37:59 +01:00
Martin Piatka
ebee5aa583 capabilities: Remove unneeded cout flag and precision restoring
Flags and precision were set when reporting compression presets, but
that got removed.
2023-01-16 10:45:33 +01:00
Martin Piatka
6b08932038 capabilities: Remove old unused preset reporting 2023-01-13 13:12:22 +01:00
Martin Pulec
3c57f67919 UG 1.8 branding
version text color + splashscreen
2022-12-09 14:08:12 +01:00
Martin Pulec
b5cc0e9a1b removed some rang.hpp references 2022-11-21 14:17:01 +01:00
Martin Pulec
2cf167d57f added ULTRAGRID_ERRORS_FATAL environment variable
has same effect as `--param errors-fatal`

+ more verbose documentation of this in the `--param help`
2022-11-15 16:21:40 +01:00
Martin Pulec
9469d6352c document ULTRAGRID_VERBOSE + added some doxygen 2022-11-15 16:13:50 +01:00
Martin Pulec
5dda4c3778 host: documented --capabilities vidcap 2022-10-18 08:24:17 +02:00
Martin Pulec
762216f579 split setting audio capture format from parsing
Since it was seting global variables, the advantage is also that
set_audio_capture_format is now simplier.
2022-10-18 08:23:19 +02:00
Martin Pulec
b07ce59da7 don't return failure on '--audio-capture-format help' 2022-10-18 08:23:19 +02:00
Martin Pulec
735c4fb1d2 logging: override env with param
Set verbose according to ULTRAGRID_VERBOSE parameter only if no
verbosity was given from command-line (otherwise '-V' would mean
'debug').
2022-09-23 11:10:32 +02:00
Martin Pulec
b1f0e004f4 fixed new Coverity bugs
Fixed some of (easy) newly detected Coverity bugs. Those are mostly
innocent ones (performance) and not new (detected because of new release
of Coverity).
2022-08-22 09:57:16 +02:00
Martin Pulec
a9bc710a73 respect ULTRAGRID_VEBOSE environment variable
Previously it was errorneously checked while setting log level from the
command-line opt. If no was given, the particular function was not run.
2022-08-17 17:24:35 +02:00
Martin Pulec
0b8cc39f9c removed perf tool
It was almost never used since added.
2022-08-17 17:24:34 +02:00
Martin Pulec
128150288b logger: removed preinit
no longer needed to initialize rang here
2022-08-10 10:00:07 +02:00
Martin Piatka
213ce5e20f output buffering: Disable buffering in GDB
Since the style reset escape codes are generally after the newline, the
otput of GDB would stay colored without this change
2022-08-09 11:48:58 +02:00
Martin Piatka
e0245aeda5 host,keyboard_control: Move gdb detection to a function 2022-08-09 11:48:58 +02:00