fix double copy; also CID 470421
Copied tvice from 3125ea2d (2024-11-18) - actually the original strcpy()
was forgotten (replaced in favor of snprintf_ch).
- do not inform about new API - it has been there a long time and obviously
the "new" API works fine
- do not warn that cannot get the latency - the procfs file is no longer
available so it is issued all the time. It works with the default value
24 ms just fine.
- regading the above, do not obtain the value at all - since it now works
fine, we do not need to depend on an external value that may potentially
break the stuff (it would be required to re-test if needed)
Changed the path to from /etc/sysctl.conf to
/etc/sysctl.d/60-ultragrid.conf. It seems like systemd 256 no longer
applies /etc/sysctl.conf directly but only the sysctl.d/*conf.
Keeping the changes separate is nicer, anyways. It should work for
non-systemd systems as well, checked Alpine and Void (runit).
to be able to identify capture vs playback
This may or may not be important - if cap/disp is on single device,
the status is global so it doesn't matter there. But those can be 2
separate DeckLinks and then there will be hard to differntiate.
Also, both devices will get the same notifications so this makes at least
clear that the duplicate has some reason. (Maybe it will be useful to
figure out how to print just once?)
Note that BMD_CHECK still uses the blackmagic_common.cpp MOD_NMAE
("[DeckLink] ").
- use BMD_CHECK to check HRESULT
- check Unsubscribe ret val
- if deckLink->QueryInterface(IID_IDeckLinkNotification, ..) fails,
release deckLinkStatus
- doxygen updates
I am not entierly sure if releasing IDeckLinkNotification in register
fuction actually doesn't cleanup the state. It seems it does not but
just to be sure.
The changes, eg. IP address do not take place immediately so it is
importatnt to print the changed value for the user to be sure that the
values is changed (the original is printed first by the bmd_print_status).
- the prop type must be BMDDeckLinkStatusID (Windows)
- `string_val = ""` also do not work if BMD_STR is different than in
Linux -> simplify (use the common code)
- moved out of fcc_to_string to be used otherwhere
- split options and values (for futher use)
- converted from unordered_map to plain C-array (unordered map may throw
on file scope which cannot be catched)
- do not print it in constructor/dtor - the participant may be moved
- copy the stored address in copy constructor
- use get_sockaddr_str + change its prototype - do not use thread_local
vars but user provided buffer
- also take (const sockaddr *) in the get_sockaddr_str and
get_sockaddr_addr_* functions (participants iterated by const iterator
returning const participant reference)
Some AVCodec properties like pix_fmts or sample_fmts are marked as
deprecated and should be replaced by avcodec_get_supported_config()
in current FFmpeg.
Created compat functions to get rid of deprecate warnings running with
both old and new FFmpeg.
If running with Firejail, neither /tmp (used by tmpfile()) nor CWD may
be writable so try to create file in $TMPDIR (if defined, otherwise
there a default).
+ modified get_temp_file() opened file mode to be readable
In verbose mode, the SSRC is still printed but it makes - toghether
with timestamps that are default in verbose - the line quite long,
so make it a bit shorter.
Refactoring done in 1ab725d57 (2024-08-05) changed the behavior not to
expect NULL pointer, because common_opts.encryption is a char array now.
But tx_init calls also audio/playback/mixer, which crashes since then so
be less rigid in this case.
v6.19 and v6.20 is undistinguishable by preprocessor but the later
changes the API. So added a preprocessor directive to allow compilation
with v6.19 passed by user. It could have been checked by autoconf but
it is perhaps not worth the effort.
The actual value (5,2,1)/5 didn't match peach fuzz (255,190,152)/255
but the rather closest color is Tomato (255,99,71)/255.
The T_DARKER_ORANGE is poorly defined but its value (3,1,0)/5 matches
approximately the X11 color Saddle Brown (139,69,19)/255.
