The space there might have been intentionally assuming the subsequent
hint but if not shown, the line was not terminated. It doesn't hurt
to have it on saparate lines even though.
The commit 87378965 from 2024-07-10 has actually broken this because
the header_inserter_req value changed in temporary struct since that,
not in the one that is stored in state.
Fixed by adding the actual value, alongside the _req value in parameters.
i18n support - UTF-8 file names
Unfortunately won't be useful for UltraGrid so far - it is perhaps not
possible to pass UTF-8 encoded arguments from commmand-line unless using
`wmain (int argc, wchar_t *argv[])` main function prototype (for more
info see GJ GIT log).
If given by name, the info was that the invalid index was -2, which is
an internal value. The message that a device with given name could not
have been found is already printed.
Handle clang-tidy cert-err33-c warning that output of snprintf is not
used. The return value should be used to handlet truncation - it is
hard to handle this generically but we may issue at least a warning.
The internal state of compression module is now simply (void *) as in
other modules. The (module *)-typed vesion was actually unnecessary
because except lavc, no module reads messages. Also the idea of universal
API with struct module didn't make it in the end.
This complements the commit 0557730 that did simlarly for external
vcompress API.
Corrected various spelling mistakes in comments, documentation, and
variable names across the project. Changes include:
- Documentation files (CONTRIBUTING.md, README.md, etc.)
- Source code comments in C/C++ files
- Function parameter names and descriptions
No functional changes were made.
Consolidate the code for various *nix flavors:
- guard macro __unix__
- 16 bytes only for Linux (required, otherwise not set)
- use platform specific pthread_setname_np prototypes
- default to (pthread_t, const char *) arguments, that work for Linux,
DragonFly and FreeBSD but different for macOS and NetBSD, OpenBSD
unimplemented
IPPORT_MAX is defined in FreeBSD sys headers (65535 but since we use
the same value but different expression, it triggers a warning so to
avoid clashes.
If able to get the ext info, show J2K codestream lossiness type. Otherwise, throw a warning, but continue on since it shouldn't affect the ability to decode.