Commit Graph

21 Commits

Author SHA1 Message Date
Martin Pulec
8d1a36916d .github/scripts/macOS/sign.sh: added usage notice 2024-03-25 09:16:43 +01:00
Martin Pulec
f2ba6e81ba CI macOS: skip sign+notarize step if $apple_key_p12_b64 undef
\+ error from the notarize script if called

Previously (since commit 1c7c3ac1), the script silently exitted without
cigning and notarizing the app, which may harden debugging. Now the skip
is explicit and if the script is called anyways, it returns error.

enhances the commit 1c7c3ac1 (2024-03-22)
2024-03-25 09:01:13 +01:00
Martin Pulec
1c7c3ac196 CI macOS: do not fail on sign if no keys
If no signing keys available, the expected behavior is rather to skip
signing instead of failing, which is unintended because of shell check
for unset variables (set -u).
2024-03-22 16:04:13 +01:00
Martin Pulec
bea0ee1b64 CI mac: signing docu updates
\+ do not check $apple_key_p12_b64 in sign.sh but $KEY_CHAIN and
$KEY_CHAIN_PASS presence, which are used directly
2024-02-09 17:05:28 +01:00
Martin Pulec
58741e3d91 CI mac: import the key in prepare.sh
We will need to sign VideoMasterHD frameworks with our key.
2024-02-09 16:44:25 +01:00
Martin Pulec
c4b13ba642 sign.sh: added --sign-only (and --help)
to allow notariation skipping
2024-02-06 16:15:02 +01:00
Martin Pulec
b8e0acf5b8 macOS/sign.sh: don't fail if keychain exists
This makes the script reentrant, allowing to run it also interactively
repeatedly, provided that the `apple_key_p12_b64` and
`notarytool_credentials` environment variables are correctly set.
2023-11-02 12:18:06 +01:00
Martin Pulec
498605df74 macOS: replace altool with notarytool 2023-02-17 19:03:56 +01:00
Martin Pulec
d0224f6b2e .github/scripts/macOS/sign.sh: used shellcheck
Incorporated shellcheck complains.
2022-07-12 11:53:48 +02:00
Martin Pulec
c7a251f327 CI sign.sh [mac]: return 0 on pull request
On pull request, the repository secrets are not available.
2022-07-12 11:32:57 +02:00
Martin Pulec
e3db89af46 .github/scripts/macOS/sign.sh: do not leak password 2021-11-09 15:12:30 +01:00
Martin Pulec
b01b5964ee GitHub CI [Mac]: Try to fix notarization failures
https://developer.apple.com/forums/thread/677739:

[...] does supplying a different value for --primary-bundle-id clear
the problem?

IMPORTANT The notary service doesn’t actually require this bundle ID be
related to the software that you’re notarising, so you can use any
reasonable bundle ID.
2021-04-27 15:32:51 +02:00
Martin Pulec
d47f886c81 GitHub CI [Mac]: fail if main repo doesn't have keys
The former GITHUB_WORKFLOW is no longer valid (no "nightly" workflow
anymore).
2021-03-24 16:29:21 +01:00
Martin Pulec
e63cdf88ae GitHub CI [Mac]: change APPLE_KEY_P12_B64 secret
Simplified APPLE_KEY_P12_B64 secret - now it uses only base64-encoded
P12 file (original certificate not needed - contained in that file).
2021-03-23 16:14:36 +01:00
Martin Pulec
32e1f6a6cf GitHub CI: Mac signing - removed hardcoded signer username 2021-03-23 16:12:37 +01:00
Martin Pulec
7ff96e5f69 GitHub CI: output of Mac bundle signing to console
The signing sometimes silently fails and thus it's advisable to print copy of
the output, that has been previously redirected, to console
2020-08-05 15:01:07 +02:00
Martin Pulec
dd66af5b90 macOS: added camera/microphone entitlements
This should fix crashes of AV Foundation when invoked from GUI (and
CoreAudio capturing silence).

Closes #53.
2020-04-15 14:36:43 +02:00
Martin Pulec
1d17e9e028 GitHub Workflows: simplify signing [macOS] 2020-04-15 14:36:40 +02:00
Martin Pulec
cc06d7136f GitHub Workflow: macOS signing fix
Fixed missing quotation marks.
2020-04-07 10:06:36 +02:00
Martin Pulec
a61a4dc16e GitHub workflows: sign also CI if key avail. [mac] 2020-03-27 21:40:54 +01:00
Martin Pulec
73ec69a3a8 GitHub Workflow: nightly - sign the macOS app 2020-03-27 09:46:27 +01:00