If --enable-screen is used in Linux without specifying explicitly
x11 or pipewire, require both. The user may need to have the PipeWire
implementation and end up with X11 or vice versa.
Also fix the check for implementation - checked X11 only if
--enable-screen=x11 (without PW) and vice versa for Pipewire. But not
eg. --enable-screen=x11,pipewire.
Also changed configure.ac so that Pipewire screen cap requirements
are checked only in Linux (in other platform currently perhaps not
expected the use of Pipewire screen capture).
not sure why `if [ test $4 ... ]` worked... (excess [], which are possibly
consumed/erased by m4)
- check that $4 is set and avoid splitting on spaces (should not happen)
- use -eq instaead of = (should be 0 or 1)
- coverity-scan.yml: typo
- configure.ac: misleading message if SDL not found -> do not mention
version at all, it was perhaps meant "didn't found any version" but it
might have also been that did't found specified version...
- configure.ac: removed sdl_mixer from summary
Unpin SDL version 2 - SDL 3 can be now considered idempotent.
Issues mentioned in sdl3:
- sdl_mixer -> replaced with fluidsynth
- Vulkan issues - Vulkan is currently (SDL 3.20) not implicit in either
of platforms; if so, trigger a warning. Also it is unavailable in SDL2.
- p010 corruption in Direct3D 11 or 12 - there is already a workaround
to disable
To replace sdl3_mixer that does no longer support MIDI playback, thus
unusable for our use case.
- song1 needs to be static included potentially from 2 compilation units -
this and sdl_mixer
The variable #MSYSTEM_CHOST is taken as the base (/etc/config.site) and
contains now in MSYS x86_64-pc-cygwin resulting in $host_os=cygwin. Not
sure where the variable is defined, anyways...
SDL_mixer 3.0 rwmoved support for native MIDI [1], which was the reason it
was used for so refuse that.
Note that at this this moment, the latest released SDL_mixer version is
2.8.1, anyways. But it can be installed from Git.
[1]: https://wiki.libsdl.org/SDL3_mixer/README-migration
If running from inside out-of-tree build, the shaders were not located -
now look them up in srcdir (if the the formerly looked shader directory
doesn't exist).
This improves the commit f8b54ea9 from 2013 - currently _GNU_SOURCE is
required eg. for pthread_setname_np. Intantionally used not only with
glibc but also with musl - if not defined pthread_setname_np is not
defined.
+ add COMMON_FLAGS also to CPPFLAGS (doesn't matter much but better)