mirror of
				https://github.com/optim-enterprises-bv/Xray-core.git
				synced 2025-11-04 04:28:00 +00:00 
			
		
		
		
	Merge pull request #618 from XTLS/fix/service-name
gRPC: Use `PathEscape` encoded service name
This commit is contained in:
		@@ -1,6 +1,8 @@
 | 
			
		||||
package grpc
 | 
			
		||||
 | 
			
		||||
import (
 | 
			
		||||
	"net/url"
 | 
			
		||||
 | 
			
		||||
	"github.com/xtls/xray-core/common"
 | 
			
		||||
	"github.com/xtls/xray-core/transport/internet"
 | 
			
		||||
)
 | 
			
		||||
@@ -12,3 +14,7 @@ func init() {
 | 
			
		||||
		return new(Config)
 | 
			
		||||
	}))
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
func (c *Config) getNormalizedName() string {
 | 
			
		||||
	return url.PathEscape(c.ServiceName)
 | 
			
		||||
}
 | 
			
		||||
 
 | 
			
		||||
@@ -55,14 +55,14 @@ func dialgRPC(ctx context.Context, dest net.Destination, streamSettings *interne
 | 
			
		||||
	client := encoding.NewGRPCServiceClient(conn)
 | 
			
		||||
	if grpcSettings.MultiMode {
 | 
			
		||||
		newError("using gRPC multi mode").AtDebug().WriteToLog()
 | 
			
		||||
		grpcService, err := client.(encoding.GRPCServiceClientX).TunMultiCustomName(ctx, grpcSettings.ServiceName)
 | 
			
		||||
		grpcService, err := client.(encoding.GRPCServiceClientX).TunMultiCustomName(ctx, grpcSettings.getNormalizedName())
 | 
			
		||||
		if err != nil {
 | 
			
		||||
			return nil, newError("Cannot dial gRPC").Base(err)
 | 
			
		||||
		}
 | 
			
		||||
		return encoding.NewMultiHunkConn(grpcService, nil), nil
 | 
			
		||||
	}
 | 
			
		||||
 | 
			
		||||
	grpcService, err := client.(encoding.GRPCServiceClientX).TunCustomName(ctx, grpcSettings.ServiceName)
 | 
			
		||||
	grpcService, err := client.(encoding.GRPCServiceClientX).TunCustomName(ctx, grpcSettings.getNormalizedName())
 | 
			
		||||
	if err != nil {
 | 
			
		||||
		return nil, newError("Cannot dial gRPC").Base(err)
 | 
			
		||||
	}
 | 
			
		||||
 
 | 
			
		||||
@@ -39,7 +39,7 @@ func (c *gRPCServiceClient) TunCustomName(ctx context.Context, name string, opts
 | 
			
		||||
}
 | 
			
		||||
 | 
			
		||||
func (c *gRPCServiceClient) TunMultiCustomName(ctx context.Context, name string, opts ...grpc.CallOption) (GRPCService_TunMultiClient, error) {
 | 
			
		||||
	stream, err := c.cc.NewStream(ctx, &ServerDesc(name).Streams[0], "/"+name+"/TunMulti", opts...)
 | 
			
		||||
	stream, err := c.cc.NewStream(ctx, &ServerDesc(name).Streams[1], "/"+name+"/TunMulti", opts...)
 | 
			
		||||
	if err != nil {
 | 
			
		||||
		return nil, err
 | 
			
		||||
	}
 | 
			
		||||
 
 | 
			
		||||
@@ -123,7 +123,7 @@ func Listen(ctx context.Context, address net.Address, port net.Port, settings *i
 | 
			
		||||
			}
 | 
			
		||||
		}
 | 
			
		||||
 | 
			
		||||
		encoding.RegisterGRPCServiceServerX(s, listener, grpcSettings.ServiceName)
 | 
			
		||||
		encoding.RegisterGRPCServiceServerX(s, listener, grpcSettings.getNormalizedName())
 | 
			
		||||
 | 
			
		||||
		if err = s.Serve(streamListener); err != nil {
 | 
			
		||||
			newError("Listener for gRPC ended").Base(err).WriteToLog()
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user