diff --git a/app/controllers/api/v1/accounts/macros_controller.rb b/app/controllers/api/v1/accounts/macros_controller.rb index 60e1b62c2..e7946a54e 100644 --- a/app/controllers/api/v1/accounts/macros_controller.rb +++ b/app/controllers/api/v1/accounts/macros_controller.rb @@ -16,7 +16,9 @@ class Api::V1::Accounts::MacrosController < Api::V1::Accounts::BaseController @macro.save! end - def show; end + def show + head :not_found if @macro.nil? + end def destroy @macro.destroy! diff --git a/spec/controllers/api/v1/accounts/macros_controller_spec.rb b/spec/controllers/api/v1/accounts/macros_controller_spec.rb index d605dd508..7e4be84b1 100644 --- a/spec/controllers/api/v1/accounts/macros_controller_spec.rb +++ b/spec/controllers/api/v1/accounts/macros_controller_spec.rb @@ -173,6 +173,13 @@ RSpec.describe 'Api::V1::Accounts::MacrosController', type: :request do expect(json_response['payload']['name']).to eql(macro.name) expect(json_response['payload']['created_by']['id']).to eql(administrator.id) end + + it 'return not_found status when macros not available' do + get "/api/v1/accounts/#{account.id}/macros/15", + headers: administrator.create_new_auth_token + + expect(response).to have_http_status(:not_found) + end end end