fix: Update account data seeder to avoid invalid information (#7673)

- The message sender was incorrect. Incoming messages were created under the contact's name, and outgoing messages were created under the user's name instead of the reverse.
- The seed user's email address was incorrect in the message data.
- The Sendmail configuration overrode the Letter Opener config which made it difficult to test the email.
- This PR also fixes an ESLint lint issue on develop.
This commit is contained in:
Pranav Raj S
2023-08-04 16:32:54 -07:00
committed by GitHub
parent d06cf27800
commit 47b6967dad
4 changed files with 87 additions and 80 deletions

View File

@@ -54,7 +54,10 @@
>
{{ campaign.trigger_rules.url }}
</div>
<div v-if="campaign.scheduled_at" class="text-xs text-slate-700 dark:text-slate-500 mb-1">
<div
v-if="campaign.scheduled_at"
class="text-xs text-slate-700 dark:text-slate-500 mb-1"
>
{{ messageStamp(new Date(campaign.scheduled_at), 'LLL d, h:mm a') }}
</div>
</div>

View File

@@ -27,12 +27,13 @@ Rails.application.configure do
config.action_mailer.delivery_method = :smtp unless Rails.env.test?
config.action_mailer.smtp_settings = smtp_settings
# You can use letter opener for your local development by setting the environment variable
config.action_mailer.delivery_method = :letter_opener if Rails.env.development? && ENV['LETTER_OPENER']
# Use sendmail if using postfix for email
config.action_mailer.delivery_method = :sendmail if ENV['SMTP_ADDRESS'].blank?
# You can use letter opener for your local development by setting the environment variable
config.action_mailer.delivery_method = :letter_opener if Rails.env.development? && ENV['LETTER_OPENER']
#########################################
# Configuration Related to Action MailBox
#########################################

View File

@@ -96,16 +96,19 @@ class Seeders::AccountSeeder
def create_messages(conversation:, messages:)
messages.each do |message_data|
sender = find_message_sender(conversation, message_data)
conversation.messages.create!(message_data.slice('content', 'message_type').merge(account: conversation.inbox.account, sender: sender,
inbox: conversation.inbox))
conversation.messages.create!(
message_data.slice('content', 'message_type').merge(
account: conversation.inbox.account, sender: sender, inbox: conversation.inbox
)
)
end
end
def find_message_sender(conversation, message_data)
if message_data['message_type'] == 'incoming'
User.find_by(email: message_data['sender']) if message_data['sender'].present?
else
conversation.contact
elsif message_data['sender'].present?
User.find_by(email: message_data['sender'])
end
end

View File

@@ -4,7 +4,7 @@ company:
users:
- name: 'Michael Scott'
gender: male
email: 'michale@paperlayer.test'
email: 'michael_scott@paperlayer.test'
team:
- 'sales'
- 'management'