From 86cb4fd80952df40c979f9e67d8064f6deda02f9 Mon Sep 17 00:00:00 2001 From: Sivin Varghese <64252451+iamsivin@users.noreply.github.com> Date: Thu, 31 Jul 2025 02:19:27 +0530 Subject: [PATCH] chore: Improve layout styles (#12025) # Pull Request Template ## Description This PR fixes the layout overflow scroll issue and removes unused CSS. It also optimizes the display of the Sidebar, Copilot Panel, and Conversation Panel in the mobile view. Additionally, it resolves a runtime console warning. ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? ### Screencast https://github.com/user-attachments/assets/7e8885fa-6174-4740-80f1-bb1cec6517fc ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules --------- Co-authored-by: Muhsin Keloth --- app/javascript/dashboard/App.vue | 2 +- .../dashboard/assets/scss/_woot.scss | 24 ----- .../sidebar/MobileSidebarLauncher.vue | 58 ++++++++++++ .../components-next/sidebar/Sidebar.vue | 28 +++++- .../components/copilot/CopilotContainer.vue | 30 +++++- .../conversation/ConversationSidebar.vue | 28 +++++- app/javascript/dashboard/constants/globals.js | 2 +- .../dashboard/routes/dashboard/Dashboard.vue | 91 +++++++++---------- .../conversation/search/SwitchLayout.vue | 2 +- .../helpcenter/components/UpgradePage.vue | 2 +- .../pages/HelpCenterPageRouteView.vue | 2 +- .../dashboard/settings/SettingsHeader.vue | 20 ---- .../routes/dashboard/settings/Wrapper.vue | 16 +--- .../dashboard/settings/inbox/inbox.routes.js | 2 - .../dashboard/settings/teams/teams.routes.js | 2 - .../routes/dashboard/upgrade/UpgradePage.vue | 72 ++++++++------- 16 files changed, 226 insertions(+), 155 deletions(-) create mode 100644 app/javascript/dashboard/components-next/sidebar/MobileSidebarLauncher.vue diff --git a/app/javascript/dashboard/App.vue b/app/javascript/dashboard/App.vue index 675f6ea67..0fbb20ea9 100644 --- a/app/javascript/dashboard/App.vue +++ b/app/javascript/dashboard/App.vue @@ -136,7 +136,7 @@ export default {
diff --git a/app/javascript/dashboard/assets/scss/_woot.scss b/app/javascript/dashboard/assets/scss/_woot.scss index 66416c64c..40ca7b436 100644 --- a/app/javascript/dashboard/assets/scss/_woot.scss +++ b/app/javascript/dashboard/assets/scss/_woot.scss @@ -37,30 +37,6 @@ body { width: 100%; } -.app-wrapper { - @apply h-screen flex-grow-0 min-h-0 w-full; - - .button--fixed-top { - @apply fixed ltr:right-2 rtl:left-2 top-2 flex flex-row; - } -} - -.banner + .app-wrapper { - // Reduce the height of the dashboard to make room for the banner. - // And causing the top right green-action button to be pushed down when scrolling. - @apply h-[calc(100%-48px)]; - - .button--fixed-top { - @apply top-14; - } - - .off-canvas-content { - .button--fixed-top { - @apply top-2; - } - } -} - .tooltip { @apply bg-n-solid-2 text-n-slate-12 py-1 px-2 z-40 text-xs rounded-md max-w-96; } diff --git a/app/javascript/dashboard/components-next/sidebar/MobileSidebarLauncher.vue b/app/javascript/dashboard/components-next/sidebar/MobileSidebarLauncher.vue new file mode 100644 index 000000000..a7265f840 --- /dev/null +++ b/app/javascript/dashboard/components-next/sidebar/MobileSidebarLauncher.vue @@ -0,0 +1,58 @@ + + +