From 9606abe25150e9dc6b77fbefab0620b8fc11e4ea Mon Sep 17 00:00:00 2001
From: Muhsin Keloth <muhsinkeramam@gmail.com>
Date: Mon, 27 Dec 2021 13:49:31 +0530
Subject: [PATCH] chore: Fix `Eslint` warnings (#3654)

* Fix all the eslint warnings

* Revert the schema
---
 .eslintrc.js                                  |  4 +---
 .../dashboard/components/Snackbar.vue         |  2 +-
 .../dashboard/components/ui/Switch.vue        |  9 ++++-----
 .../components/widgets/EmptyState.vue         |  6 +++---
 .../components/widgets/LoadingState.vue       |  4 ++--
 .../components/widgets/ReportStatsCard.vue    | 10 +++++-----
 .../components/widgets/modal/DeleteModal.vue  | 12 ++++++------
 .../dashboard/routes/auth/PasswordEdit.vue    |  6 +++---
 .../settings/SettingsSubPageHeader.vue        |  4 ++--
 .../routes/dashboard/settings/Wrapper.vue     |  6 +++---
 .../dashboard/settings/canned/EditCanned.vue  |  8 ++++----
 .../integrationapps/IntegrationItem.vue       |  4 ++--
 .../settings/integrations/Integration.vue     | 19 +++++++++++--------
 .../settings/integrations/ShowIntegration.vue |  9 ++++++++-
 .../shared/components/GreetingsEditor.vue     |  2 +-
 .../widget/components/ImageBubble.vue         |  6 +++++-
 .../widget/components/UserAvatar.vue          |  2 ++
 17 files changed, 63 insertions(+), 50 deletions(-)

diff --git a/.eslintrc.js b/.eslintrc.js
index 77ea9be7c..a52594492 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -28,9 +28,7 @@ module.exports = {
     }],
     'vue/html-self-closing': 'off',
     "vue/no-v-html": 'off',
-    'vue/singleline-html-element-content-newline': 'warn',
-    'vue/require-default-prop': 'warn',
-    'vue/require-prop-types': 'warn',
+    'vue/singleline-html-element-content-newline': 'off',
     'import/extensions': ['off']
 
   },
diff --git a/app/javascript/dashboard/components/Snackbar.vue b/app/javascript/dashboard/components/Snackbar.vue
index d34702ab8..ecfebe5e0 100644
--- a/app/javascript/dashboard/components/Snackbar.vue
+++ b/app/javascript/dashboard/components/Snackbar.vue
@@ -11,7 +11,7 @@
 <script>
 export default {
   props: {
-    message: String,
+    message: { type: String, default: '' },
     showButton: Boolean,
     duration: {
       type: [String, Number],
diff --git a/app/javascript/dashboard/components/ui/Switch.vue b/app/javascript/dashboard/components/ui/Switch.vue
index e1b27df8e..98755a91b 100644
--- a/app/javascript/dashboard/components/ui/Switch.vue
+++ b/app/javascript/dashboard/components/ui/Switch.vue
@@ -18,12 +18,11 @@
 export default {
   props: {
     disabled: Boolean,
-    isFullwidth: Boolean,
-    type: String,
-    size: String,
+    type: { type: String, default: '' },
+    size: { type: String, default: '' },
     checked: Boolean,
-    name: String,
-    id: String,
+    name: { type: String, default: '' },
+    id: { type: String, default: '' },
   },
   data() {
     return {
diff --git a/app/javascript/dashboard/components/widgets/EmptyState.vue b/app/javascript/dashboard/components/widgets/EmptyState.vue
index a9fc17087..b45d4daaa 100644
--- a/app/javascript/dashboard/components/widgets/EmptyState.vue
+++ b/app/javascript/dashboard/components/widgets/EmptyState.vue
@@ -12,9 +12,9 @@
 <script>
 export default {
   props: {
-    title: String,
-    message: String,
-    buttonText: String,
+    title: { type: String, default: '' },
+    message: { type: String, default: '' },
+    buttonText: { type: String, default: '' },
   },
 };
 </script>
diff --git a/app/javascript/dashboard/components/widgets/LoadingState.vue b/app/javascript/dashboard/components/widgets/LoadingState.vue
index 6ec16fdb1..9fdecc2e8 100644
--- a/app/javascript/dashboard/components/widgets/LoadingState.vue
+++ b/app/javascript/dashboard/components/widgets/LoadingState.vue
@@ -1,12 +1,12 @@
 <template>
   <div class="row loading-state">
-    <h6 class="message">{{ message }}<span class="spinner"></span></h6>
+    <h6 class="message">{{ message }}<span class="spinner" /></h6>
   </div>
 </template>
 <script>
 export default {
   props: {
-    message: String,
+    message: { type: String, default: '' },
   },
 };
 </script>
diff --git a/app/javascript/dashboard/components/widgets/ReportStatsCard.vue b/app/javascript/dashboard/components/widgets/ReportStatsCard.vue
index aa989914b..309627220 100644
--- a/app/javascript/dashboard/components/widgets/ReportStatsCard.vue
+++ b/app/javascript/dashboard/components/widgets/ReportStatsCard.vue
@@ -18,12 +18,12 @@
 <script>
 export default {
   props: {
-    heading: String,
-    point: [Number, String],
-    index: Number,
-    desc: String,
+    heading: { type: String, default: '' },
+    point: { type: [Number, String], default: '' },
+    index: { type: Number, default: null },
+    desc: { type: String, default: '' },
     selected: Boolean,
-    onClick: Function,
+    onClick: { type: Function, default: () => {} },
   },
 };
 </script>
diff --git a/app/javascript/dashboard/components/widgets/modal/DeleteModal.vue b/app/javascript/dashboard/components/widgets/modal/DeleteModal.vue
index fda78595b..b4d9f65f3 100644
--- a/app/javascript/dashboard/components/widgets/modal/DeleteModal.vue
+++ b/app/javascript/dashboard/components/widgets/modal/DeleteModal.vue
@@ -21,12 +21,12 @@ export default {
   },
   props: {
     show: Boolean,
-    onClose: Function,
-    onConfirm: Function,
-    title: String,
-    message: String,
-    confirmText: String,
-    rejectText: String,
+    onClose: { type: Function, default: () => {} },
+    onConfirm: { type: Function, default: () => {} },
+    title: { type: String, default: '' },
+    message: { type: String, default: '' },
+    confirmText: { type: String, default: '' },
+    rejectText: { type: String, default: '' },
   },
 };
 </script>
diff --git a/app/javascript/dashboard/routes/auth/PasswordEdit.vue b/app/javascript/dashboard/routes/auth/PasswordEdit.vue
index 751f16e83..94380674f 100644
--- a/app/javascript/dashboard/routes/auth/PasswordEdit.vue
+++ b/app/javascript/dashboard/routes/auth/PasswordEdit.vue
@@ -57,9 +57,9 @@ export default {
     WootSubmitButton,
   },
   props: {
-    resetPasswordToken: String,
-    redirectUrl: String,
-    config: String,
+    resetPasswordToken: { type: String, default: '' },
+    redirectUrl: { type: String, default: '' },
+    config: { type: String, default: '' },
   },
   data() {
     return {
diff --git a/app/javascript/dashboard/routes/dashboard/settings/SettingsSubPageHeader.vue b/app/javascript/dashboard/routes/dashboard/settings/SettingsSubPageHeader.vue
index d30dda489..283944437 100644
--- a/app/javascript/dashboard/routes/dashboard/settings/SettingsSubPageHeader.vue
+++ b/app/javascript/dashboard/routes/dashboard/settings/SettingsSubPageHeader.vue
@@ -10,8 +10,8 @@
 <script>
 export default {
   props: {
-    headerTitle: String,
-    headerContent: String,
+    headerTitle: { type: String, default: '' },
+    headerContent: { type: String, default: '' },
   },
 };
 </script>
diff --git a/app/javascript/dashboard/routes/dashboard/settings/Wrapper.vue b/app/javascript/dashboard/routes/dashboard/settings/Wrapper.vue
index c289cea17..4842c0244 100644
--- a/app/javascript/dashboard/routes/dashboard/settings/Wrapper.vue
+++ b/app/javascript/dashboard/routes/dashboard/settings/Wrapper.vue
@@ -25,9 +25,9 @@ export default {
     SettingsHeader,
   },
   props: {
-    headerTitle: String,
-    headerButtonText: String,
-    icon: String,
+    headerTitle: { type: String, default: '' },
+    headerButtonText: { type: String, default: '' },
+    icon: { type: String, default: '' },
     keepAlive: {
       type: Boolean,
       default: true,
diff --git a/app/javascript/dashboard/routes/dashboard/settings/canned/EditCanned.vue b/app/javascript/dashboard/routes/dashboard/settings/canned/EditCanned.vue
index 5065454da..b9b192e18 100644
--- a/app/javascript/dashboard/routes/dashboard/settings/canned/EditCanned.vue
+++ b/app/javascript/dashboard/routes/dashboard/settings/canned/EditCanned.vue
@@ -61,10 +61,10 @@ export default {
     Modal,
   },
   props: {
-    id: Number,
-    edcontent: String,
-    edshortCode: String,
-    onClose: Function,
+    id: { type: Number, default: null },
+    edcontent: { type: String, default: '' },
+    edshortCode: { type: String, default: '' },
+    onClose: { type: Function, default: () => {} },
   },
   data() {
     return {
diff --git a/app/javascript/dashboard/routes/dashboard/settings/integrationapps/IntegrationItem.vue b/app/javascript/dashboard/routes/dashboard/settings/integrationapps/IntegrationItem.vue
index 198f070ce..2e822559f 100644
--- a/app/javascript/dashboard/routes/dashboard/settings/integrationapps/IntegrationItem.vue
+++ b/app/javascript/dashboard/routes/dashboard/settings/integrationapps/IntegrationItem.vue
@@ -47,8 +47,8 @@ export default {
   mixins: [globalConfigMixin],
   props: {
     integrationId: {
-      type: String,
-      default: '',
+      type: [String, Number],
+      required: true,
     },
     integrationLogo: {
       type: String,
diff --git a/app/javascript/dashboard/routes/dashboard/settings/integrations/Integration.vue b/app/javascript/dashboard/routes/dashboard/settings/integrations/Integration.vue
index 99d172e4e..7d4af88c0 100644
--- a/app/javascript/dashboard/routes/dashboard/settings/integrations/Integration.vue
+++ b/app/javascript/dashboard/routes/dashboard/settings/integrations/Integration.vue
@@ -68,14 +68,17 @@ import globalConfigMixin from 'shared/mixins/globalConfigMixin';
 
 export default {
   mixins: [alertMixin, globalConfigMixin],
-  props: [
-    'integrationId',
-    'integrationLogo',
-    'integrationName',
-    'integrationDescription',
-    'integrationEnabled',
-    'integrationAction',
-  ],
+  props: {
+    integrationId: {
+      type: [String, Number],
+      required: true,
+    },
+    integrationLogo: { type: String, default: '' },
+    integrationName: { type: String, default: '' },
+    integrationDescription: { type: String, default: '' },
+    integrationEnabled: { type: Boolean, default: false },
+    integrationAction: { type: String, default: '' },
+  },
   data() {
     return {
       showDeleteConfirmationPopup: false,
diff --git a/app/javascript/dashboard/routes/dashboard/settings/integrations/ShowIntegration.vue b/app/javascript/dashboard/routes/dashboard/settings/integrations/ShowIntegration.vue
index f12b9d295..5d8a925bb 100644
--- a/app/javascript/dashboard/routes/dashboard/settings/integrations/ShowIntegration.vue
+++ b/app/javascript/dashboard/routes/dashboard/settings/integrations/ShowIntegration.vue
@@ -33,7 +33,14 @@ export default {
     IntegrationHelpText,
   },
   mixins: [globalConfigMixin],
-  props: ['integrationId', 'code'],
+
+  props: {
+    integrationId: {
+      type: [String, Number],
+      required: true,
+    },
+    code: { type: String, default: '' },
+  },
   data() {
     return {
       integrationLoaded: false,
diff --git a/app/javascript/shared/components/GreetingsEditor.vue b/app/javascript/shared/components/GreetingsEditor.vue
index 86eef8a8c..2e9130886 100644
--- a/app/javascript/shared/components/GreetingsEditor.vue
+++ b/app/javascript/shared/components/GreetingsEditor.vue
@@ -56,7 +56,7 @@ export default {
     };
   },
   watch: {
-    value: function(newValue) {
+    value(newValue) {
       this.greetingsMessage = newValue;
     },
   },
diff --git a/app/javascript/widget/components/ImageBubble.vue b/app/javascript/widget/components/ImageBubble.vue
index 2c4afbe86..2bbd65c8f 100644
--- a/app/javascript/widget/components/ImageBubble.vue
+++ b/app/javascript/widget/components/ImageBubble.vue
@@ -19,7 +19,11 @@
 
 <script>
 export default {
-  props: ['url', 'thumb', 'readableTime'],
+  props: {
+    url: { type: String, default: '' },
+    thumb: { type: String, default: '' },
+    readableTime: { type: String, default: '' },
+  },
   methods: {
     onImgError() {
       this.$emit('error');
diff --git a/app/javascript/widget/components/UserAvatar.vue b/app/javascript/widget/components/UserAvatar.vue
index 1985b9cf1..f7399bcd6 100755
--- a/app/javascript/widget/components/UserAvatar.vue
+++ b/app/javascript/widget/components/UserAvatar.vue
@@ -11,9 +11,11 @@ export default {
   props: {
     src: {
       type: String,
+      default: '',
     },
     size: {
       type: String,
+      default: '',
     },
   },
   computed: {