diff --git a/app/javascript/widget/components/AgentMessage.vue b/app/javascript/widget/components/AgentMessage.vue index e7d592abd..3296d5128 100755 --- a/app/javascript/widget/components/AgentMessage.vue +++ b/app/javascript/widget/components/AgentMessage.vue @@ -9,7 +9,7 @@ import FileBubble from 'widget/components/FileBubble.vue'; import Thumbnail from 'dashboard/components/widgets/Thumbnail.vue'; import { MESSAGE_TYPE } from 'widget/helpers/constants'; import configMixin from '../mixins/configMixin'; -import { useMessage } from '../composables/useMessage'; +import messageMixin from '../mixins/messageMixin'; import { isASubmittedFormMessage } from 'shared/helpers/MessageTypeHelper'; import darkModeMixin from 'widget/mixins/darkModeMixin.js'; import ReplyToChip from 'widget/components/ReplyToChip.vue'; @@ -28,7 +28,7 @@ export default { MessageReplyButton, ReplyToChip, }, - mixins: [configMixin, darkModeMixin], + mixins: [configMixin, messageMixin, darkModeMixin], props: { message: { type: Object, @@ -39,15 +39,6 @@ export default { default: () => {}, }, }, - setup(props) { - const { messageContentAttributes, hasAttachments } = useMessage( - props.message - ); - return { - messageContentAttributes, - hasAttachments, - }; - }, data() { return { hasImageError: false, diff --git a/app/javascript/widget/components/UserMessage.vue b/app/javascript/widget/components/UserMessage.vue index 7c7d844e9..7f8528e08 100755 --- a/app/javascript/widget/components/UserMessage.vue +++ b/app/javascript/widget/components/UserMessage.vue @@ -6,7 +6,7 @@ import VideoBubble from 'widget/components/VideoBubble.vue'; import FluentIcon from 'shared/components/FluentIcon/Index.vue'; import FileBubble from 'widget/components/FileBubble.vue'; import { messageStamp } from 'shared/helpers/timeHelper'; -import { useMessage } from '../composables/useMessage'; +import messageMixin from '../mixins/messageMixin'; import ReplyToChip from 'widget/components/ReplyToChip.vue'; import DragWrapper from 'widget/components/DragWrapper.vue'; import { BUS_EVENTS } from 'shared/constants/busEvents'; @@ -25,6 +25,7 @@ export default { ReplyToChip, DragWrapper, }, + mixins: [messageMixin], props: { message: { type: Object, @@ -35,12 +36,6 @@ export default { default: () => {}, }, }, - setup(props) { - const { hasAttachments } = useMessage(props.message); - return { - hasAttachments, - }; - }, data() { return { hasImageError: false, diff --git a/app/javascript/widget/composables/specs/useMessage.spec.js b/app/javascript/widget/composables/specs/useMessage.spec.js deleted file mode 100644 index 1498c87af..000000000 --- a/app/javascript/widget/composables/specs/useMessage.spec.js +++ /dev/null @@ -1,71 +0,0 @@ -import { describe, it, expect } from 'vitest'; -import { reactive, nextTick } from 'vue'; -import { useMessage } from '../useMessage'; - -describe('useMessage', () => { - it('should handle deleted messages', () => { - const message = reactive({ - content_attributes: { deleted: true }, - attachments: [], - }); - - const { messageContentAttributes, hasAttachments } = useMessage(message); - - expect(messageContentAttributes.value).toEqual({ deleted: true }); - expect(hasAttachments.value).toBe(false); - }); - - it('should handle non-deleted messages with attachments', () => { - const message = reactive({ - content_attributes: {}, - attachments: ['attachment1', 'attachment2'], - }); - - const { messageContentAttributes, hasAttachments } = useMessage(message); - - expect(messageContentAttributes.value).toEqual({}); - expect(hasAttachments.value).toBe(true); - }); - - it('should handle messages without content_attributes', () => { - const message = reactive({ - attachments: [], - }); - - const { messageContentAttributes, hasAttachments } = useMessage(message); - - expect(messageContentAttributes.value).toEqual({}); - expect(hasAttachments.value).toBe(false); - }); - - it('should handle messages with empty attachments array', () => { - const message = reactive({ - content_attributes: { someAttribute: 'value' }, - attachments: [], - }); - - const { messageContentAttributes, hasAttachments } = useMessage(message); - - expect(messageContentAttributes.value).toEqual({ someAttribute: 'value' }); - expect(hasAttachments.value).toBe(false); - }); - - it('should update reactive properties when message changes', async () => { - const message = reactive({ - content_attributes: {}, - attachments: [], - }); - - const { messageContentAttributes, hasAttachments } = useMessage(message); - - expect(messageContentAttributes.value).toEqual({}); - expect(hasAttachments.value).toBe(false); - - message.content_attributes = { updated: true }; - message.attachments.push('newAttachment'); - await nextTick(); - - expect(messageContentAttributes.value).toEqual({ updated: true }); - expect(hasAttachments.value).toBe(true); - }); -}); diff --git a/app/javascript/widget/composables/useMessage.js b/app/javascript/widget/composables/useMessage.js deleted file mode 100644 index 97b7a7800..000000000 --- a/app/javascript/widget/composables/useMessage.js +++ /dev/null @@ -1,22 +0,0 @@ -import { computed } from 'vue'; - -/** - * Composable for handling message-related computations. - * @param {Object} message - The message object to be processed. - * @returns {Object} An object containing computed properties for message content and attachments. - */ -export function useMessage(message) { - const messageContentAttributes = computed(() => { - const { content_attributes: attribute = {} } = message; - return attribute; - }); - - const hasAttachments = computed(() => { - return !!(message.attachments && message.attachments.length > 0); - }); - - return { - messageContentAttributes, - hasAttachments, - }; -} diff --git a/app/javascript/widget/mixins/messageMixin.js b/app/javascript/widget/mixins/messageMixin.js new file mode 100644 index 000000000..dfa1e0e6a --- /dev/null +++ b/app/javascript/widget/mixins/messageMixin.js @@ -0,0 +1,13 @@ +export default { + computed: { + messageContentAttributes() { + const { content_attributes: attribute = {} } = this.message; + return attribute; + }, + hasAttachments() { + return !!( + this.message.attachments && this.message.attachments.length > 0 + ); + }, + }, +}; diff --git a/app/javascript/widget/mixins/specs/messageMixin.spec.js b/app/javascript/widget/mixins/specs/messageMixin.spec.js new file mode 100644 index 000000000..a6443ccd6 --- /dev/null +++ b/app/javascript/widget/mixins/specs/messageMixin.spec.js @@ -0,0 +1,37 @@ +import { shallowMount } from '@vue/test-utils'; +import messageMixin from '../messageMixin'; +import messages from './messageFixture'; + +describe('messageMixin', () => { + let Component = { + render() {}, + title: 'TestComponent', + mixins: [messageMixin], + }; + + it('deleted messages', async () => { + const wrapper = shallowMount(Component, { + data() { + return { + message: messages.deletedMessage, + }; + }, + }); + expect(wrapper.vm.messageContentAttributes).toEqual({ + deleted: true, + }); + expect(wrapper.vm.hasAttachments).toBe(false); + }); + it('non-deleted messages', async () => { + const wrapper = shallowMount(Component, { + data() { + return { + message: messages.nonDeletedMessage, + }; + }, + }); + expect(wrapper.vm.deletedMessage).toBe(undefined); + expect(wrapper.vm.messageContentAttributes).toEqual({}); + expect(wrapper.vm.hasAttachments).toBe(true); + }); +});