mirror of
				https://github.com/lingble/chatwoot.git
				synced 2025-10-31 19:17:48 +00:00 
			
		
		
		
	feat: Eslint rules (#9839)
# Pull Request Template ## Description This PR adds new eslint rules to the code base. **Error rules** | Rule name | Type | Files updated | | ----------------- | --- | - | | `vue/block-order` | error | ✅ | | `vue/component-name-in-template-casing` | error | ✅ | | `vue/component-options-name-casing` | error | ✅ | | `vue/custom-event-name-casing` | error | ✅ | | `vue/define-emits-declaration` | error | ✅ | | `vue/no-unused-properties` | error | ✅ | | `vue/define-macros-order` | error | ✅ | | `vue/define-props-declaration` | error | ✅ | | `vue/match-component-import-name` | error | ✅ | | `vue/next-tick-style` | error | ✅ | | `vue/no-bare-strings-in-template` | error | ✅ | | `vue/no-empty-component-block` | error | ✅ | | `vue/no-multiple-objects-in-class` | error | ✅ | | `vue/no-required-prop-with-default` | error | ✅ | | `vue/no-static-inline-styles` | error | ✅ | | `vue/no-template-target-blank` | error | ✅ | | `vue/no-this-in-before-route-enter` | error | ✅ | | `vue/no-undef-components` | error | ✅ | | `vue/no-unused-emit-declarations` | error | ✅ | | `vue/no-unused-refs` | error | ✅ | | `vue/no-use-v-else-with-v-for` | error | ✅ | | `vue/no-useless-v-bind` | error | ✅ | | `vue/no-v-text` | error | ✅ | | `vue/padding-line-between-blocks` | error | ✅ | | ~`vue/prefer-prop-type-boolean-first`~ | ~error~ | ❌ (removed this rule, cause a bug in displaying custom attributes) | | `vue/prefer-separate-static-class` | error | ✅ | | `vue/prefer-true-attribute-shorthand` | error | ✅ | | `vue/require-explicit-slots` | error | ✅ | | `vue/require-macro-variable-name` | error | ✅ | **Warn rules** | Rule name | Type | Files updated | | ---- | ------------- | ------------- | | `vue/no-root-v-if` | warn | ❎ | Fixes https://linear.app/chatwoot/issue/CW-3492/vue-eslint-rules ## Type of change - [x] New feature (non-breaking change which adds functionality) ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules --------- Co-authored-by: Fayaz Ahmed <fayazara@gmail.com> Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com> Co-authored-by: Shivam Mishra <scm.mymail@gmail.com> Co-authored-by: Pranav <pranav@chatwoot.com>
This commit is contained in:
		| @@ -1,53 +1,3 @@ | ||||
| <template> | ||||
|   <woot-modal | ||||
|     :show="show" | ||||
|     :on-close="() => $emit('close-account-create-modal')" | ||||
|   > | ||||
|     <div class="h-auto overflow-auto flex flex-col"> | ||||
|       <woot-modal-header | ||||
|         :header-title="$t('CREATE_ACCOUNT.NEW_ACCOUNT')" | ||||
|         :header-content="$t('CREATE_ACCOUNT.SELECTOR_SUBTITLE')" | ||||
|       /> | ||||
|       <div v-if="!hasAccounts" class="text-sm mt-6 mx-8 mb-0"> | ||||
|         <div class="items-center rounded-md flex alert"> | ||||
|           <div class="ml-1 mr-3"> | ||||
|             <fluent-icon icon="warning" /> | ||||
|           </div> | ||||
|           {{ $t('CREATE_ACCOUNT.NO_ACCOUNT_WARNING') }} | ||||
|         </div> | ||||
|       </div> | ||||
|  | ||||
|       <form class="flex flex-col w-full" @submit.prevent="addAccount"> | ||||
|         <div class="w-full"> | ||||
|           <label :class="{ error: v$.accountName.$error }"> | ||||
|             {{ $t('CREATE_ACCOUNT.FORM.NAME.LABEL') }} | ||||
|             <input | ||||
|               v-model.trim="accountName" | ||||
|               type="text" | ||||
|               :placeholder="$t('CREATE_ACCOUNT.FORM.NAME.PLACEHOLDER')" | ||||
|               @input="v$.accountName.$touch" | ||||
|             /> | ||||
|           </label> | ||||
|         </div> | ||||
|         <div class="w-full"> | ||||
|           <div class="w-full"> | ||||
|             <woot-submit-button | ||||
|               :disabled=" | ||||
|                 v$.accountName.$invalid || | ||||
|                 v$.accountName.$invalid || | ||||
|                 uiFlags.isCreating | ||||
|               " | ||||
|               :button-text="$t('CREATE_ACCOUNT.FORM.SUBMIT')" | ||||
|               :loading="uiFlags.isCreating" | ||||
|               button-class="large expanded" | ||||
|             /> | ||||
|           </div> | ||||
|         </div> | ||||
|       </form> | ||||
|     </div> | ||||
|   </woot-modal> | ||||
| </template> | ||||
|  | ||||
| <script> | ||||
| import { useVuelidate } from '@vuelidate/core'; | ||||
| import { required, minLength } from '@vuelidate/validators'; | ||||
| @@ -90,7 +40,7 @@ export default { | ||||
|         const account_id = await this.$store.dispatch('accounts/create', { | ||||
|           account_name: this.accountName, | ||||
|         }); | ||||
|         this.$emit('close-account-create-modal'); | ||||
|         this.$emit('closeAccountCreateModal'); | ||||
|         useAlert(this.$t('CREATE_ACCOUNT.API.SUCCESS_MESSAGE')); | ||||
|         window.location = `/app/accounts/${account_id}/dashboard`; | ||||
|       } catch (error) { | ||||
| @@ -104,3 +54,50 @@ export default { | ||||
|   }, | ||||
| }; | ||||
| </script> | ||||
|  | ||||
| <template> | ||||
|   <woot-modal :show="show" :on-close="() => $emit('closeAccountCreateModal')"> | ||||
|     <div class="flex flex-col h-auto overflow-auto"> | ||||
|       <woot-modal-header | ||||
|         :header-title="$t('CREATE_ACCOUNT.NEW_ACCOUNT')" | ||||
|         :header-content="$t('CREATE_ACCOUNT.SELECTOR_SUBTITLE')" | ||||
|       /> | ||||
|       <div v-if="!hasAccounts" class="mx-8 mt-6 mb-0 text-sm"> | ||||
|         <div class="flex items-center rounded-md alert"> | ||||
|           <div class="ml-1 mr-3"> | ||||
|             <fluent-icon icon="warning" /> | ||||
|           </div> | ||||
|           {{ $t('CREATE_ACCOUNT.NO_ACCOUNT_WARNING') }} | ||||
|         </div> | ||||
|       </div> | ||||
|  | ||||
|       <form class="flex flex-col w-full" @submit.prevent="addAccount"> | ||||
|         <div class="w-full"> | ||||
|           <label :class="{ error: v$.accountName.$error }"> | ||||
|             {{ $t('CREATE_ACCOUNT.FORM.NAME.LABEL') }} | ||||
|             <input | ||||
|               v-model.trim="accountName" | ||||
|               type="text" | ||||
|               :placeholder="$t('CREATE_ACCOUNT.FORM.NAME.PLACEHOLDER')" | ||||
|               @input="v$.accountName.$touch" | ||||
|             /> | ||||
|           </label> | ||||
|         </div> | ||||
|         <div class="w-full"> | ||||
|           <div class="w-full"> | ||||
|             <woot-submit-button | ||||
|               :disabled=" | ||||
|                 v$.accountName.$invalid || | ||||
|                 v$.accountName.$invalid || | ||||
|                 uiFlags.isCreating | ||||
|               " | ||||
|               :button-text="$t('CREATE_ACCOUNT.FORM.SUBMIT')" | ||||
|               :loading="uiFlags.isCreating" | ||||
|               button-class="large expanded" | ||||
|             /> | ||||
|           </div> | ||||
|         </div> | ||||
|       </form> | ||||
|     </div> | ||||
|   </woot-modal> | ||||
| </template> | ||||
|   | ||||
		Reference in New Issue
	
	Block a user
	 Sivin Varghese
					Sivin Varghese