From d5ecbba71f970c51650de26f097bc3f77ca3f50a Mon Sep 17 00:00:00 2001 From: Baptiste Fontaine Date: Thu, 6 Feb 2025 05:13:38 +0100 Subject: [PATCH] fix: onboarding/index.html.erb unclosed HTML tags (#10838) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit # Pull Request Template ## Description This was not really an issue because HTML is permissive and auto-closes these when the parent is closed, but it’s cleaner to do it. It was also showing errors if you open the project in an IDE. ## Type of change - Chore ## How Has This Been Tested? ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] Any dependent changes have been merged and published in downstream modules Co-authored-by: Shivam Mishra --- app/views/installation/onboarding/index.html.erb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/views/installation/onboarding/index.html.erb b/app/views/installation/onboarding/index.html.erb index 220da62dd..8b337d16c 100644 --- a/app/views/installation/onboarding/index.html.erb +++ b/app/views/installation/onboarding/index.html.erb @@ -70,7 +70,9 @@ Finish Setup - <% end %> + <% end %> + +