feat: Add activity messages for linear actions (#11654)

spec/controllers/api/v1/accounts/integrations/linear_controller_spec.rb

@@ -93,6 +93,8 @@ RSpec.describe 'Linear Integration API', type: :request do
   end
 
   describe 'POST /api/v1/accounts/:account_id/integrations/linear/create_issue' do
+    let(:inbox) { create(:inbox, account: account) }
+    let(:conversation) { create(:conversation, account: account, inbox: inbox) }
     let(:issue_params) do
       {
         team_id: 'team1',
@@ -101,32 +103,56 @@ RSpec.describe 'Linear Integration API', type: :request do
         assignee_id: 'user1',
         priority: 'high',
         state_id: 'state1',
-        label_ids: ['label1']
+        label_ids: ['label1'],
+        conversation_id: conversation.display_id
       }
     end
 
     context 'when it is an authenticated user' do
       context 'when the issue is created successfully' do
-        let(:created_issue) { { data: { 'id' => 'issue1', 'title' => 'Sample Issue' } } }
+        let(:created_issue) { { data: { identifier: 'ENG-123', title: 'Sample Issue' } } }
 
         it 'returns the created issue' do
           allow(processor_service).to receive(:create_issue).with(issue_params.stringify_keys).and_return(created_issue)
+
           post "/api/v1/accounts/#{account.id}/integrations/linear/create_issue",
                params: issue_params,
                headers: agent.create_new_auth_token,
                as: :json
+
           expect(response).to have_http_status(:ok)
           expect(response.body).to include('Sample Issue')
         end
+
+        it 'creates activity message when conversation is provided' do
+          allow(processor_service).to receive(:create_issue).with(issue_params.stringify_keys).and_return(created_issue)
+
+          expect do
+            post "/api/v1/accounts/#{account.id}/integrations/linear/create_issue",
+                 params: issue_params,
+                 headers: agent.create_new_auth_token,
+                 as: :json
+          end.to have_enqueued_job(Conversations::ActivityMessageJob)
+            .with(conversation, {
+                    account_id: conversation.account_id,
+                    inbox_id: conversation.inbox_id,
+                    message_type: :activity,
+                    content: "Linear issue ENG-123 was created by #{agent.name}"
+                  })
+        end
       end
 
       context 'when issue creation fails' do
-        it 'returns error message' do
+        it 'returns error message and does not create activity message' do
           allow(processor_service).to receive(:create_issue).with(issue_params.stringify_keys).and_return(error: 'error message')
-          post "/api/v1/accounts/#{account.id}/integrations/linear/create_issue",
-               params: issue_params,
-               headers: agent.create_new_auth_token,
-               as: :json
+
+          expect do
+            post "/api/v1/accounts/#{account.id}/integrations/linear/create_issue",
+                 params: issue_params,
+                 headers: agent.create_new_auth_token,
+                 as: :json
+          end.not_to have_enqueued_job(Conversations::ActivityMessageJob)
+
           expect(response).to have_http_status(:unprocessable_entity)
           expect(response.body).to include('error message')
         end
@@ -135,7 +161,7 @@ RSpec.describe 'Linear Integration API', type: :request do
   end
 
   describe 'POST /api/v1/accounts/:account_id/integrations/linear/link_issue' do
-    let(:issue_id) { 'issue1' }
+    let(:issue_id) { 'ENG-456' }
     let(:conversation) { create(:conversation, account: account) }
     let(:link) { "#{ENV.fetch('FRONTEND_URL', nil)}/app/accounts/#{account.id}/conversations/#{conversation.display_id}" }
     let(:title) { 'Sample Issue' }
@@ -144,24 +170,38 @@ RSpec.describe 'Linear Integration API', type: :request do
       context 'when the issue is linked successfully' do
         let(:linked_issue) { { data: { 'id' => 'issue1', 'link' => 'https://linear.app/issue1' } } }
 
-        it 'returns the linked issue' do
+        it 'returns the linked issue and creates activity message' do
           allow(processor_service).to receive(:link_issue).with(link, issue_id, title).and_return(linked_issue)
-          post "/api/v1/accounts/#{account.id}/integrations/linear/link_issue",
-               params: { conversation_id: conversation.display_id, issue_id: issue_id, title: title },
-               headers: agent.create_new_auth_token,
-               as: :json
+
+          expect do
+            post "/api/v1/accounts/#{account.id}/integrations/linear/link_issue",
+                 params: { conversation_id: conversation.display_id, issue_id: issue_id, title: title },
+                 headers: agent.create_new_auth_token,
+                 as: :json
+          end.to have_enqueued_job(Conversations::ActivityMessageJob)
+            .with(conversation, {
+                    account_id: conversation.account_id,
+                    inbox_id: conversation.inbox_id,
+                    message_type: :activity,
+                    content: "Linear issue ENG-456 was linked by #{agent.name}"
+                  })
+
           expect(response).to have_http_status(:ok)
           expect(response.body).to include('https://linear.app/issue1')
         end
       end
 
       context 'when issue linking fails' do
-        it 'returns error message' do
+        it 'returns error message and does not create activity message' do
           allow(processor_service).to receive(:link_issue).with(link, issue_id, title).and_return(error: 'error message')
-          post "/api/v1/accounts/#{account.id}/integrations/linear/link_issue",
-               params: { conversation_id: conversation.display_id, issue_id: issue_id, title: title },
-               headers: agent.create_new_auth_token,
-               as: :json
+
+          expect do
+            post "/api/v1/accounts/#{account.id}/integrations/linear/link_issue",
+                 params: { conversation_id: conversation.display_id, issue_id: issue_id, title: title },
+                 headers: agent.create_new_auth_token,
+                 as: :json
+          end.not_to have_enqueued_job(Conversations::ActivityMessageJob)
+
           expect(response).to have_http_status(:unprocessable_entity)
           expect(response.body).to include('error message')
         end
@@ -171,29 +211,45 @@ RSpec.describe 'Linear Integration API', type: :request do
 
   describe 'POST /api/v1/accounts/:account_id/integrations/linear/unlink_issue' do
     let(:link_id) { 'attachment1' }
+    let(:issue_id) { 'ENG-789' }
+    let(:conversation) { create(:conversation, account: account) }
 
     context 'when it is an authenticated user' do
       context 'when the issue is unlinked successfully' do
         let(:unlinked_issue) { { data: { 'id' => 'issue1', 'link' => 'https://linear.app/issue1' } } }
 
-        it 'returns the unlinked issue' do
+        it 'returns the unlinked issue and creates activity message' do
           allow(processor_service).to receive(:unlink_issue).with(link_id).and_return(unlinked_issue)
-          post "/api/v1/accounts/#{account.id}/integrations/linear/unlink_issue",
-               params: { link_id: link_id },
-               headers: agent.create_new_auth_token,
-               as: :json
+
+          expect do
+            post "/api/v1/accounts/#{account.id}/integrations/linear/unlink_issue",
+                 params: { link_id: link_id, issue_id: issue_id, conversation_id: conversation.display_id },
+                 headers: agent.create_new_auth_token,
+                 as: :json
+          end.to have_enqueued_job(Conversations::ActivityMessageJob)
+            .with(conversation, {
+                    account_id: conversation.account_id,
+                    inbox_id: conversation.inbox_id,
+                    message_type: :activity,
+                    content: "Linear issue ENG-789 was unlinked by #{agent.name}"
+                  })
+
           expect(response).to have_http_status(:ok)
           expect(response.body).to include('https://linear.app/issue1')
         end
       end
 
       context 'when issue unlinking fails' do
-        it 'returns error message' do
+        it 'returns error message and does not create activity message' do
           allow(processor_service).to receive(:unlink_issue).with(link_id).and_return(error: 'error message')
-          post "/api/v1/accounts/#{account.id}/integrations/linear/unlink_issue",
-               params: { link_id: link_id },
-               headers: agent.create_new_auth_token,
-               as: :json
+
+          expect do
+            post "/api/v1/accounts/#{account.id}/integrations/linear/unlink_issue",
+                 params: { link_id: link_id, issue_id: issue_id, conversation_id: conversation.display_id },
+                 headers: agent.create_new_auth_token,
+                 as: :json
+          end.not_to have_enqueued_job(Conversations::ActivityMessageJob)
+
           expect(response).to have_http_status(:unprocessable_entity)
           expect(response.body).to include('error message')
         end