Shivam Mishra
dadd572f9d
refactor: useKeyboardEvents composable ( #9959 )
...
This PR has the following changes
1. Fix tab styles issue caused by adding an additional wrapper for
getting an element ref on `ChatTypeTabs.vue`
2. Refactor `useKeyboardEvents` composable to not require an element
ref. It will use a local abort controller to abort any listener
---------
Co-authored-by: Sivin Varghese <64252451+iamsivin@users.noreply.github.com >
2024-08-22 16:40:55 +05:30
Sivin Varghese
74bbbd25b9
feat: Replace the use of keyboardEventListener mixin to a composable (Part -3) ( #9897 )
2024-08-08 12:40:56 +05:30
Sivin Varghese
b4b308336f
feat: Eslint rules ( #9839 )
...
# Pull Request Template
## Description
This PR adds new eslint rules to the code base.
**Error rules**
| Rule name | Type | Files updated |
| ----------------- | --- | - |
| `vue/block-order` | error | ✅ |
| `vue/component-name-in-template-casing` | error | ✅ |
| `vue/component-options-name-casing` | error | ✅ |
| `vue/custom-event-name-casing` | error | ✅ |
| `vue/define-emits-declaration` | error | ✅ |
| `vue/no-unused-properties` | error | ✅ |
| `vue/define-macros-order` | error | ✅ |
| `vue/define-props-declaration` | error | ✅ |
| `vue/match-component-import-name` | error | ✅ |
| `vue/next-tick-style` | error | ✅ |
| `vue/no-bare-strings-in-template` | error | ✅ |
| `vue/no-empty-component-block` | error | ✅ |
| `vue/no-multiple-objects-in-class` | error | ✅ |
| `vue/no-required-prop-with-default` | error | ✅ |
| `vue/no-static-inline-styles` | error | ✅ |
| `vue/no-template-target-blank` | error | ✅ |
| `vue/no-this-in-before-route-enter` | error | ✅ |
| `vue/no-undef-components` | error | ✅ |
| `vue/no-unused-emit-declarations` | error | ✅ |
| `vue/no-unused-refs` | error | ✅ |
| `vue/no-use-v-else-with-v-for` | error | ✅ |
| `vue/no-useless-v-bind` | error | ✅ |
| `vue/no-v-text` | error | ✅ |
| `vue/padding-line-between-blocks` | error | ✅ |
| ~`vue/prefer-prop-type-boolean-first`~ | ~error~ | ❌ (removed this
rule, cause a bug in displaying custom attributes) |
| `vue/prefer-separate-static-class` | error | ✅ |
| `vue/prefer-true-attribute-shorthand` | error | ✅ |
| `vue/require-explicit-slots` | error | ✅ |
| `vue/require-macro-variable-name` | error | ✅ |
**Warn rules**
| Rule name | Type | Files updated |
| ---- | ------------- | ------------- |
| `vue/no-root-v-if` | warn | ❎ |
Fixes https://linear.app/chatwoot/issue/CW-3492/vue-eslint-rules
## Type of change
- [x] New feature (non-breaking change which adds functionality)
## Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my code
- [x] I have commented on my code, particularly in hard-to-understand
areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream
modules
---------
Co-authored-by: Fayaz Ahmed <fayazara@gmail.com >
Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com >
Co-authored-by: Shivam Mishra <scm.mymail@gmail.com >
Co-authored-by: Pranav <pranav@chatwoot.com >
2024-08-05 14:02:16 +05:30
Shivam Mishra
7f8ac37a30
feat: don't allow dropdown navigation on input focused ( #9341 )
...
Co-authored-by: Sivin Varghese <64252451+iamsivin@users.noreply.github.com >
2024-05-02 21:09:08 +05:30
Shivam Mishra
47f8b2cd0c
refactor: handling keyboard shortcuts ( #9242 )
...
* fix: Resolve and go next keyboard shortcuts doesn't work
* refactor: use buildHotKeys instead of hasPressedCommandPlusAltAndEKey
* feat: install tinykeys
* refactor: use tinykeys
* test: update buildKeyEvents
* fix: remove stray import
* feat: handle action list globally
* feat: allow configuring `allowOnFocusedInput`
* chore: Navigate chat list item
* chore: Navigate dashboard
* feat: Navigate editor top panel
* feat: Toggle file upload
* chore: More keyboard shortcuts
* chore: Update mention selection mixin
* chore: Phone input
* chore: Clean up
* chore: Clean up
* chore: Dropdown and editor
* chore: Enter key to send and clean up
* chore: Rename mixin
* chore: Review fixes
* chore: Removed unused shortcut from modal
* fix: Specs
---------
Co-authored-by: iamsivin <iamsivin@gmail.com >
Co-authored-by: Sivin Varghese <64252451+iamsivin@users.noreply.github.com >
2024-04-26 15:41:02 +05:30
Pranav Raj S
7bb8186e43
chore: Update self-closing tag eslint config ( #4826 )
...
* chore: Fix self-closing tag issues
* Fix merge conflicts
Co-authored-by: Fayaz Ahmed <15716057+fayazara@users.noreply.github.com >
2022-06-10 19:29:52 +05:30
Sivin Varghese
0e4196c91a
enhancement: Removes the focus of the first item in the dropdown when it is active. ( #2833 )
2021-08-16 22:11:20 +05:30
Nithin David Thomas
dfcc33cbdd
fix: Fixes error when dropdown button is focused ( #2797 )
...
Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com >
2021-08-13 13:40:12 +05:30
Sivin Varghese
c523a953f7
feat: Adds keyboard shortcuts for conversation actions ( #2672 )
...
* feat: Adds keyboard shortcuts for conversation actions
* Minor fixes
* Minor fixes
* Minor fixes and add new shortcut
* MInor fixes
* Review fixes
* Minor fixes
* Code cleanup
* Minor fixes
* Uses Alt or Option key instead of shift-key
* Review fixes
* Review fixes
Co-authored-by: Pranav Raj S <pranav@chatwoot.com >
Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com >
2021-08-09 00:38:52 -07:00
Sivin Varghese
e289106c5b
Chore: Hover color for status dropdown ( #1906 )
2021-03-20 13:08:56 +05:30
