mirror of
https://github.com/lingble/chatwoot.git
synced 2025-11-03 04:27:53 +00:00
# Pull Request Template ## Description The `auto_assignment` max_limits were being enforced even if the inbox level `auto_assign` feature was disabled. This was because the enterprise method was not verifying the feature status before returning the available agents. ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? - Tested locally - Added Specs ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [x] Any dependent changes have been merged and published in downstream modules
109 lines
4.4 KiB
Ruby
109 lines
4.4 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe Conversation, type: :model do
|
|
describe 'associations' do
|
|
it { is_expected.to belong_to(:sla_policy).optional }
|
|
end
|
|
|
|
describe 'SLA policy updates' do
|
|
let!(:conversation) { create(:conversation) }
|
|
let!(:sla_policy) { create(:sla_policy, account: conversation.account) }
|
|
|
|
it 'generates an activity message when the SLA policy is updated' do
|
|
conversation.update!(sla_policy_id: sla_policy.id)
|
|
|
|
perform_enqueued_jobs
|
|
|
|
activity_message = conversation.messages.where(message_type: 'activity').last
|
|
|
|
expect(activity_message).not_to be_nil
|
|
expect(activity_message.message_type).to eq('activity')
|
|
expect(activity_message.content).to include('added SLA policy')
|
|
end
|
|
|
|
# TODO: Reenable this when we let the SLA policy be removed from a conversation
|
|
# it 'generates an activity message when the SLA policy is removed' do
|
|
# conversation.update!(sla_policy_id: sla_policy.id)
|
|
# conversation.update!(sla_policy_id: nil)
|
|
|
|
# perform_enqueued_jobs
|
|
|
|
# activity_message = conversation.messages.where(message_type: 'activity').last
|
|
|
|
# expect(activity_message).not_to be_nil
|
|
# expect(activity_message.message_type).to eq('activity')
|
|
# expect(activity_message.content).to include('removed SLA policy')
|
|
# end
|
|
end
|
|
|
|
describe 'sla_policy' do
|
|
let(:account) { create(:account) }
|
|
let(:conversation) { create(:conversation, account: account) }
|
|
let(:sla_policy) { create(:sla_policy, account: account) }
|
|
let(:different_account_sla_policy) { create(:sla_policy) }
|
|
|
|
context 'when sla_policy is getting updated' do
|
|
it 'throws error if sla policy belongs to different account' do
|
|
conversation.sla_policy = different_account_sla_policy
|
|
expect(conversation.valid?).to be false
|
|
expect(conversation.errors[:sla_policy]).to include('sla policy account mismatch')
|
|
end
|
|
|
|
it 'creates applied sla record if sla policy is present' do
|
|
conversation.sla_policy = sla_policy
|
|
conversation.save!
|
|
expect(conversation.applied_sla.sla_policy_id).to eq(sla_policy.id)
|
|
end
|
|
end
|
|
|
|
context 'when conversation already has a different sla' do
|
|
before do
|
|
conversation.update(sla_policy: create(:sla_policy, account: account))
|
|
end
|
|
|
|
it 'throws error if trying to assing a different sla' do
|
|
conversation.sla_policy = sla_policy
|
|
expect(conversation.valid?).to be false
|
|
expect(conversation.errors[:sla_policy]).to eq(['conversation already has a different sla'])
|
|
end
|
|
|
|
it 'throws error if trying to set sla to nil' do
|
|
conversation.sla_policy = nil
|
|
expect(conversation.valid?).to be false
|
|
expect(conversation.errors[:sla_policy]).to eq(['cannot remove sla policy from conversation'])
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'assignment capacity limits' do
|
|
describe 'team assignment with inbox auto-assignment disabled' do
|
|
let(:account) { create(:account) }
|
|
let(:inbox) { create(:inbox, account: account, enable_auto_assignment: false, auto_assignment_config: { max_assignment_limit: 1 }) }
|
|
let(:team) { create(:team, account: account, allow_auto_assign: true) }
|
|
let!(:agent1) { create(:user, account: account, role: :agent, auto_offline: false) }
|
|
let!(:agent2) { create(:user, account: account, role: :agent, auto_offline: false) }
|
|
|
|
before do
|
|
create(:inbox_member, inbox: inbox, user: agent1)
|
|
create(:inbox_member, inbox: inbox, user: agent2)
|
|
create(:team_member, team: team, user: agent1)
|
|
create(:team_member, team: team, user: agent2)
|
|
# Both agents are over the limit (simulate by assigning open conversations)
|
|
create_list(:conversation, 2, inbox: inbox, assignee: agent1, status: :open)
|
|
create_list(:conversation, 2, inbox: inbox, assignee: agent2, status: :open)
|
|
end
|
|
|
|
it 'does not enforce max_assignment_limit for team assignment when inbox auto-assignment is disabled' do
|
|
conversation = create(:conversation, inbox: inbox, account: account, assignee: nil, status: :open)
|
|
|
|
# Assign to team to trigger the assignment logic
|
|
conversation.update!(team: team)
|
|
|
|
# Should assign to a team member even if they are over the limit
|
|
expect(conversation.reload.assignee).to be_present
|
|
expect([agent1, agent2]).to include(conversation.reload.assignee)
|
|
end
|
|
end
|
|
end
|
|
end
|