mirror of
https://github.com/lingble/chatwoot.git
synced 2026-01-10 14:31:26 +00:00
Fixes https://linear.app/chatwoot/issue/CW-5692/whatsapp-es-numbers-stuck-in-pending-due-to-premature-registration ### Problem Multiple customers reported that their WhatsApp numbers remain stuck in **Pending** in WhatsApp Manager even after successful onboarding. - Our system triggers a **registration call** (`/<PHONE_NUMBER_ID>/register`) as soon as the number is OTP verified. - In many cases, Meta hasn’t finished **display name review/provisioning**, so the call fails with: ``` code: 100, error_subcode: 2388001 error_user_title: "Cannot Create Certificate" error_user_msg: "Your display name could not be processed. Please edit your display name and try again." ``` - This leaves the number stuck in Pending, no messaging can start until we manually retry registration. - Some customers have reported being stuck in this state for **7+ days**. ### Root cause - We only check `code_verification_status = VERIFIED` before attempting registration. - We **don’t wait** for display name provisioning (`name_status` / `platform_type`) to be complete. - As a result, registration fails prematurely and the number never transitions out of Pending. ### Solution #### 1. Health Status Monitoring - Build a backend service to fetch **real-time health data** from Graph API: - `code_verification_status` - `name_status` / `display_name_status` - `platform_type` - `throughput.level` - `messaging_limit_tier` - `quality_rating` - Expose health data via API (`/api/v1/accounts/:account_id/inboxes/:id/health`). - Display this in the UI as an **Account Health tab** with clear badges and direct links to WhatsApp Manager. #### 2. Smarter Registration Logic - Update `WebhookSetupService` to include a **dual-condition check**: - Register if: 1. Phone is **not verified**, OR 2. Phone is **verified but provisioning incomplete** (`platform_type = NOT_APPLICABLE`, `throughput.level = NOT_APPLICABLE`). - Skip registration if number is already provisioned. - Retry registration automatically when stuck. - Provide a UI banner with complete registration button so customers can retry without manual support. ### Screenshot <img width="2292" height="1344" alt="CleanShot 2025-09-30 at 16 01 03@2x" src="https://github.com/user-attachments/assets/1c417d2a-b11c-475e-b092-3c5671ee59a7" /> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Sivin Varghese <64252451+iamsivin@users.noreply.github.com>
327 lines
16 KiB
Ruby
327 lines
16 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe Whatsapp::WebhookSetupService do
|
|
let(:channel) do
|
|
create(:channel_whatsapp,
|
|
phone_number: '+1234567890',
|
|
provider_config: {
|
|
'phone_number_id' => '123456789',
|
|
'webhook_verify_token' => 'test_verify_token'
|
|
},
|
|
provider: 'whatsapp_cloud',
|
|
sync_templates: false,
|
|
validate_provider_config: false)
|
|
end
|
|
let(:waba_id) { 'test_waba_id' }
|
|
let(:access_token) { 'test_access_token' }
|
|
let(:service) { described_class.new(channel, waba_id, access_token) }
|
|
let(:api_client) { instance_double(Whatsapp::FacebookApiClient) }
|
|
let(:health_service) { instance_double(Whatsapp::HealthService) }
|
|
|
|
before do
|
|
# Stub webhook teardown to prevent HTTP calls during cleanup
|
|
stub_request(:delete, /graph.facebook.com/).to_return(status: 200, body: '{}', headers: {})
|
|
|
|
# Clean up any existing channels to avoid phone number conflicts
|
|
Channel::Whatsapp.destroy_all
|
|
allow(Whatsapp::FacebookApiClient).to receive(:new).and_return(api_client)
|
|
allow(Whatsapp::HealthService).to receive(:new).and_return(health_service)
|
|
|
|
# Default stubs for phone_number_verified? and health service
|
|
allow(api_client).to receive(:phone_number_verified?).and_return(false)
|
|
allow(health_service).to receive(:fetch_health_status).and_return({
|
|
platform_type: 'APPLICABLE',
|
|
throughput: { level: 'APPLICABLE' }
|
|
})
|
|
end
|
|
|
|
describe '#perform' do
|
|
context 'when phone number is NOT verified (should register)' do
|
|
before do
|
|
allow(api_client).to receive(:phone_number_verified?).with('123456789').and_return(false)
|
|
allow(SecureRandom).to receive(:random_number).with(900_000).and_return(123_456)
|
|
allow(api_client).to receive(:register_phone_number).with('123456789', 223_456)
|
|
allow(api_client).to receive(:subscribe_waba_webhook)
|
|
.with(waba_id, anything, 'test_verify_token').and_return({ 'success' => true })
|
|
allow(channel).to receive(:save!)
|
|
end
|
|
|
|
it 'registers the phone number and sets up webhook' do
|
|
with_modified_env FRONTEND_URL: 'https://app.chatwoot.com' do
|
|
expect(api_client).to receive(:register_phone_number).with('123456789', 223_456)
|
|
expect(api_client).to receive(:subscribe_waba_webhook)
|
|
.with(waba_id, 'https://app.chatwoot.com/webhooks/whatsapp/+1234567890', 'test_verify_token')
|
|
service.perform
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when phone number IS verified AND fully provisioned (should NOT register)' do
|
|
before do
|
|
allow(api_client).to receive(:phone_number_verified?).with('123456789').and_return(true)
|
|
allow(health_service).to receive(:fetch_health_status).and_return({
|
|
platform_type: 'APPLICABLE',
|
|
throughput: { level: 'APPLICABLE' }
|
|
})
|
|
allow(api_client).to receive(:subscribe_waba_webhook)
|
|
.with(waba_id, anything, 'test_verify_token').and_return({ 'success' => true })
|
|
end
|
|
|
|
it 'does NOT register phone, but sets up webhook' do
|
|
with_modified_env FRONTEND_URL: 'https://app.chatwoot.com' do
|
|
expect(api_client).not_to receive(:register_phone_number)
|
|
expect(api_client).to receive(:subscribe_waba_webhook)
|
|
.with(waba_id, 'https://app.chatwoot.com/webhooks/whatsapp/+1234567890', 'test_verify_token')
|
|
service.perform
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when phone number IS verified BUT needs registration (pending provisioning)' do
|
|
before do
|
|
allow(api_client).to receive(:phone_number_verified?).with('123456789').and_return(true)
|
|
allow(health_service).to receive(:fetch_health_status).and_return({
|
|
platform_type: 'NOT_APPLICABLE',
|
|
throughput: { level: 'APPLICABLE' }
|
|
})
|
|
allow(SecureRandom).to receive(:random_number).with(900_000).and_return(123_456)
|
|
allow(api_client).to receive(:register_phone_number).with('123456789', 223_456)
|
|
allow(api_client).to receive(:subscribe_waba_webhook)
|
|
.with(waba_id, anything, 'test_verify_token').and_return({ 'success' => true })
|
|
allow(channel).to receive(:save!)
|
|
end
|
|
|
|
it 'registers the phone number due to pending provisioning state' do
|
|
with_modified_env FRONTEND_URL: 'https://app.chatwoot.com' do
|
|
expect(api_client).to receive(:register_phone_number).with('123456789', 223_456)
|
|
expect(api_client).to receive(:subscribe_waba_webhook)
|
|
.with(waba_id, 'https://app.chatwoot.com/webhooks/whatsapp/+1234567890', 'test_verify_token')
|
|
service.perform
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when phone number needs registration due to throughput level' do
|
|
before do
|
|
allow(api_client).to receive(:phone_number_verified?).with('123456789').and_return(true)
|
|
allow(health_service).to receive(:fetch_health_status).and_return({
|
|
platform_type: 'APPLICABLE',
|
|
throughput: { level: 'NOT_APPLICABLE' }
|
|
})
|
|
allow(SecureRandom).to receive(:random_number).with(900_000).and_return(123_456)
|
|
allow(api_client).to receive(:register_phone_number).with('123456789', 223_456)
|
|
allow(api_client).to receive(:subscribe_waba_webhook)
|
|
.with(waba_id, anything, 'test_verify_token').and_return({ 'success' => true })
|
|
allow(channel).to receive(:save!)
|
|
end
|
|
|
|
it 'registers the phone number due to throughput not applicable' do
|
|
with_modified_env FRONTEND_URL: 'https://app.chatwoot.com' do
|
|
expect(api_client).to receive(:register_phone_number).with('123456789', 223_456)
|
|
expect(api_client).to receive(:subscribe_waba_webhook)
|
|
.with(waba_id, 'https://app.chatwoot.com/webhooks/whatsapp/+1234567890', 'test_verify_token')
|
|
service.perform
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when phone_number_verified? raises error' do
|
|
before do
|
|
allow(api_client).to receive(:phone_number_verified?).with('123456789').and_raise('API down')
|
|
allow(health_service).to receive(:fetch_health_status).and_return({
|
|
platform_type: 'APPLICABLE',
|
|
throughput: { level: 'APPLICABLE' }
|
|
})
|
|
allow(SecureRandom).to receive(:random_number).with(900_000).and_return(123_456)
|
|
allow(api_client).to receive(:register_phone_number)
|
|
allow(api_client).to receive(:subscribe_waba_webhook).and_return({ 'success' => true })
|
|
allow(channel).to receive(:save!)
|
|
end
|
|
|
|
it 'tries to register phone (due to verification error) and proceeds with webhook setup' do
|
|
with_modified_env FRONTEND_URL: 'https://app.chatwoot.com' do
|
|
expect(api_client).to receive(:register_phone_number)
|
|
expect(api_client).to receive(:subscribe_waba_webhook)
|
|
expect { service.perform }.not_to raise_error
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when health service raises error' do
|
|
before do
|
|
allow(api_client).to receive(:phone_number_verified?).with('123456789').and_return(true)
|
|
allow(health_service).to receive(:fetch_health_status).and_raise('Health API down')
|
|
allow(api_client).to receive(:subscribe_waba_webhook).and_return({ 'success' => true })
|
|
end
|
|
|
|
it 'does not register phone (conservative approach) and proceeds with webhook setup' do
|
|
with_modified_env FRONTEND_URL: 'https://app.chatwoot.com' do
|
|
expect(api_client).not_to receive(:register_phone_number)
|
|
expect(api_client).to receive(:subscribe_waba_webhook)
|
|
expect { service.perform }.not_to raise_error
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when phone registration fails (not blocking)' do
|
|
before do
|
|
allow(api_client).to receive(:phone_number_verified?).with('123456789').and_return(false)
|
|
allow(SecureRandom).to receive(:random_number).with(900_000).and_return(123_456)
|
|
allow(api_client).to receive(:register_phone_number).and_raise('Registration failed')
|
|
allow(api_client).to receive(:subscribe_waba_webhook).and_return({ 'success' => true })
|
|
allow(channel).to receive(:save!)
|
|
end
|
|
|
|
it 'continues with webhook setup even if registration fails' do
|
|
with_modified_env FRONTEND_URL: 'https://app.chatwoot.com' do
|
|
expect(api_client).to receive(:register_phone_number)
|
|
expect(api_client).to receive(:subscribe_waba_webhook)
|
|
expect { service.perform }.not_to raise_error
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when webhook setup fails (should raise)' do
|
|
before do
|
|
allow(api_client).to receive(:phone_number_verified?).with('123456789').and_return(false)
|
|
allow(SecureRandom).to receive(:random_number).with(900_000).and_return(123_456)
|
|
allow(api_client).to receive(:register_phone_number)
|
|
allow(api_client).to receive(:subscribe_waba_webhook).and_raise('Webhook failed')
|
|
end
|
|
|
|
it 'raises an error' do
|
|
with_modified_env FRONTEND_URL: 'https://app.chatwoot.com' do
|
|
expect(api_client).to receive(:register_phone_number)
|
|
expect(api_client).to receive(:subscribe_waba_webhook)
|
|
expect { service.perform }.to raise_error(/Webhook setup failed/)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when required parameters are missing' do
|
|
it 'raises error when channel is nil' do
|
|
service_invalid = described_class.new(nil, waba_id, access_token)
|
|
expect { service_invalid.perform }.to raise_error(ArgumentError, 'Channel is required')
|
|
end
|
|
|
|
it 'raises error when waba_id is blank' do
|
|
service_invalid = described_class.new(channel, '', access_token)
|
|
expect { service_invalid.perform }.to raise_error(ArgumentError, 'WABA ID is required')
|
|
end
|
|
|
|
it 'raises error when access_token is blank' do
|
|
service_invalid = described_class.new(channel, waba_id, '')
|
|
expect { service_invalid.perform }.to raise_error(ArgumentError, 'Access token is required')
|
|
end
|
|
end
|
|
|
|
context 'when PIN already exists' do
|
|
before do
|
|
channel.provider_config['verification_pin'] = 123_456
|
|
allow(api_client).to receive(:phone_number_verified?).with('123456789').and_return(false)
|
|
allow(api_client).to receive(:register_phone_number)
|
|
allow(api_client).to receive(:subscribe_waba_webhook).and_return({ 'success' => true })
|
|
allow(channel).to receive(:save!)
|
|
end
|
|
|
|
it 'reuses existing PIN' do
|
|
with_modified_env FRONTEND_URL: 'https://app.chatwoot.com' do
|
|
expect(api_client).to receive(:register_phone_number).with('123456789', 123_456)
|
|
expect(SecureRandom).not_to receive(:random_number)
|
|
service.perform
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when webhook setup fails and should trigger reauthorization' do
|
|
before do
|
|
allow(api_client).to receive(:phone_number_verified?).with('123456789').and_return(true)
|
|
allow(api_client).to receive(:subscribe_waba_webhook).and_raise('Invalid access token')
|
|
end
|
|
|
|
it 'raises error with webhook setup failure message' do
|
|
with_modified_env FRONTEND_URL: 'https://app.chatwoot.com' do
|
|
expect { service.perform }.to raise_error(/Webhook setup failed: Invalid access token/)
|
|
end
|
|
end
|
|
|
|
it 'logs the webhook setup failure' do
|
|
with_modified_env FRONTEND_URL: 'https://app.chatwoot.com' do
|
|
expect(Rails.logger).to receive(:error).with('[WHATSAPP] Webhook setup failed: Invalid access token')
|
|
expect { service.perform }.to raise_error(/Webhook setup failed/)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when used during reauthorization flow' do
|
|
let(:existing_channel) do
|
|
create(:channel_whatsapp,
|
|
phone_number: '+1234567890',
|
|
provider_config: {
|
|
'phone_number_id' => '123456789',
|
|
'webhook_verify_token' => 'existing_verify_token',
|
|
'business_id' => 'existing_business_id',
|
|
'waba_id' => 'existing_waba_id'
|
|
},
|
|
provider: 'whatsapp_cloud',
|
|
sync_templates: false,
|
|
validate_provider_config: false)
|
|
end
|
|
let(:new_access_token) { 'new_access_token' }
|
|
let(:service_reauth) { described_class.new(existing_channel, waba_id, new_access_token) }
|
|
|
|
before do
|
|
allow(api_client).to receive(:phone_number_verified?).with('123456789').and_return(true)
|
|
allow(health_service).to receive(:fetch_health_status).and_return({
|
|
platform_type: 'APPLICABLE',
|
|
throughput: { level: 'APPLICABLE' }
|
|
})
|
|
allow(api_client).to receive(:subscribe_waba_webhook)
|
|
.with(waba_id, anything, 'existing_verify_token').and_return({ 'success' => true })
|
|
end
|
|
|
|
it 'successfully reauthorizes with new access token' do
|
|
with_modified_env FRONTEND_URL: 'https://app.chatwoot.com' do
|
|
expect(api_client).not_to receive(:register_phone_number)
|
|
expect(api_client).to receive(:subscribe_waba_webhook)
|
|
.with(waba_id, 'https://app.chatwoot.com/webhooks/whatsapp/+1234567890', 'existing_verify_token')
|
|
service_reauth.perform
|
|
end
|
|
end
|
|
|
|
it 'uses the existing webhook verify token during reauthorization' do
|
|
with_modified_env FRONTEND_URL: 'https://app.chatwoot.com' do
|
|
expect(api_client).to receive(:subscribe_waba_webhook)
|
|
.with(waba_id, anything, 'existing_verify_token')
|
|
service_reauth.perform
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'when webhook setup is successful in creation flow' do
|
|
before do
|
|
allow(api_client).to receive(:phone_number_verified?).with('123456789').and_return(true)
|
|
allow(health_service).to receive(:fetch_health_status).and_return({
|
|
platform_type: 'APPLICABLE',
|
|
throughput: { level: 'APPLICABLE' }
|
|
})
|
|
allow(api_client).to receive(:subscribe_waba_webhook)
|
|
.with(waba_id, anything, 'test_verify_token').and_return({ 'success' => true })
|
|
end
|
|
|
|
it 'completes successfully without errors' do
|
|
with_modified_env FRONTEND_URL: 'https://app.chatwoot.com' do
|
|
expect { service.perform }.not_to raise_error
|
|
end
|
|
end
|
|
|
|
it 'does not log any errors' do
|
|
with_modified_env FRONTEND_URL: 'https://app.chatwoot.com' do
|
|
expect(Rails.logger).not_to receive(:error)
|
|
service.perform
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|