mirror of
https://github.com/lingble/chatwoot.git
synced 2025-11-24 06:54:55 +00:00
0e41263f9c
# Pull Request Template ## Description Ensure messages go to correct conversation when receive multi user in 1 LINE webhook. base on [document](https://developers.line.biz/en/reference/messaging-api/#webhook-event-objects:~:text=There%20is%20not%20necessarily%20one%20user%20per%20webhook). it said ``` There is not necessarily one user per webhook. A message event from person A and a follow event from person B may be in the same webhook. ``` this PR has 1 break changes. In old version. when receive [follow](https://developers.line.biz/en/reference/messaging-api/#follow-event) event, it will create conversation with no messages. After this PR. when receive follow event, it will not create conversation, contact and messages ## Type of change Please delete options that are not relevant. - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality not to work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? add test case. and follow event test by delete conversation, and block and unblock line account ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [ ] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules --------- Co-authored-by: mix5003 <mix5003@debian.debian> Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
410 lines
14 KiB
Ruby
410 lines
14 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe Line::IncomingMessageService do
|
|
let!(:line_channel) { create(:channel_line) }
|
|
let(:params) do
|
|
{
|
|
'destination': '2342234234',
|
|
'events': [
|
|
{
|
|
'replyToken': '0f3779fba3b349968c5d07db31eab56f',
|
|
'type': 'message',
|
|
'mode': 'active',
|
|
'timestamp': 1_462_629_479_859,
|
|
'source': {
|
|
'type': 'user',
|
|
'userId': 'U4af4980629'
|
|
},
|
|
'message': {
|
|
'id': '325708',
|
|
'type': 'text',
|
|
'text': 'Hello, world'
|
|
}
|
|
},
|
|
{
|
|
'replyToken': '8cf9239d56244f4197887e939187e19e',
|
|
'type': 'follow',
|
|
'mode': 'active',
|
|
'timestamp': 1_462_629_479_859,
|
|
'source': {
|
|
'type': 'user',
|
|
'userId': 'U4af4980629'
|
|
}
|
|
}
|
|
]
|
|
}.with_indifferent_access
|
|
end
|
|
|
|
let(:follow_params) do
|
|
{
|
|
'destination': '2342234234',
|
|
'events': [
|
|
{
|
|
'replyToken': '8cf9239d56244f4197887e939187e19e',
|
|
'type': 'follow',
|
|
'mode': 'active',
|
|
'timestamp': 1_462_629_479_859,
|
|
'source': {
|
|
'type': 'user',
|
|
'userId': 'U4af4980629'
|
|
}
|
|
}
|
|
]
|
|
}.with_indifferent_access
|
|
end
|
|
|
|
let(:multi_user_params) do
|
|
{
|
|
'destination': '2342234234',
|
|
'events': [
|
|
{
|
|
'replyToken': '0f3779fba3b349968c5d07db31eab56f1',
|
|
'type': 'message',
|
|
'mode': 'active',
|
|
'timestamp': 1_462_629_479_859,
|
|
'source': {
|
|
'type': 'user',
|
|
'userId': 'U4af4980629'
|
|
},
|
|
'message': {
|
|
'id': '3257081',
|
|
'type': 'text',
|
|
'text': 'Hello, world 1'
|
|
}
|
|
},
|
|
{
|
|
'replyToken': '0f3779fba3b349968c5d07db31eab56f2',
|
|
'type': 'message',
|
|
'mode': 'active',
|
|
'timestamp': 1_462_629_479_859,
|
|
'source': {
|
|
'type': 'user',
|
|
'userId': 'U4af49806292'
|
|
},
|
|
'message': {
|
|
'id': '3257082',
|
|
'type': 'text',
|
|
'text': 'Hello, world 2'
|
|
}
|
|
}
|
|
]
|
|
}.with_indifferent_access
|
|
end
|
|
|
|
let(:image_params) do
|
|
{
|
|
'destination': '2342234234',
|
|
'events': [
|
|
{
|
|
'replyToken': '0f3779fba3b349968c5d07db31eab56f',
|
|
'type': 'message',
|
|
'mode': 'active',
|
|
'timestamp': 1_462_629_479_859,
|
|
'source': {
|
|
'type': 'user',
|
|
'userId': 'U4af4980629'
|
|
},
|
|
'message': {
|
|
'type': 'image',
|
|
'id': '354718',
|
|
'contentProvider': {
|
|
'type': 'line'
|
|
}
|
|
}
|
|
},
|
|
{
|
|
'replyToken': '8cf9239d56244f4197887e939187e19e',
|
|
'type': 'follow',
|
|
'mode': 'active',
|
|
'timestamp': 1_462_629_479_859,
|
|
'source': {
|
|
'type': 'user',
|
|
'userId': 'U4af4980629'
|
|
}
|
|
}
|
|
]
|
|
}.with_indifferent_access
|
|
end
|
|
|
|
let(:video_params) do
|
|
{
|
|
'destination': '2342234234',
|
|
'events': [
|
|
{
|
|
'replyToken': '0f3779fba3b349968c5d07db31eab56f',
|
|
'type': 'message',
|
|
'mode': 'active',
|
|
'timestamp': 1_462_629_479_859,
|
|
'source': {
|
|
'type': 'user',
|
|
'userId': 'U4af4980629'
|
|
},
|
|
'message': {
|
|
'type': 'video',
|
|
'id': '354718',
|
|
'contentProvider': {
|
|
'type': 'line'
|
|
}
|
|
}
|
|
},
|
|
{
|
|
'replyToken': '8cf9239d56244f4197887e939187e19e',
|
|
'type': 'follow',
|
|
'mode': 'active',
|
|
'timestamp': 1_462_629_479_859,
|
|
'source': {
|
|
'type': 'user',
|
|
'userId': 'U4af4980629'
|
|
}
|
|
}
|
|
]
|
|
}.with_indifferent_access
|
|
end
|
|
|
|
let(:file_params) do
|
|
{
|
|
'destination': '2342234234',
|
|
'events': [
|
|
{
|
|
'replyToken': '0f3779fba3b349968c5d07db31eab56f',
|
|
'type': 'message',
|
|
'mode': 'active',
|
|
'timestamp': 1_462_629_479_859,
|
|
'source': {
|
|
'type': 'user',
|
|
'userId': 'U4af4980629'
|
|
},
|
|
'message': {
|
|
'type': 'file',
|
|
'id': '354718',
|
|
'fileName': 'contacts.csv',
|
|
'fileSize': 2978
|
|
}
|
|
},
|
|
{
|
|
'replyToken': '8cf9239d56244f4197887e939187e19e',
|
|
'type': 'follow',
|
|
'mode': 'active',
|
|
'timestamp': 1_462_629_479_859,
|
|
'source': {
|
|
'type': 'user',
|
|
'userId': 'U4af4980629'
|
|
}
|
|
}
|
|
]
|
|
}.with_indifferent_access
|
|
end
|
|
|
|
let(:sticker_params) do
|
|
{
|
|
'destination': '2342234234',
|
|
'events': [
|
|
{
|
|
'replyToken': '0f3779fba3b349968c5d07db31eab56f',
|
|
'type': 'message',
|
|
'mode': 'active',
|
|
'timestamp': 1_462_629_479_859,
|
|
'source': {
|
|
'type': 'user',
|
|
'userId': 'U4af4980629'
|
|
},
|
|
'message': {
|
|
'type': 'sticker',
|
|
'id': '1501597916',
|
|
'quoteToken': 'q3Plxr4AgKd...',
|
|
'stickerId': '52002738',
|
|
'packageId': '11537'
|
|
}
|
|
},
|
|
{
|
|
'replyToken': '8cf9239d56244f4197887e939187e19e',
|
|
'type': 'follow',
|
|
'mode': 'active',
|
|
'timestamp': 1_462_629_479_859,
|
|
'source': {
|
|
'type': 'user',
|
|
'userId': 'U4af4980629'
|
|
}
|
|
}
|
|
]
|
|
}.with_indifferent_access
|
|
end
|
|
|
|
describe '#perform' do
|
|
context 'when non-text message params' do
|
|
it 'does not create conversations, messages and contacts' do
|
|
line_bot = double
|
|
line_user_profile = double
|
|
allow(Line::Bot::Client).to receive(:new).and_return(line_bot)
|
|
allow(line_bot).to receive(:get_profile).and_return(line_user_profile)
|
|
allow(line_user_profile).to receive(:body).and_return(
|
|
{
|
|
'displayName': 'LINE Test',
|
|
'userId': 'U4af4980629',
|
|
'pictureUrl': 'https://test.com'
|
|
}.to_json
|
|
)
|
|
described_class.new(inbox: line_channel.inbox, params: follow_params).perform
|
|
expect(line_channel.inbox.conversations.size).to eq(0)
|
|
expect(Contact.all.size).to eq(0)
|
|
expect(line_channel.inbox.messages.size).to eq(0)
|
|
end
|
|
end
|
|
|
|
context 'when valid text message params' do
|
|
let(:line_bot) { double }
|
|
let(:line_user_profile) { double }
|
|
|
|
before do
|
|
allow(Line::Bot::Client).to receive(:new).and_return(line_bot)
|
|
allow(line_bot).to receive(:get_profile).with('U4af4980629').and_return(line_user_profile)
|
|
allow(line_user_profile).to receive(:body).and_return(
|
|
{
|
|
'displayName': 'LINE Test',
|
|
'userId': 'U4af4980629',
|
|
'pictureUrl': 'https://test.com'
|
|
}.to_json
|
|
)
|
|
end
|
|
|
|
it 'creates appropriate conversations, message and contacts' do
|
|
described_class.new(inbox: line_channel.inbox, params: params).perform
|
|
expect(line_channel.inbox.conversations).not_to eq(0)
|
|
expect(Contact.all.first.name).to eq('LINE Test')
|
|
expect(Contact.all.first.additional_attributes['social_line_user_id']).to eq('U4af4980629')
|
|
expect(line_channel.inbox.messages.first.content).to eq('Hello, world')
|
|
end
|
|
|
|
it 'creates appropriate conversations, message and contacts for multi user' do
|
|
line_user_profile2 = double
|
|
allow(line_bot).to receive(:get_profile).with('U4af49806292').and_return(line_user_profile2)
|
|
allow(line_user_profile2).to receive(:body).and_return(
|
|
{
|
|
'displayName': 'LINE Test 2',
|
|
'userId': 'U4af49806292',
|
|
'pictureUrl': 'https://test.com'
|
|
}.to_json
|
|
)
|
|
described_class.new(inbox: line_channel.inbox, params: multi_user_params).perform
|
|
expect(line_channel.inbox.conversations.size).to eq(2)
|
|
expect(Contact.all.first.name).to eq('LINE Test')
|
|
expect(Contact.all.first.additional_attributes['social_line_user_id']).to eq('U4af4980629')
|
|
expect(Contact.all.last.name).to eq('LINE Test 2')
|
|
expect(Contact.all.last.additional_attributes['social_line_user_id']).to eq('U4af49806292')
|
|
expect(line_channel.inbox.messages.first.content).to eq('Hello, world 1')
|
|
expect(line_channel.inbox.messages.last.content).to eq('Hello, world 2')
|
|
end
|
|
end
|
|
|
|
context 'when valid sticker message params' do
|
|
it 'creates appropriate conversations, message and contacts' do
|
|
line_bot = double
|
|
line_user_profile = double
|
|
allow(Line::Bot::Client).to receive(:new).and_return(line_bot)
|
|
allow(line_bot).to receive(:get_profile).and_return(line_user_profile)
|
|
allow(line_user_profile).to receive(:body).and_return(
|
|
{
|
|
'displayName': 'LINE Test',
|
|
'userId': 'U4af4980629',
|
|
'pictureUrl': 'https://test.com'
|
|
}.to_json
|
|
)
|
|
described_class.new(inbox: line_channel.inbox, params: sticker_params).perform
|
|
expect(line_channel.inbox.conversations).not_to eq(0)
|
|
expect(Contact.all.first.name).to eq('LINE Test')
|
|
expect(line_channel.inbox.messages.first.content).to eq('')
|
|
end
|
|
end
|
|
|
|
context 'when valid image message params' do
|
|
it 'creates appropriate conversations, message and contacts' do
|
|
line_bot = double
|
|
line_user_profile = double
|
|
allow(Line::Bot::Client).to receive(:new).and_return(line_bot)
|
|
allow(line_bot).to receive(:get_profile).and_return(line_user_profile)
|
|
file = fixture_file_upload(Rails.root.join('spec/assets/avatar.png'), 'image/png')
|
|
allow(line_bot).to receive(:get_message_content).and_return(
|
|
OpenStruct.new({
|
|
body: Base64.encode64(file.read),
|
|
content_type: 'image/png'
|
|
})
|
|
)
|
|
allow(line_user_profile).to receive(:body).and_return(
|
|
{
|
|
'displayName': 'LINE Test',
|
|
'userId': 'U4af4980629',
|
|
'pictureUrl': 'https://test.com'
|
|
}.to_json
|
|
)
|
|
described_class.new(inbox: line_channel.inbox, params: image_params).perform
|
|
expect(line_channel.inbox.conversations).not_to eq(0)
|
|
expect(Contact.all.first.name).to eq('LINE Test')
|
|
expect(Contact.all.first.additional_attributes['social_line_user_id']).to eq('U4af4980629')
|
|
expect(line_channel.inbox.messages.first.content).to be_nil
|
|
expect(line_channel.inbox.messages.first.attachments.first.file_type).to eq('image')
|
|
expect(line_channel.inbox.messages.first.attachments.first.file.blob.filename.to_s).to eq('media-354718.png')
|
|
end
|
|
end
|
|
|
|
context 'when valid video message params' do
|
|
it 'creates appropriate conversations, message and contacts' do
|
|
line_bot = double
|
|
line_user_profile = double
|
|
allow(Line::Bot::Client).to receive(:new).and_return(line_bot)
|
|
allow(line_bot).to receive(:get_profile).and_return(line_user_profile)
|
|
file = fixture_file_upload(Rails.root.join('spec/assets/sample.mp4'), 'video/mp4')
|
|
allow(line_bot).to receive(:get_message_content).and_return(
|
|
OpenStruct.new({
|
|
body: Base64.encode64(file.read),
|
|
content_type: 'video/mp4'
|
|
})
|
|
)
|
|
allow(line_user_profile).to receive(:body).and_return(
|
|
{
|
|
'displayName': 'LINE Test',
|
|
'userId': 'U4af4980629',
|
|
'pictureUrl': 'https://test.com'
|
|
}.to_json
|
|
)
|
|
described_class.new(inbox: line_channel.inbox, params: video_params).perform
|
|
expect(line_channel.inbox.conversations).not_to eq(0)
|
|
expect(Contact.all.first.name).to eq('LINE Test')
|
|
expect(Contact.all.first.additional_attributes['social_line_user_id']).to eq('U4af4980629')
|
|
expect(line_channel.inbox.messages.first.content).to be_nil
|
|
expect(line_channel.inbox.messages.first.attachments.first.file_type).to eq('video')
|
|
expect(line_channel.inbox.messages.first.attachments.first.file.blob.filename.to_s).to eq('media-354718.mp4')
|
|
end
|
|
end
|
|
|
|
context 'when valid file message params' do
|
|
it 'creates appropriate conversations, message and contacts' do
|
|
line_bot = double
|
|
line_user_profile = double
|
|
allow(Line::Bot::Client).to receive(:new).and_return(line_bot)
|
|
allow(line_bot).to receive(:get_profile).and_return(line_user_profile)
|
|
file = fixture_file_upload(Rails.root.join('spec/assets/contacts.csv'), 'text/csv')
|
|
allow(line_bot).to receive(:get_message_content).and_return(
|
|
OpenStruct.new({
|
|
body: Base64.encode64(file.read),
|
|
content_type: 'text/csv'
|
|
})
|
|
)
|
|
allow(line_user_profile).to receive(:body).and_return(
|
|
{
|
|
'displayName': 'LINE Test',
|
|
'userId': 'U4af4980629',
|
|
'pictureUrl': 'https://test.com'
|
|
}.to_json
|
|
)
|
|
described_class.new(inbox: line_channel.inbox, params: file_params).perform
|
|
expect(line_channel.inbox.conversations).not_to eq(0)
|
|
expect(Contact.all.first.name).to eq('LINE Test')
|
|
expect(Contact.all.first.additional_attributes['social_line_user_id']).to eq('U4af4980629')
|
|
expect(line_channel.inbox.messages.first.content).to be_nil
|
|
expect(line_channel.inbox.messages.first.attachments.first.file_type).to eq('file')
|
|
expect(line_channel.inbox.messages.first.attachments.first.file.blob.filename.to_s).to eq('contacts.csv')
|
|
end
|
|
end
|
|
end
|
|
end
|