mirror of
https://github.com/lingble/chatwoot.git
synced 2025-10-31 11:08:04 +00:00
341487b93e
## Linear reference: https://linear.app/chatwoot/issue/CW-4649/re-imagine-assignments ## Description This PR introduces the foundation for Assignment V2 system by implementing assignment policies and their association with inboxes. Assignment policies allow configuring how conversations are distributed among agents, with support for different assignment orders (round_robin in community, balanced in enterprise) and conversation prioritization strategies Fixes # (issue) ## Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality not to work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? Test Coverage: - Controller specs for assignment policies CRUD operations - Enterprise-specific specs for balanced assignment order - Model specs for community/enterprise separation Manual Testing: 1. Create assignment policy: POST /api/v1/accounts/{id}/assignment_policies 2. List policies: GET /api/v1/accounts/{id}/assignment_policies 3. Assign policy to inbox: POST /api/v1/accounts/{id}/assignment_policies/{id}/inboxes 4. View inbox policy: GET /api/v1/accounts/{id}/inboxes/{id}/assignment_policy 5. Verify community edition ignores "balanced" assignment order 6. Verify enterprise edition supports both "round_robin" and "balanced" - testing the flows after enterprise folder deletion ## Checklist: - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my code - [ ] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules --------- Co-authored-by: Pranav <pranavrajs@gmail.com> Co-authored-by: Pranav <pranav@chatwoot.com>
57 lines
2.1 KiB
Ruby
57 lines
2.1 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe AssignmentPolicy do
|
|
describe 'associations' do
|
|
it { is_expected.to belong_to(:account) }
|
|
it { is_expected.to have_many(:inbox_assignment_policies).dependent(:destroy) }
|
|
it { is_expected.to have_many(:inboxes).through(:inbox_assignment_policies) }
|
|
end
|
|
|
|
describe 'validations' do
|
|
subject { build(:assignment_policy) }
|
|
|
|
it { is_expected.to validate_presence_of(:name) }
|
|
it { is_expected.to validate_uniqueness_of(:name).scoped_to(:account_id) }
|
|
end
|
|
|
|
describe 'fair distribution validations' do
|
|
it 'requires fair_distribution_limit to be greater than 0' do
|
|
policy = build(:assignment_policy, fair_distribution_limit: 0)
|
|
expect(policy).not_to be_valid
|
|
expect(policy.errors[:fair_distribution_limit]).to include('must be greater than 0')
|
|
end
|
|
|
|
it 'requires fair_distribution_window to be greater than 0' do
|
|
policy = build(:assignment_policy, fair_distribution_window: -1)
|
|
expect(policy).not_to be_valid
|
|
expect(policy.errors[:fair_distribution_window]).to include('must be greater than 0')
|
|
end
|
|
end
|
|
|
|
describe 'enum values' do
|
|
let(:assignment_policy) { create(:assignment_policy) }
|
|
|
|
describe 'conversation_priority' do
|
|
it 'can be set to earliest_created' do
|
|
assignment_policy.update!(conversation_priority: :earliest_created)
|
|
expect(assignment_policy.conversation_priority).to eq('earliest_created')
|
|
expect(assignment_policy.earliest_created?).to be true
|
|
end
|
|
|
|
it 'can be set to longest_waiting' do
|
|
assignment_policy.update!(conversation_priority: :longest_waiting)
|
|
expect(assignment_policy.conversation_priority).to eq('longest_waiting')
|
|
expect(assignment_policy.longest_waiting?).to be true
|
|
end
|
|
end
|
|
|
|
describe 'assignment_order' do
|
|
it 'can be set to round_robin' do
|
|
assignment_policy.update!(assignment_order: :round_robin)
|
|
expect(assignment_policy.assignment_order).to eq('round_robin')
|
|
expect(assignment_policy.round_robin?).to be true
|
|
end
|
|
end
|
|
end
|
|
end
|