mirror of
https://github.com/lingble/chatwoot.git
synced 2025-11-05 21:48:03 +00:00
# Pull Request Template ## Description This PR disables audio alerts for conversations with a status of "pending." It applies to all notification event types, ensuring that audio will not play for conversations marked as "pending." Fixes https://linear.app/chatwoot/issue/CW-3951/audio-alerts-shouldnt-be-triggered-in-conversation-is-in-pending-state ## Type of change - [x] Breaking change (fix or feature that would cause existing functionality not to work as expected) ## How Has This Been Tested? Steps: 1. Create a conversation. 2. Then mark the conversation as pending. 3. Send message. 4. Make sure audio notification are enabled. ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
192 lines
5.9 KiB
JavaScript
192 lines
5.9 KiB
JavaScript
import AudioNotificationStore from '../AudioNotificationStore';
|
|
import {
|
|
ROLES,
|
|
CONVERSATION_PERMISSIONS,
|
|
} from 'dashboard/constants/permissions';
|
|
import { getUserPermissions } from 'dashboard/helper/permissionsHelper';
|
|
import wootConstants from 'dashboard/constants/globals';
|
|
|
|
vi.mock('dashboard/helper/permissionsHelper', () => ({
|
|
getUserPermissions: vi.fn(),
|
|
}));
|
|
|
|
describe('AudioNotificationStore', () => {
|
|
let store;
|
|
let audioNotificationStore;
|
|
|
|
beforeEach(() => {
|
|
store = {
|
|
getters: {
|
|
getMineChats: vi.fn(),
|
|
getSelectedChat: null,
|
|
getCurrentAccountId: 1,
|
|
getConversationById: vi.fn(),
|
|
},
|
|
};
|
|
audioNotificationStore = new AudioNotificationStore(store);
|
|
});
|
|
|
|
describe('hasUnreadConversation', () => {
|
|
it('should return true when there are unread conversations', () => {
|
|
store.getters.getMineChats.mockReturnValue([
|
|
{ id: 1, unread_count: 2 },
|
|
{ id: 2, unread_count: 0 },
|
|
]);
|
|
|
|
expect(audioNotificationStore.hasUnreadConversation()).toBe(true);
|
|
});
|
|
|
|
it('should return false when there are no unread conversations', () => {
|
|
store.getters.getMineChats.mockReturnValue([
|
|
{ id: 1, unread_count: 0 },
|
|
{ id: 2, unread_count: 0 },
|
|
]);
|
|
|
|
expect(audioNotificationStore.hasUnreadConversation()).toBe(false);
|
|
});
|
|
|
|
it('should return false when there are no conversations', () => {
|
|
store.getters.getMineChats.mockReturnValue([]);
|
|
|
|
expect(audioNotificationStore.hasUnreadConversation()).toBe(false);
|
|
});
|
|
|
|
it('should call getMineChats with correct parameters', () => {
|
|
store.getters.getMineChats.mockReturnValue([]);
|
|
audioNotificationStore.hasUnreadConversation();
|
|
|
|
expect(store.getters.getMineChats).toHaveBeenCalledWith({
|
|
assigneeType: 'me',
|
|
status: 'open',
|
|
});
|
|
});
|
|
});
|
|
|
|
describe('isMessageFromPendingConversation', () => {
|
|
it('should return true when conversation status is pending', () => {
|
|
store.getters.getConversationById.mockReturnValue({
|
|
id: 123,
|
|
status: wootConstants.STATUS_TYPE.PENDING,
|
|
});
|
|
const message = { conversation_id: 123 };
|
|
|
|
expect(
|
|
audioNotificationStore.isMessageFromPendingConversation(message)
|
|
).toBe(true);
|
|
expect(store.getters.getConversationById).toHaveBeenCalledWith(123);
|
|
});
|
|
|
|
it('should return false when conversation status is not pending', () => {
|
|
store.getters.getConversationById.mockReturnValue({
|
|
id: 123,
|
|
status: wootConstants.STATUS_TYPE.OPEN,
|
|
});
|
|
const message = { conversation_id: 123 };
|
|
|
|
expect(
|
|
audioNotificationStore.isMessageFromPendingConversation(message)
|
|
).toBe(false);
|
|
expect(store.getters.getConversationById).toHaveBeenCalledWith(123);
|
|
});
|
|
|
|
it('should return false when conversation is not found', () => {
|
|
store.getters.getConversationById.mockReturnValue(null);
|
|
const message = { conversation_id: 123 };
|
|
|
|
expect(
|
|
audioNotificationStore.isMessageFromPendingConversation(message)
|
|
).toBe(false);
|
|
expect(store.getters.getConversationById).toHaveBeenCalledWith(123);
|
|
});
|
|
|
|
it('should return false when message has no conversation_id', () => {
|
|
const message = {};
|
|
|
|
expect(
|
|
audioNotificationStore.isMessageFromPendingConversation(message)
|
|
).toBe(false);
|
|
expect(store.getters.getConversationById).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it('should return false when message is null or undefined', () => {
|
|
expect(
|
|
audioNotificationStore.isMessageFromPendingConversation(null)
|
|
).toBe(false);
|
|
expect(
|
|
audioNotificationStore.isMessageFromPendingConversation(undefined)
|
|
).toBe(false);
|
|
expect(store.getters.getConversationById).not.toHaveBeenCalled();
|
|
});
|
|
});
|
|
|
|
describe('isMessageFromCurrentConversation', () => {
|
|
it('should return true when message is from selected chat', () => {
|
|
store.getters.getSelectedChat = { id: 6179 };
|
|
const message = { conversation_id: 6179 };
|
|
|
|
expect(
|
|
audioNotificationStore.isMessageFromCurrentConversation(message)
|
|
).toBe(true);
|
|
});
|
|
|
|
it('should return false when message is from different chat', () => {
|
|
store.getters.getSelectedChat = { id: 6179 };
|
|
const message = { conversation_id: 1337 };
|
|
|
|
expect(
|
|
audioNotificationStore.isMessageFromCurrentConversation(message)
|
|
).toBe(false);
|
|
});
|
|
|
|
it('should return false when no chat is selected', () => {
|
|
store.getters.getSelectedChat = null;
|
|
const message = { conversation_id: 6179 };
|
|
|
|
expect(
|
|
audioNotificationStore.isMessageFromCurrentConversation(message)
|
|
).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe('hasConversationPermission', () => {
|
|
const mockUser = { id: 'user123' };
|
|
|
|
beforeEach(() => {
|
|
getUserPermissions.mockReset();
|
|
});
|
|
|
|
it('should return true when user has a required role', () => {
|
|
getUserPermissions.mockReturnValue([ROLES[0]]);
|
|
|
|
expect(audioNotificationStore.hasConversationPermission(mockUser)).toBe(
|
|
true
|
|
);
|
|
expect(getUserPermissions).toHaveBeenCalledWith(mockUser, 1);
|
|
});
|
|
|
|
it('should return true when user has a conversation permission', () => {
|
|
getUserPermissions.mockReturnValue([CONVERSATION_PERMISSIONS[0]]);
|
|
|
|
expect(audioNotificationStore.hasConversationPermission(mockUser)).toBe(
|
|
true
|
|
);
|
|
});
|
|
|
|
it('should return false when user has no required permissions', () => {
|
|
getUserPermissions.mockReturnValue(['some-other-permission']);
|
|
|
|
expect(audioNotificationStore.hasConversationPermission(mockUser)).toBe(
|
|
false
|
|
);
|
|
});
|
|
|
|
it('should return false when user has no permissions', () => {
|
|
getUserPermissions.mockReturnValue([]);
|
|
|
|
expect(audioNotificationStore.hasConversationPermission(mockUser)).toBe(
|
|
false
|
|
);
|
|
});
|
|
});
|
|
});
|