mirror of
https://github.com/lingble/chatwoot.git
synced 2025-10-29 18:22:53 +00:00
## Linear: - https://github.com/chatwoot/chatwoot/issues/486 ## Description This PR implements Multi-Factor Authentication (MFA) support for user accounts, enhancing security by requiring a second form of verification during login. The feature adds TOTP (Time-based One-Time Password) authentication with QR code generation and backup codes for account recovery. ## Type of change - [ ] New feature (non-breaking change which adds functionality) ## How Has This Been Tested? - Added comprehensive RSpec tests for MFA controller functionality - Tested MFA setup flow with QR code generation - Verified OTP validation and backup code generation - Tested login flow with MFA enabled/disabled ## Checklist: - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my code - [ ] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules --------- Co-authored-by: Pranav <pranav@chatwoot.com> Co-authored-by: Sojan Jose <sojan@pepalo.com> Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com>
147 lines
4.3 KiB
Ruby
147 lines
4.3 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe DeviseOverrides::SessionsController, type: :controller do
|
|
include Devise::Test::ControllerHelpers
|
|
|
|
before do
|
|
request.env['devise.mapping'] = Devise.mappings[:user]
|
|
end
|
|
|
|
describe 'POST #create' do
|
|
let(:user) { create(:user, password: 'Test@123456') }
|
|
|
|
context 'with standard authentication' do
|
|
it 'authenticates with valid credentials' do
|
|
post :create, params: { email: user.email, password: 'Test@123456' }
|
|
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
|
|
it 'rejects invalid credentials' do
|
|
post :create, params: { email: user.email, password: 'wrong' }
|
|
|
|
expect(response).to have_http_status(:unauthorized)
|
|
end
|
|
end
|
|
|
|
context 'with MFA authentication' do
|
|
before do
|
|
skip('Skipping since MFA is not configured in this environment') unless Chatwoot.encryption_configured?
|
|
user.enable_two_factor!
|
|
user.update!(otp_required_for_login: true)
|
|
end
|
|
|
|
it 'requires MFA verification after successful password authentication' do
|
|
post :create, params: { email: user.email, password: 'Test@123456' }
|
|
|
|
expect(response).to have_http_status(:partial_content)
|
|
json_response = response.parsed_body
|
|
expect(json_response['mfa_required']).to be(true)
|
|
expect(json_response['mfa_token']).to be_present
|
|
end
|
|
|
|
context 'when verifying MFA' do
|
|
let(:mfa_token) { Mfa::TokenService.new(user: user).generate_token }
|
|
|
|
it 'authenticates with valid OTP' do
|
|
post :create, params: {
|
|
mfa_token: mfa_token,
|
|
otp_code: user.current_otp
|
|
}
|
|
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
|
|
it 'authenticates with valid backup code' do
|
|
backup_codes = user.generate_backup_codes!
|
|
|
|
post :create, params: {
|
|
mfa_token: mfa_token,
|
|
backup_code: backup_codes.first
|
|
}
|
|
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
|
|
it 'rejects invalid OTP' do
|
|
post :create, params: {
|
|
mfa_token: mfa_token,
|
|
otp_code: '000000'
|
|
}
|
|
|
|
expect(response).to have_http_status(:bad_request)
|
|
expect(response.parsed_body['error']).to eq(I18n.t('errors.mfa.invalid_code'))
|
|
end
|
|
|
|
it 'rejects invalid backup code' do
|
|
user.generate_backup_codes!
|
|
|
|
post :create, params: {
|
|
mfa_token: mfa_token,
|
|
backup_code: 'invalid'
|
|
}
|
|
|
|
expect(response).to have_http_status(:bad_request)
|
|
expect(response.parsed_body['error']).to eq(I18n.t('errors.mfa.invalid_code'))
|
|
end
|
|
|
|
it 'rejects expired MFA token' do
|
|
expired_token = JWT.encode(
|
|
{ user_id: user.id, exp: 1.minute.ago.to_i },
|
|
Rails.application.secret_key_base,
|
|
'HS256'
|
|
)
|
|
|
|
post :create, params: {
|
|
mfa_token: expired_token,
|
|
otp_code: user.current_otp
|
|
}
|
|
|
|
expect(response).to have_http_status(:unauthorized)
|
|
expect(response.parsed_body['error']).to eq(I18n.t('errors.mfa.invalid_token'))
|
|
end
|
|
|
|
it 'requires either OTP or backup code' do
|
|
post :create, params: { mfa_token: mfa_token }
|
|
|
|
expect(response).to have_http_status(:bad_request)
|
|
expect(response.parsed_body['error']).to eq(I18n.t('errors.mfa.invalid_code'))
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'with SSO authentication' do
|
|
it 'authenticates with valid SSO token' do
|
|
sso_token = user.generate_sso_auth_token
|
|
|
|
post :create, params: {
|
|
email: user.email,
|
|
sso_auth_token: sso_token
|
|
}
|
|
|
|
expect(response).to have_http_status(:success)
|
|
end
|
|
|
|
it 'rejects invalid SSO token' do
|
|
post :create, params: {
|
|
email: user.email,
|
|
sso_auth_token: 'invalid'
|
|
}
|
|
|
|
expect(response).to have_http_status(:unauthorized)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'GET #new' do
|
|
it 'redirects to frontend login page' do
|
|
allow(ENV).to receive(:fetch).and_call_original
|
|
allow(ENV).to receive(:fetch).with('FRONTEND_URL', nil).and_return('/frontend')
|
|
|
|
get :new
|
|
|
|
expect(response).to redirect_to('/frontend/app/login?error=access-denied')
|
|
end
|
|
end
|
|
end
|