mirror of
https://github.com/lingble/chatwoot.git
synced 2025-11-04 04:57:51 +00:00
b4b308336f
# Pull Request Template ## Description This PR adds new eslint rules to the code base. **Error rules** | Rule name | Type | Files updated | | ----------------- | --- | - | | `vue/block-order` | error | ✅ | | `vue/component-name-in-template-casing` | error | ✅ | | `vue/component-options-name-casing` | error | ✅ | | `vue/custom-event-name-casing` | error | ✅ | | `vue/define-emits-declaration` | error | ✅ | | `vue/no-unused-properties` | error | ✅ | | `vue/define-macros-order` | error | ✅ | | `vue/define-props-declaration` | error | ✅ | | `vue/match-component-import-name` | error | ✅ | | `vue/next-tick-style` | error | ✅ | | `vue/no-bare-strings-in-template` | error | ✅ | | `vue/no-empty-component-block` | error | ✅ | | `vue/no-multiple-objects-in-class` | error | ✅ | | `vue/no-required-prop-with-default` | error | ✅ | | `vue/no-static-inline-styles` | error | ✅ | | `vue/no-template-target-blank` | error | ✅ | | `vue/no-this-in-before-route-enter` | error | ✅ | | `vue/no-undef-components` | error | ✅ | | `vue/no-unused-emit-declarations` | error | ✅ | | `vue/no-unused-refs` | error | ✅ | | `vue/no-use-v-else-with-v-for` | error | ✅ | | `vue/no-useless-v-bind` | error | ✅ | | `vue/no-v-text` | error | ✅ | | `vue/padding-line-between-blocks` | error | ✅ | | ~`vue/prefer-prop-type-boolean-first`~ | ~error~ | ❌ (removed this rule, cause a bug in displaying custom attributes) | | `vue/prefer-separate-static-class` | error | ✅ | | `vue/prefer-true-attribute-shorthand` | error | ✅ | | `vue/require-explicit-slots` | error | ✅ | | `vue/require-macro-variable-name` | error | ✅ | **Warn rules** | Rule name | Type | Files updated | | ---- | ------------- | ------------- | | `vue/no-root-v-if` | warn | ❎ | Fixes https://linear.app/chatwoot/issue/CW-3492/vue-eslint-rules ## Type of change - [x] New feature (non-breaking change which adds functionality) ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules --------- Co-authored-by: Fayaz Ahmed <fayazara@gmail.com> Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com> Co-authored-by: Shivam Mishra <scm.mymail@gmail.com> Co-authored-by: Pranav <pranav@chatwoot.com>
77 lines
1.3 KiB
Vue
77 lines
1.3 KiB
Vue
<script>
|
|
export default {
|
|
props: {
|
|
icon: {
|
|
type: String,
|
|
required: true,
|
|
},
|
|
icons: {
|
|
type: Object,
|
|
required: true,
|
|
},
|
|
size: {
|
|
type: [String, Number],
|
|
default: '20',
|
|
},
|
|
type: {
|
|
type: String,
|
|
default: 'outline',
|
|
},
|
|
viewBox: {
|
|
type: String,
|
|
default: '0 0 24 24',
|
|
},
|
|
iconLib: {
|
|
type: String,
|
|
default: 'fluent',
|
|
},
|
|
},
|
|
|
|
computed: {
|
|
pathSource() {
|
|
// To support icons with multiple paths
|
|
const path = this.icons[`${this.icon}-${this.type}`];
|
|
if (path.constructor === Array) {
|
|
return path;
|
|
}
|
|
return [path];
|
|
},
|
|
},
|
|
};
|
|
</script>
|
|
|
|
<template>
|
|
<svg
|
|
v-if="iconLib === 'fluent'"
|
|
:width="size"
|
|
:height="size"
|
|
fill="none"
|
|
:viewBox="viewBox"
|
|
xmlns="http://www.w3.org/2000/svg"
|
|
>
|
|
<path
|
|
v-for="source in pathSource"
|
|
:key="source"
|
|
:d="source"
|
|
fill="currentColor"
|
|
/>
|
|
</svg>
|
|
<svg
|
|
v-else
|
|
:width="size"
|
|
:height="size"
|
|
fill="none"
|
|
:viewBox="viewBox"
|
|
xmlns="http://www.w3.org/2000/svg"
|
|
>
|
|
<g v-for="(pathData, index) in pathSource" :key="index">
|
|
<path
|
|
:key="pathData"
|
|
:d="pathData"
|
|
stroke="currentColor"
|
|
stroke-width="1.66667"
|
|
/>
|
|
</g>
|
|
</svg>
|
|
</template>
|