mirror of
https://github.com/lingble/chatwoot.git
synced 2025-10-29 18:22:53 +00:00
## Description This PR introduces WhatsApp Embedded Signup functionality, enabling users to connect their WhatsApp Business accounts through Meta's streamlined OAuth flow without manual webhook configuration. This significantly improves the user experience by automating the entire setup process. **Key Features:** - Embedded signup flow using Facebook SDK and Meta's OAuth 2.0 - Automatic webhook registration and phone number configuration - Enhanced provider selection UI with card-based design - Real-time progress tracking during signup process - Comprehensive error handling and user feedback ## Required Configuration The following environment variables must be configured by administrators before this feature can be used: Super Admin Configuration (via super_admin/app_config?config=whatsapp_embedded) - `WHATSAPP_APP_ID`: The Facebook App ID for WhatsApp Business API integration - `WHATSAPP_CONFIGURATION_ID`: The Configuration ID for WhatsApp Embedded Signup flow (obtained from Meta Developer Portal) - `WHATSAPP_APP_SECRET`: The App Secret for WhatsApp Embedded Signup flow (required for token exchange)  ## How Has This Been Tested? #### Backend Tests (RSpec): - Authentication validation for embedded signup endpoints - Authorization code validation and error handling - Missing business parameter validation - Proper response format for configuration endpoint - Unauthorized access prevention #### Manual Test Cases: - Complete embedded signup flow (happy path) - Provider selection UI navigation - Facebook authentication popup handling - Error scenarios (cancelled auth, invalid business data, API failures) - Configuration presence/absence behavior ## Related Screenshots:      Fixes https://linear.app/chatwoot/issue/CW-2131/spec-for-whatsapp-cloud-channels-sign-in-with-facebook --------- Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: iamsivin <iamsivin@gmail.com> Co-authored-by: Sivin Varghese <64252451+iamsivin@users.noreply.github.com> Co-authored-by: Sojan Jose <sojan@pepalo.com>
175 lines
5.1 KiB
Ruby
175 lines
5.1 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe Linear::ActivityMessageService, type: :service do
|
|
let(:account) { create(:account) }
|
|
let(:inbox) { create(:inbox, account: account) }
|
|
let(:conversation) { create(:conversation, account: account, inbox: inbox) }
|
|
let(:user) { create(:user, account: account) }
|
|
|
|
describe '#perform' do
|
|
context 'when action_type is issue_created' do
|
|
let(:service) do
|
|
described_class.new(
|
|
conversation: conversation,
|
|
action_type: :issue_created,
|
|
issue_data: { id: 'ENG-123' },
|
|
user: user
|
|
)
|
|
end
|
|
|
|
it 'enqueues an activity message job' do
|
|
expect do
|
|
service.perform
|
|
end.to have_enqueued_job(Conversations::ActivityMessageJob)
|
|
.with(conversation, {
|
|
account_id: conversation.account_id,
|
|
inbox_id: conversation.inbox_id,
|
|
message_type: :activity,
|
|
content: "Linear issue ENG-123 was created by #{user.name}"
|
|
})
|
|
end
|
|
|
|
it 'does not enqueue job when issue data lacks id' do
|
|
service = described_class.new(
|
|
conversation: conversation,
|
|
action_type: :issue_created,
|
|
issue_data: { title: 'Some issue' },
|
|
user: user
|
|
)
|
|
|
|
expect do
|
|
service.perform
|
|
end.not_to have_enqueued_job(Conversations::ActivityMessageJob)
|
|
end
|
|
|
|
it 'does not enqueue job when issue_data is empty' do
|
|
service = described_class.new(
|
|
conversation: conversation,
|
|
action_type: :issue_created,
|
|
issue_data: {},
|
|
user: user
|
|
)
|
|
|
|
expect do
|
|
service.perform
|
|
end.not_to have_enqueued_job(Conversations::ActivityMessageJob)
|
|
end
|
|
|
|
it 'does not enqueue job when conversation is nil' do
|
|
service = described_class.new(
|
|
conversation: nil,
|
|
action_type: :issue_created,
|
|
issue_data: { id: 'ENG-123' },
|
|
user: user
|
|
)
|
|
|
|
expect do
|
|
service.perform
|
|
end.not_to have_enqueued_job(Conversations::ActivityMessageJob)
|
|
end
|
|
|
|
it 'does not enqueue job when user is nil' do
|
|
service = described_class.new(
|
|
conversation: conversation,
|
|
action_type: :issue_created,
|
|
issue_data: { id: 'ENG-123' },
|
|
user: nil
|
|
)
|
|
|
|
expect do
|
|
service.perform
|
|
end.not_to have_enqueued_job(Conversations::ActivityMessageJob)
|
|
end
|
|
end
|
|
|
|
context 'when action_type is issue_linked' do
|
|
let(:service) do
|
|
described_class.new(
|
|
conversation: conversation,
|
|
action_type: :issue_linked,
|
|
issue_data: { id: 'ENG-456' },
|
|
user: user
|
|
)
|
|
end
|
|
|
|
it 'enqueues an activity message job' do
|
|
expect do
|
|
service.perform
|
|
end.to have_enqueued_job(Conversations::ActivityMessageJob)
|
|
.with(conversation, {
|
|
account_id: conversation.account_id,
|
|
inbox_id: conversation.inbox_id,
|
|
message_type: :activity,
|
|
content: "Linear issue ENG-456 was linked by #{user.name}"
|
|
})
|
|
end
|
|
|
|
it 'does not enqueue job when issue data lacks id' do
|
|
service = described_class.new(
|
|
conversation: conversation,
|
|
action_type: :issue_linked,
|
|
issue_data: { title: 'Some issue' },
|
|
user: user
|
|
)
|
|
|
|
expect do
|
|
service.perform
|
|
end.not_to have_enqueued_job(Conversations::ActivityMessageJob)
|
|
end
|
|
end
|
|
|
|
context 'when action_type is issue_unlinked' do
|
|
let(:service) do
|
|
described_class.new(
|
|
conversation: conversation,
|
|
action_type: :issue_unlinked,
|
|
issue_data: { id: 'ENG-789' },
|
|
user: user
|
|
)
|
|
end
|
|
|
|
it 'enqueues an activity message job' do
|
|
expect do
|
|
service.perform
|
|
end.to have_enqueued_job(Conversations::ActivityMessageJob)
|
|
.with(conversation, {
|
|
account_id: conversation.account_id,
|
|
inbox_id: conversation.inbox_id,
|
|
message_type: :activity,
|
|
content: "Linear issue ENG-789 was unlinked by #{user.name}"
|
|
})
|
|
end
|
|
|
|
it 'does not enqueue job when issue data lacks id' do
|
|
service = described_class.new(
|
|
conversation: conversation,
|
|
action_type: :issue_unlinked,
|
|
issue_data: { title: 'Some issue' },
|
|
user: user
|
|
)
|
|
|
|
expect do
|
|
service.perform
|
|
end.not_to have_enqueued_job(Conversations::ActivityMessageJob)
|
|
end
|
|
end
|
|
|
|
context 'when action_type is unknown' do
|
|
let(:service) do
|
|
described_class.new(
|
|
conversation: conversation,
|
|
action_type: :unknown_action,
|
|
issue_data: { id: 'ENG-999' },
|
|
user: user
|
|
)
|
|
end
|
|
|
|
it 'does not enqueue job for unknown action types' do
|
|
expect do
|
|
service.perform
|
|
end.not_to have_enqueued_job(Conversations::ActivityMessageJob)
|
|
end
|
|
end
|
|
end
|
|
end
|