mirror of
https://github.com/lingble/chatwoot.git
synced 2025-10-29 02:02:27 +00:00
This PR addresses several items listed in our rubocop_todo by implementing the necessary corrections and enhancements. As a result, we are now able to remove the rubocop_todo file entirely, streamlining our codebase and ensuring adherence to our coding standards. fixes: https://linear.app/chatwoot/issue/CW-1806/chore-rubocop-audit
79 lines
2.4 KiB
Ruby
79 lines
2.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
require Rails.root.join 'spec/models/concerns/avatarable_shared.rb'
|
|
|
|
RSpec.describe Contact do
|
|
context 'with validations' do
|
|
it { is_expected.to validate_presence_of(:account_id) }
|
|
end
|
|
|
|
context 'with associations' do
|
|
it { is_expected.to belong_to(:account) }
|
|
it { is_expected.to have_many(:conversations).dependent(:destroy_async) }
|
|
end
|
|
|
|
describe 'concerns' do
|
|
it_behaves_like 'avatarable'
|
|
end
|
|
|
|
context 'when prepare contact attributes before validation' do
|
|
it 'sets email to lowercase' do
|
|
contact = create(:contact, email: 'Test@test.com')
|
|
expect(contact.email).to eq('test@test.com')
|
|
end
|
|
|
|
it 'sets email to nil when empty string' do
|
|
contact = create(:contact, email: '')
|
|
expect(contact.email).to be_nil
|
|
end
|
|
|
|
it 'sets custom_attributes to {} when nil' do
|
|
contact = create(:contact, custom_attributes: nil)
|
|
expect(contact.custom_attributes).to eq({})
|
|
end
|
|
|
|
it 'sets custom_attributes to {} when empty string' do
|
|
contact = create(:contact, custom_attributes: '')
|
|
expect(contact.custom_attributes).to eq({})
|
|
end
|
|
|
|
it 'sets additional_attributes to {} when nil' do
|
|
contact = create(:contact, additional_attributes: nil)
|
|
expect(contact.additional_attributes).to eq({})
|
|
end
|
|
|
|
it 'sets additional_attributes to {} when empty string' do
|
|
contact = create(:contact, additional_attributes: '')
|
|
expect(contact.additional_attributes).to eq({})
|
|
end
|
|
end
|
|
|
|
context 'when phone number format' do
|
|
it 'will throw error for existing invalid phone number' do
|
|
contact = create(:contact)
|
|
expect { contact.update!(phone_number: '123456789') }.to raise_error(ActiveRecord::RecordInvalid)
|
|
end
|
|
|
|
it 'updates phone number when adding valid phone number' do
|
|
contact = create(:contact)
|
|
expect(contact.update!(phone_number: '+12312312321')).to be true
|
|
expect(contact.phone_number).to eq '+12312312321'
|
|
end
|
|
end
|
|
|
|
context 'when email format' do
|
|
it 'will throw error for existing invalid email' do
|
|
contact = create(:contact)
|
|
expect { contact.update!(email: '<2324234234') }.to raise_error(ActiveRecord::RecordInvalid)
|
|
end
|
|
|
|
it 'updates email when adding valid email' do
|
|
contact = create(:contact)
|
|
expect(contact.update!(email: 'test@test.com')).to be true
|
|
expect(contact.email).to eq 'test@test.com'
|
|
end
|
|
end
|
|
end
|