mirror of
				https://github.com/lingble/chatwoot.git
				synced 2025-11-04 13:07:55 +00:00 
			
		
		
		
	# Pull Request Template ## Description This PR fixes an issue with slug validation in the Help Center portal settings. Previously, users were able to create or update slugs with invalid characters such as spaces, slashes, and special symbols, which cause help center to crash. With this update, slug creation and updates are now properly validated. Only slugs that match the allowed pattern will be accepted. No spaces, underscores, slashes, or special characters are allowed. Examples: **user**, **user-guide** --- Fixes https://linear.app/chatwoot/issue/CW-4273/add-validation-for-help-centre-slugs ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) ## How Has This Been Tested? ### Loom video https://www.loom.com/share/a2ca5e2104984f28b29539293ffed33a?sid=e5064cb8-6220-4c43-99da-242c25d32027 ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules
		
			
				
	
	
		
			178 lines
		
	
	
		
			5.7 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
			
		
		
	
	
			178 lines
		
	
	
		
			5.7 KiB
		
	
	
	
		
			JavaScript
		
	
	
	
	
	
import {
 | 
						|
  shouldBeUrl,
 | 
						|
  isPhoneNumberValidWithDialCode,
 | 
						|
  isPhoneE164OrEmpty,
 | 
						|
  isPhoneE164,
 | 
						|
  startsWithPlus,
 | 
						|
  isValidPassword,
 | 
						|
  isPhoneNumberValid,
 | 
						|
  isNumber,
 | 
						|
  isDomain,
 | 
						|
  getRegexp,
 | 
						|
  isValidSlug,
 | 
						|
} from '../Validators';
 | 
						|
 | 
						|
describe('#shouldBeUrl', () => {
 | 
						|
  it('should return correct url', () => {
 | 
						|
    expect(shouldBeUrl('http')).toEqual(true);
 | 
						|
  });
 | 
						|
  it('should return wrong url', () => {
 | 
						|
    expect(shouldBeUrl('')).toEqual(true);
 | 
						|
    expect(shouldBeUrl('abc')).toEqual(false);
 | 
						|
  });
 | 
						|
});
 | 
						|
 | 
						|
describe('#isPhoneE164', () => {
 | 
						|
  it('should return correct phone number', () => {
 | 
						|
    expect(isPhoneE164('+1234567890')).toEqual(true);
 | 
						|
  });
 | 
						|
  it('should return wrong phone number', () => {
 | 
						|
    expect(isPhoneE164('1234567890')).toEqual(false);
 | 
						|
    expect(isPhoneE164('12345678A9')).toEqual(false);
 | 
						|
    expect(isPhoneE164('+12345678901234567890')).toEqual(false);
 | 
						|
  });
 | 
						|
});
 | 
						|
 | 
						|
describe('#isPhoneE164OrEmpty', () => {
 | 
						|
  it('should return correct phone number', () => {
 | 
						|
    expect(isPhoneE164OrEmpty('+1234567890')).toEqual(true);
 | 
						|
    expect(isPhoneE164OrEmpty('')).toEqual(true);
 | 
						|
  });
 | 
						|
  it('should return wrong phone number', () => {
 | 
						|
    expect(isPhoneE164OrEmpty('1234567890')).toEqual(false);
 | 
						|
    expect(isPhoneE164OrEmpty('12345678A9')).toEqual(false);
 | 
						|
    expect(isPhoneE164OrEmpty('+12345678901234567890')).toEqual(false);
 | 
						|
  });
 | 
						|
});
 | 
						|
 | 
						|
describe('#isPhoneNumberValid', () => {
 | 
						|
  it('should return correct phone number', () => {
 | 
						|
    expect(isPhoneNumberValid('1234567890', '+91')).toEqual(true);
 | 
						|
  });
 | 
						|
  it('should return wrong phone number', () => {
 | 
						|
    expect(isPhoneNumberValid('12345A67890', '+1')).toEqual(false);
 | 
						|
    expect(isPhoneNumberValid('12345A6789120', '+1')).toEqual(false);
 | 
						|
  });
 | 
						|
});
 | 
						|
 | 
						|
describe('#isValidPassword', () => {
 | 
						|
  it('should return correct password', () => {
 | 
						|
    expect(isValidPassword('testPass4!')).toEqual(true);
 | 
						|
    expect(isValidPassword('testPass4-')).toEqual(true);
 | 
						|
    expect(isValidPassword('testPass4\\')).toEqual(true);
 | 
						|
    expect(isValidPassword("testPass4'")).toEqual(true);
 | 
						|
  });
 | 
						|
 | 
						|
  it('should return wrong password', () => {
 | 
						|
    expect(isValidPassword('testpass4')).toEqual(false);
 | 
						|
    expect(isValidPassword('testPass4')).toEqual(false);
 | 
						|
    expect(isValidPassword('testpass4!')).toEqual(false);
 | 
						|
    expect(isValidPassword('testPass!')).toEqual(false);
 | 
						|
  });
 | 
						|
});
 | 
						|
 | 
						|
describe('#isNumber', () => {
 | 
						|
  it('should return correct number', () => {
 | 
						|
    expect(isNumber('123')).toEqual(true);
 | 
						|
  });
 | 
						|
 | 
						|
  it('should return wrong number', () => {
 | 
						|
    expect(isNumber('123-')).toEqual(false);
 | 
						|
    expect(isNumber('123./')).toEqual(false);
 | 
						|
    expect(isNumber('string')).toEqual(false);
 | 
						|
  });
 | 
						|
});
 | 
						|
 | 
						|
describe('#isDomain', () => {
 | 
						|
  it('should return correct domain', () => {
 | 
						|
    expect(isDomain('test.com')).toEqual(true);
 | 
						|
    expect(isDomain('www.test.com')).toEqual(true);
 | 
						|
  });
 | 
						|
 | 
						|
  it('should return wrong domain', () => {
 | 
						|
    expect(isDomain('test')).toEqual(false);
 | 
						|
    expect(isDomain('test.')).toEqual(false);
 | 
						|
    expect(isDomain('test.123')).toEqual(false);
 | 
						|
    expect(isDomain('http://www.test.com')).toEqual(false);
 | 
						|
    expect(isDomain('https://test.in')).toEqual(false);
 | 
						|
  });
 | 
						|
});
 | 
						|
 | 
						|
describe('#isPhoneNumberValidWithDialCode', () => {
 | 
						|
  it('should return correct phone number', () => {
 | 
						|
    expect(isPhoneNumberValidWithDialCode('+123456789')).toEqual(true);
 | 
						|
    expect(isPhoneNumberValidWithDialCode('+12345')).toEqual(true);
 | 
						|
  });
 | 
						|
  it('should return wrong phone number', () => {
 | 
						|
    expect(isPhoneNumberValidWithDialCode('+123')).toEqual(false);
 | 
						|
    expect(isPhoneNumberValidWithDialCode('+1234')).toEqual(false);
 | 
						|
  });
 | 
						|
});
 | 
						|
 | 
						|
describe('#startsWithPlus', () => {
 | 
						|
  it('should return correct phone number', () => {
 | 
						|
    expect(startsWithPlus('+123456789')).toEqual(true);
 | 
						|
  });
 | 
						|
  it('should return wrong phone number', () => {
 | 
						|
    expect(startsWithPlus('123456789')).toEqual(false);
 | 
						|
  });
 | 
						|
});
 | 
						|
 | 
						|
describe('#getRegexp', () => {
 | 
						|
  it('should create a correct RegExp object', () => {
 | 
						|
    const regexPattern = '/^[a-z]+$/i';
 | 
						|
    const regex = getRegexp(regexPattern);
 | 
						|
 | 
						|
    expect(regex).toBeInstanceOf(RegExp);
 | 
						|
    expect(regex.toString()).toBe(regexPattern);
 | 
						|
 | 
						|
    expect(regex.test('abc')).toBe(true);
 | 
						|
    expect(regex.test('ABC')).toBe(true);
 | 
						|
    expect(regex.test('123')).toBe(false);
 | 
						|
  });
 | 
						|
 | 
						|
  it('should handle regex with flags', () => {
 | 
						|
    const regexPattern = '/hello/gi';
 | 
						|
    const regex = getRegexp(regexPattern);
 | 
						|
 | 
						|
    expect(regex).toBeInstanceOf(RegExp);
 | 
						|
    expect(regex.toString()).toBe(regexPattern);
 | 
						|
 | 
						|
    expect(regex.test('hello')).toBe(true);
 | 
						|
    expect(regex.test('HELLO')).toBe(false);
 | 
						|
    expect(regex.test('Hello World')).toBe(true);
 | 
						|
  });
 | 
						|
 | 
						|
  it('should handle regex with special characters', () => {
 | 
						|
    const regexPattern = '/\\d{3}-\\d{2}-\\d{4}/';
 | 
						|
    const regex = getRegexp(regexPattern);
 | 
						|
 | 
						|
    expect(regex).toBeInstanceOf(RegExp);
 | 
						|
    expect(regex.toString()).toBe(regexPattern);
 | 
						|
 | 
						|
    expect(regex.test('123-45-6789')).toBe(true);
 | 
						|
    expect(regex.test('12-34-5678')).toBe(false);
 | 
						|
  });
 | 
						|
});
 | 
						|
 | 
						|
describe('#isValidSlug', () => {
 | 
						|
  it('should return true for valid slugs', () => {
 | 
						|
    expect(isValidSlug('abc')).toEqual(true);
 | 
						|
    expect(isValidSlug('abc-123')).toEqual(true);
 | 
						|
    expect(isValidSlug('a-b-c')).toEqual(true);
 | 
						|
    expect(isValidSlug('123')).toEqual(true);
 | 
						|
    expect(isValidSlug('abc123-def')).toEqual(true);
 | 
						|
  });
 | 
						|
  it('should return false for invalid slugs', () => {
 | 
						|
    expect(isValidSlug('abc_def')).toEqual(false);
 | 
						|
    expect(isValidSlug('abc def')).toEqual(false);
 | 
						|
    expect(isValidSlug('abc@def')).toEqual(false);
 | 
						|
    expect(isValidSlug('abc.def')).toEqual(false);
 | 
						|
    expect(isValidSlug('abc/def')).toEqual(false);
 | 
						|
    expect(isValidSlug('abc!def')).toEqual(false);
 | 
						|
    expect(isValidSlug('abc--def!')).toEqual(false);
 | 
						|
    expect(isValidSlug('abc-def ')).toEqual(false);
 | 
						|
    expect(isValidSlug(' abc-def')).toEqual(false);
 | 
						|
  });
 | 
						|
});
 |