mirror of
https://github.com/lingble/chatwoot.git
synced 2025-11-03 04:27:53 +00:00
# Pull Request Template ## Description This PR adds new eslint rules to the code base. **Error rules** | Rule name | Type | Files updated | | ----------------- | --- | - | | `vue/block-order` | error | ✅ | | `vue/component-name-in-template-casing` | error | ✅ | | `vue/component-options-name-casing` | error | ✅ | | `vue/custom-event-name-casing` | error | ✅ | | `vue/define-emits-declaration` | error | ✅ | | `vue/no-unused-properties` | error | ✅ | | `vue/define-macros-order` | error | ✅ | | `vue/define-props-declaration` | error | ✅ | | `vue/match-component-import-name` | error | ✅ | | `vue/next-tick-style` | error | ✅ | | `vue/no-bare-strings-in-template` | error | ✅ | | `vue/no-empty-component-block` | error | ✅ | | `vue/no-multiple-objects-in-class` | error | ✅ | | `vue/no-required-prop-with-default` | error | ✅ | | `vue/no-static-inline-styles` | error | ✅ | | `vue/no-template-target-blank` | error | ✅ | | `vue/no-this-in-before-route-enter` | error | ✅ | | `vue/no-undef-components` | error | ✅ | | `vue/no-unused-emit-declarations` | error | ✅ | | `vue/no-unused-refs` | error | ✅ | | `vue/no-use-v-else-with-v-for` | error | ✅ | | `vue/no-useless-v-bind` | error | ✅ | | `vue/no-v-text` | error | ✅ | | `vue/padding-line-between-blocks` | error | ✅ | | ~`vue/prefer-prop-type-boolean-first`~ | ~error~ | ❌ (removed this rule, cause a bug in displaying custom attributes) | | `vue/prefer-separate-static-class` | error | ✅ | | `vue/prefer-true-attribute-shorthand` | error | ✅ | | `vue/require-explicit-slots` | error | ✅ | | `vue/require-macro-variable-name` | error | ✅ | **Warn rules** | Rule name | Type | Files updated | | ---- | ------------- | ------------- | | `vue/no-root-v-if` | warn | ❎ | Fixes https://linear.app/chatwoot/issue/CW-3492/vue-eslint-rules ## Type of change - [x] New feature (non-breaking change which adds functionality) ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules --------- Co-authored-by: Fayaz Ahmed <fayazara@gmail.com> Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com> Co-authored-by: Shivam Mishra <scm.mymail@gmail.com> Co-authored-by: Pranav <pranav@chatwoot.com>
131 lines
2.7 KiB
Vue
131 lines
2.7 KiB
Vue
<script>
|
|
import EmojiOrIcon from 'shared/components/EmojiOrIcon.vue';
|
|
|
|
export default {
|
|
components: {
|
|
EmojiOrIcon,
|
|
},
|
|
props: {
|
|
label: { type: String, required: true },
|
|
icon: { type: String, default: '' },
|
|
emoji: { type: String, default: '' },
|
|
value: { type: [String, Number], default: '' },
|
|
showEdit: { type: Boolean, default: false },
|
|
},
|
|
data() {
|
|
return {
|
|
isEditing: false,
|
|
editedValue: this.value,
|
|
};
|
|
},
|
|
methods: {
|
|
focusInput() {
|
|
this.$refs.inputfield.focus();
|
|
},
|
|
onEdit() {
|
|
this.isEditing = true;
|
|
this.$nextTick(() => {
|
|
this.focusInput();
|
|
});
|
|
},
|
|
onUpdate() {
|
|
this.isEditing = false;
|
|
this.$emit('update', this.editedValue);
|
|
},
|
|
},
|
|
};
|
|
</script>
|
|
|
|
<template>
|
|
<div class="contact-attribute">
|
|
<div class="title-wrap">
|
|
<h4 class="text-sm title">
|
|
<div class="title--icon">
|
|
<EmojiOrIcon :icon="icon" :emoji="emoji" />
|
|
</div>
|
|
{{ label }}
|
|
</h4>
|
|
</div>
|
|
<div v-show="isEditing">
|
|
<div class="mb-2 w-full flex items-center">
|
|
<input
|
|
ref="inputfield"
|
|
v-model="editedValue"
|
|
type="text"
|
|
class="!h-8 ltr:rounded-r-none rtl:rounded-l-none !mb-0 !text-sm"
|
|
autofocus="true"
|
|
@keyup.enter="onUpdate"
|
|
/>
|
|
<div>
|
|
<woot-button
|
|
size="small"
|
|
icon="ion-checkmark"
|
|
class="rounded-l-none rtl:rounded-r-none"
|
|
@click="onUpdate"
|
|
/>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<div
|
|
v-show="!isEditing"
|
|
class="value--view"
|
|
:class="{ 'is-editable': showEdit }"
|
|
>
|
|
<p class="value">
|
|
{{ value || '---' }}
|
|
</p>
|
|
<woot-button
|
|
v-if="showEdit"
|
|
variant="clear link"
|
|
size="small"
|
|
color-scheme="secondary"
|
|
icon="edit"
|
|
class-names="edit-button"
|
|
@click="onEdit"
|
|
/>
|
|
</div>
|
|
</div>
|
|
</template>
|
|
|
|
<style lang="scss" scoped>
|
|
.contact-attribute {
|
|
margin-bottom: var(--space-small);
|
|
}
|
|
.title-wrap {
|
|
display: flex;
|
|
align-items: center;
|
|
margin-bottom: var(--space-mini);
|
|
}
|
|
.title {
|
|
display: flex;
|
|
align-items: center;
|
|
margin: 0;
|
|
}
|
|
.title--icon {
|
|
width: var(--space-two);
|
|
}
|
|
.edit-button {
|
|
display: none;
|
|
}
|
|
.value--view {
|
|
display: flex;
|
|
|
|
&.is-editable:hover {
|
|
.value {
|
|
background: var(--color-background);
|
|
}
|
|
.edit-button {
|
|
display: block;
|
|
}
|
|
}
|
|
}
|
|
.value {
|
|
display: inline-block;
|
|
min-width: var(--space-mega);
|
|
border-radius: var(--border-radius-small);
|
|
word-break: break-all;
|
|
margin: 0 var(--space-smaller) 0 var(--space-normal);
|
|
padding: var(--space-micro) var(--space-smaller);
|
|
}
|
|
</style>
|