mirror of
https://github.com/lingble/chatwoot.git
synced 2025-11-08 06:53:26 +00:00
# Pull Request Template ## Description This PR adds new eslint rules to the code base. **Error rules** | Rule name | Type | Files updated | | ----------------- | --- | - | | `vue/block-order` | error | ✅ | | `vue/component-name-in-template-casing` | error | ✅ | | `vue/component-options-name-casing` | error | ✅ | | `vue/custom-event-name-casing` | error | ✅ | | `vue/define-emits-declaration` | error | ✅ | | `vue/no-unused-properties` | error | ✅ | | `vue/define-macros-order` | error | ✅ | | `vue/define-props-declaration` | error | ✅ | | `vue/match-component-import-name` | error | ✅ | | `vue/next-tick-style` | error | ✅ | | `vue/no-bare-strings-in-template` | error | ✅ | | `vue/no-empty-component-block` | error | ✅ | | `vue/no-multiple-objects-in-class` | error | ✅ | | `vue/no-required-prop-with-default` | error | ✅ | | `vue/no-static-inline-styles` | error | ✅ | | `vue/no-template-target-blank` | error | ✅ | | `vue/no-this-in-before-route-enter` | error | ✅ | | `vue/no-undef-components` | error | ✅ | | `vue/no-unused-emit-declarations` | error | ✅ | | `vue/no-unused-refs` | error | ✅ | | `vue/no-use-v-else-with-v-for` | error | ✅ | | `vue/no-useless-v-bind` | error | ✅ | | `vue/no-v-text` | error | ✅ | | `vue/padding-line-between-blocks` | error | ✅ | | ~`vue/prefer-prop-type-boolean-first`~ | ~error~ | ❌ (removed this rule, cause a bug in displaying custom attributes) | | `vue/prefer-separate-static-class` | error | ✅ | | `vue/prefer-true-attribute-shorthand` | error | ✅ | | `vue/require-explicit-slots` | error | ✅ | | `vue/require-macro-variable-name` | error | ✅ | **Warn rules** | Rule name | Type | Files updated | | ---- | ------------- | ------------- | | `vue/no-root-v-if` | warn | ❎ | Fixes https://linear.app/chatwoot/issue/CW-3492/vue-eslint-rules ## Type of change - [x] New feature (non-breaking change which adds functionality) ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules --------- Co-authored-by: Fayaz Ahmed <fayazara@gmail.com> Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com> Co-authored-by: Shivam Mishra <scm.mymail@gmail.com> Co-authored-by: Pranav <pranav@chatwoot.com>
85 lines
1.9 KiB
Vue
85 lines
1.9 KiB
Vue
<script>
|
|
export default {
|
|
props: {
|
|
menuPlacement: {
|
|
type: String,
|
|
default: 'right',
|
|
validator: value => ['right', 'left'].indexOf(value) !== -1,
|
|
},
|
|
open: {
|
|
type: Boolean,
|
|
default: false,
|
|
},
|
|
toggleMenu: {
|
|
type: Function,
|
|
default: () => {},
|
|
},
|
|
},
|
|
data() {
|
|
return {
|
|
isOpen: false,
|
|
};
|
|
},
|
|
watch: {
|
|
open() {
|
|
this.isOpen = !this.isOpen;
|
|
},
|
|
},
|
|
mounted() {
|
|
document.addEventListener('keydown', this.onEscape);
|
|
},
|
|
beforeDestroy() {
|
|
document.removeEventListener('keydown', this.onEscape);
|
|
},
|
|
methods: {
|
|
onEscape(e) {
|
|
if (e.key === 'Esc' || e.key === 'Escape') {
|
|
this.isOpen = false;
|
|
}
|
|
},
|
|
},
|
|
};
|
|
</script>
|
|
|
|
<template>
|
|
<div class="relative">
|
|
<button class="z-10 focus:outline-none select-none" @click="toggleMenu">
|
|
<slot name="button" />
|
|
</button>
|
|
|
|
<!-- to close when clicked on space around it-->
|
|
<button
|
|
v-if="isOpen"
|
|
tabindex="-1"
|
|
class="fixed inset-0 h-full w-full cursor-default focus:outline-none"
|
|
@click="toggleMenu"
|
|
/>
|
|
|
|
<!--dropdown menu-->
|
|
<transition
|
|
enter-active-class="transition-all duration-200 ease-out"
|
|
leave-active-class="transition-all duration-750 ease-in"
|
|
enter-class="opacity-0 scale-75"
|
|
enter-to-class="opacity-100 scale-100"
|
|
leave-class="opacity-100 scale-100"
|
|
leave-to-class="opacity-0 scale-75"
|
|
>
|
|
<div
|
|
v-if="isOpen"
|
|
class="menu-content absolute shadow-xl rounded-md border-solid border border-slate-100 mt-1 py-1 px-2 bg-white z-10"
|
|
:class="menuPlacement === 'right' ? 'right-0' : 'left-0'"
|
|
>
|
|
<slot name="content" />
|
|
</div>
|
|
</transition>
|
|
</div>
|
|
</template>
|
|
|
|
<style scoped lang="scss">
|
|
@import '~widget/assets/scss/variables.scss';
|
|
|
|
.menu-content {
|
|
width: max-content;
|
|
}
|
|
</style>
|