mirror of
				https://github.com/lingble/chatwoot.git
				synced 2025-10-31 11:08:04 +00:00 
			
		
		
		
	 b4b308336f
			
		
	
	b4b308336f
	
	
	
		
			
			# Pull Request Template ## Description This PR adds new eslint rules to the code base. **Error rules** | Rule name | Type | Files updated | | ----------------- | --- | - | | `vue/block-order` | error | ✅ | | `vue/component-name-in-template-casing` | error | ✅ | | `vue/component-options-name-casing` | error | ✅ | | `vue/custom-event-name-casing` | error | ✅ | | `vue/define-emits-declaration` | error | ✅ | | `vue/no-unused-properties` | error | ✅ | | `vue/define-macros-order` | error | ✅ | | `vue/define-props-declaration` | error | ✅ | | `vue/match-component-import-name` | error | ✅ | | `vue/next-tick-style` | error | ✅ | | `vue/no-bare-strings-in-template` | error | ✅ | | `vue/no-empty-component-block` | error | ✅ | | `vue/no-multiple-objects-in-class` | error | ✅ | | `vue/no-required-prop-with-default` | error | ✅ | | `vue/no-static-inline-styles` | error | ✅ | | `vue/no-template-target-blank` | error | ✅ | | `vue/no-this-in-before-route-enter` | error | ✅ | | `vue/no-undef-components` | error | ✅ | | `vue/no-unused-emit-declarations` | error | ✅ | | `vue/no-unused-refs` | error | ✅ | | `vue/no-use-v-else-with-v-for` | error | ✅ | | `vue/no-useless-v-bind` | error | ✅ | | `vue/no-v-text` | error | ✅ | | `vue/padding-line-between-blocks` | error | ✅ | | ~`vue/prefer-prop-type-boolean-first`~ | ~error~ | ❌ (removed this rule, cause a bug in displaying custom attributes) | | `vue/prefer-separate-static-class` | error | ✅ | | `vue/prefer-true-attribute-shorthand` | error | ✅ | | `vue/require-explicit-slots` | error | ✅ | | `vue/require-macro-variable-name` | error | ✅ | **Warn rules** | Rule name | Type | Files updated | | ---- | ------------- | ------------- | | `vue/no-root-v-if` | warn | ❎ | Fixes https://linear.app/chatwoot/issue/CW-3492/vue-eslint-rules ## Type of change - [x] New feature (non-breaking change which adds functionality) ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules --------- Co-authored-by: Fayaz Ahmed <fayazara@gmail.com> Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com> Co-authored-by: Shivam Mishra <scm.mymail@gmail.com> Co-authored-by: Pranav <pranav@chatwoot.com>
		
			
				
	
	
		
			56 lines
		
	
	
		
			1.2 KiB
		
	
	
	
		
			Vue
		
	
	
	
	
	
			
		
		
	
	
			56 lines
		
	
	
		
			1.2 KiB
		
	
	
	
		
			Vue
		
	
	
	
	
	
| <script>
 | |
| import ArticleSkeletonLoader from 'shared/components/ArticleSkeletonLoader.vue';
 | |
| 
 | |
| export default {
 | |
|   name: 'IframeLoader',
 | |
|   components: {
 | |
|     ArticleSkeletonLoader,
 | |
|   },
 | |
|   props: {
 | |
|     url: {
 | |
|       type: String,
 | |
|       default: '',
 | |
|     },
 | |
|   },
 | |
|   data() {
 | |
|     return {
 | |
|       isLoading: true,
 | |
|       showEmptyState: !this.url,
 | |
|     };
 | |
|   },
 | |
|   methods: {
 | |
|     handleIframeLoad() {
 | |
|       // Once loaded, the loading state is hidden
 | |
|       this.isLoading = false;
 | |
|     },
 | |
|     handleIframeError() {
 | |
|       // Hide the loading state and show the empty state when an error occurs
 | |
|       this.isLoading = false;
 | |
|       this.showEmptyState = true;
 | |
|     },
 | |
|   },
 | |
| };
 | |
| </script>
 | |
| 
 | |
| <template>
 | |
|   <div class="relative overflow-hidden pb-1/2 h-full">
 | |
|     <iframe
 | |
|       v-if="url"
 | |
|       :src="url"
 | |
|       class="absolute w-full h-full top-0 left-0"
 | |
|       @load="handleIframeLoad"
 | |
|       @error="handleIframeError"
 | |
|     />
 | |
|     <ArticleSkeletonLoader
 | |
|       v-if="isLoading"
 | |
|       class="absolute w-full h-full top-0 left-0"
 | |
|     />
 | |
|     <div
 | |
|       v-if="showEmptyState"
 | |
|       class="absolute w-full h-full top-0 left-0 flex justify-center items-center"
 | |
|     >
 | |
|       <p>{{ $t('PORTAL.IFRAME_ERROR') }}</p>
 | |
|     </div>
 | |
|   </div>
 | |
| </template>
 |