mirror of
https://github.com/lingble/chatwoot.git
synced 2025-11-01 03:27:52 +00:00
12134f9391
Fixes https://linear.app/chatwoot/issue/CW-3417/oauth-20-authentication We are planning to publish the Chatwoot app in the Linear [integration list](https://linear.app/docs/integration-directory). While we currently use token-based authentication, Linear recommends OAuth2 authentication. This PR implements OAuth2 support. --------- Co-authored-by: Sivin Varghese <64252451+iamsivin@users.noreply.github.com> Co-authored-by: Shivam Mishra <scm.mymail@gmail.com>
82 lines
2.4 KiB
Ruby
82 lines
2.4 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe Linear::IntegrationHelper do
|
|
include described_class
|
|
|
|
describe '#generate_linear_token' do
|
|
let(:account_id) { 1 }
|
|
let(:client_secret) { 'test_secret' }
|
|
let(:current_time) { Time.current }
|
|
|
|
before do
|
|
allow(ENV).to receive(:fetch).with('LINEAR_CLIENT_SECRET', nil).and_return(client_secret)
|
|
allow(Time).to receive(:current).and_return(current_time)
|
|
end
|
|
|
|
it 'generates a valid JWT token with correct payload' do
|
|
token = generate_linear_token(account_id)
|
|
decoded_token = JWT.decode(token, client_secret, true, algorithm: 'HS256').first
|
|
|
|
expect(decoded_token['sub']).to eq(account_id)
|
|
expect(decoded_token['iat']).to eq(current_time.to_i)
|
|
end
|
|
|
|
context 'when client secret is not configured' do
|
|
let(:client_secret) { nil }
|
|
|
|
it 'returns nil' do
|
|
expect(generate_linear_token(account_id)).to be_nil
|
|
end
|
|
end
|
|
|
|
context 'when an error occurs' do
|
|
before do
|
|
allow(JWT).to receive(:encode).and_raise(StandardError.new('Test error'))
|
|
end
|
|
|
|
it 'logs the error and returns nil' do
|
|
expect(Rails.logger).to receive(:error).with('Failed to generate Linear token: Test error')
|
|
expect(generate_linear_token(account_id)).to be_nil
|
|
end
|
|
end
|
|
end
|
|
|
|
describe '#verify_linear_token' do
|
|
let(:account_id) { 1 }
|
|
let(:client_secret) { 'test_secret' }
|
|
let(:valid_token) do
|
|
JWT.encode({ sub: account_id, iat: Time.current.to_i }, client_secret, 'HS256')
|
|
end
|
|
|
|
before do
|
|
allow(ENV).to receive(:fetch).with('LINEAR_CLIENT_SECRET', nil).and_return(client_secret)
|
|
end
|
|
|
|
it 'successfully verifies and returns account_id from valid token' do
|
|
expect(verify_linear_token(valid_token)).to eq(account_id)
|
|
end
|
|
|
|
context 'when token is blank' do
|
|
it 'returns nil' do
|
|
expect(verify_linear_token('')).to be_nil
|
|
expect(verify_linear_token(nil)).to be_nil
|
|
end
|
|
end
|
|
|
|
context 'when client secret is not configured' do
|
|
let(:client_secret) { nil }
|
|
|
|
it 'returns nil' do
|
|
expect(verify_linear_token(valid_token)).to be_nil
|
|
end
|
|
end
|
|
|
|
context 'when token is invalid' do
|
|
it 'logs the error and returns nil' do
|
|
expect(Rails.logger).to receive(:error).with(/Unexpected error verifying Linear token:/)
|
|
expect(verify_linear_token('invalid_token')).to be_nil
|
|
end
|
|
end
|
|
end
|
|
end
|