mirror of
https://github.com/lingble/chatwoot.git
synced 2025-11-03 12:37:56 +00:00
# Pull Request Template ## Description This PR adds new eslint rules to the code base. **Error rules** | Rule name | Type | Files updated | | ----------------- | --- | - | | `vue/block-order` | error | ✅ | | `vue/component-name-in-template-casing` | error | ✅ | | `vue/component-options-name-casing` | error | ✅ | | `vue/custom-event-name-casing` | error | ✅ | | `vue/define-emits-declaration` | error | ✅ | | `vue/no-unused-properties` | error | ✅ | | `vue/define-macros-order` | error | ✅ | | `vue/define-props-declaration` | error | ✅ | | `vue/match-component-import-name` | error | ✅ | | `vue/next-tick-style` | error | ✅ | | `vue/no-bare-strings-in-template` | error | ✅ | | `vue/no-empty-component-block` | error | ✅ | | `vue/no-multiple-objects-in-class` | error | ✅ | | `vue/no-required-prop-with-default` | error | ✅ | | `vue/no-static-inline-styles` | error | ✅ | | `vue/no-template-target-blank` | error | ✅ | | `vue/no-this-in-before-route-enter` | error | ✅ | | `vue/no-undef-components` | error | ✅ | | `vue/no-unused-emit-declarations` | error | ✅ | | `vue/no-unused-refs` | error | ✅ | | `vue/no-use-v-else-with-v-for` | error | ✅ | | `vue/no-useless-v-bind` | error | ✅ | | `vue/no-v-text` | error | ✅ | | `vue/padding-line-between-blocks` | error | ✅ | | ~`vue/prefer-prop-type-boolean-first`~ | ~error~ | ❌ (removed this rule, cause a bug in displaying custom attributes) | | `vue/prefer-separate-static-class` | error | ✅ | | `vue/prefer-true-attribute-shorthand` | error | ✅ | | `vue/require-explicit-slots` | error | ✅ | | `vue/require-macro-variable-name` | error | ✅ | **Warn rules** | Rule name | Type | Files updated | | ---- | ------------- | ------------- | | `vue/no-root-v-if` | warn | ❎ | Fixes https://linear.app/chatwoot/issue/CW-3492/vue-eslint-rules ## Type of change - [x] New feature (non-breaking change which adds functionality) ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules --------- Co-authored-by: Fayaz Ahmed <fayazara@gmail.com> Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com> Co-authored-by: Shivam Mishra <scm.mymail@gmail.com> Co-authored-by: Pranav <pranav@chatwoot.com>
75 lines
2.3 KiB
Vue
75 lines
2.3 KiB
Vue
<script setup>
|
|
import { ref, computed, defineComponent } from 'vue';
|
|
import FilterButton from 'dashboard/components/ui/Dropdown/DropdownButton.vue';
|
|
import FilterListDropdown from 'dashboard/components/ui/Dropdown/DropdownList.vue';
|
|
|
|
const props = defineProps({
|
|
type: { type: String, required: true },
|
|
label: { type: String, default: null },
|
|
items: { type: Array, required: true },
|
|
value: { type: [Number, String], default: null },
|
|
placeholder: { type: String, default: null },
|
|
error: { type: String, default: null },
|
|
});
|
|
|
|
const emit = defineEmits(['change']);
|
|
|
|
defineComponent({
|
|
name: 'SearchableDropdown',
|
|
});
|
|
|
|
const shouldShowDropdown = ref(false);
|
|
|
|
const toggleDropdown = () => {
|
|
shouldShowDropdown.value = !shouldShowDropdown.value;
|
|
};
|
|
const onSelect = item => {
|
|
emit('change', item, props.type);
|
|
toggleDropdown();
|
|
};
|
|
|
|
const hasError = computed(() => !!props.error);
|
|
|
|
const selectedItem = computed(() => {
|
|
if (!props.value) return null;
|
|
return props.items.find(i => i.id === props.value);
|
|
});
|
|
|
|
const selectedItemName = computed(
|
|
() => selectedItem.value?.name || props.placeholder
|
|
);
|
|
|
|
const selectedItemId = computed(() => selectedItem.value?.id || null);
|
|
</script>
|
|
|
|
<template>
|
|
<div
|
|
class="flex w-full"
|
|
:class="type === 'stateId' && shouldShowDropdown ? 'h-[150px]' : 'gap-2'"
|
|
>
|
|
<label class="w-full" :class="{ error: hasError }">
|
|
{{ label }}
|
|
<FilterButton
|
|
right-icon="chevron-down"
|
|
:button-text="selectedItemName"
|
|
class="justify-between w-full h-[2.5rem] py-1.5 px-3 rounded-xl border border-slate-50 bg-slate-25 dark:border-slate-600 dark:bg-slate-900 hover:bg-slate-50 dark:hover:bg-slate-900/50"
|
|
@click="toggleDropdown"
|
|
>
|
|
<template v-if="shouldShowDropdown" #dropdown>
|
|
<FilterListDropdown
|
|
v-on-clickaway="toggleDropdown"
|
|
:show-clear-filter="false"
|
|
:list-items="items"
|
|
:active-filter-id="selectedItemId"
|
|
:input-placeholder="placeholder"
|
|
enable-search
|
|
class="left-0 flex flex-col w-full overflow-y-auto h-fit !max-h-[160px] md:left-auto md:right-0 top-10"
|
|
@click="onSelect"
|
|
/>
|
|
</template>
|
|
</FilterButton>
|
|
<span v-if="hasError" class="mt-1 message">{{ error }}</span>
|
|
</label>
|
|
</div>
|
|
</template>
|