mirror of
https://github.com/lingble/chatwoot.git
synced 2025-11-01 19:48:08 +00:00
# Pull Request Template ## Description This PR adds new eslint rules to the code base. **Error rules** | Rule name | Type | Files updated | | ----------------- | --- | - | | `vue/block-order` | error | ✅ | | `vue/component-name-in-template-casing` | error | ✅ | | `vue/component-options-name-casing` | error | ✅ | | `vue/custom-event-name-casing` | error | ✅ | | `vue/define-emits-declaration` | error | ✅ | | `vue/no-unused-properties` | error | ✅ | | `vue/define-macros-order` | error | ✅ | | `vue/define-props-declaration` | error | ✅ | | `vue/match-component-import-name` | error | ✅ | | `vue/next-tick-style` | error | ✅ | | `vue/no-bare-strings-in-template` | error | ✅ | | `vue/no-empty-component-block` | error | ✅ | | `vue/no-multiple-objects-in-class` | error | ✅ | | `vue/no-required-prop-with-default` | error | ✅ | | `vue/no-static-inline-styles` | error | ✅ | | `vue/no-template-target-blank` | error | ✅ | | `vue/no-this-in-before-route-enter` | error | ✅ | | `vue/no-undef-components` | error | ✅ | | `vue/no-unused-emit-declarations` | error | ✅ | | `vue/no-unused-refs` | error | ✅ | | `vue/no-use-v-else-with-v-for` | error | ✅ | | `vue/no-useless-v-bind` | error | ✅ | | `vue/no-v-text` | error | ✅ | | `vue/padding-line-between-blocks` | error | ✅ | | ~`vue/prefer-prop-type-boolean-first`~ | ~error~ | ❌ (removed this rule, cause a bug in displaying custom attributes) | | `vue/prefer-separate-static-class` | error | ✅ | | `vue/prefer-true-attribute-shorthand` | error | ✅ | | `vue/require-explicit-slots` | error | ✅ | | `vue/require-macro-variable-name` | error | ✅ | **Warn rules** | Rule name | Type | Files updated | | ---- | ------------- | ------------- | | `vue/no-root-v-if` | warn | ❎ | Fixes https://linear.app/chatwoot/issue/CW-3492/vue-eslint-rules ## Type of change - [x] New feature (non-breaking change which adds functionality) ## Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my code - [x] I have commented on my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published in downstream modules --------- Co-authored-by: Fayaz Ahmed <fayazara@gmail.com> Co-authored-by: Muhsin Keloth <muhsinkeramam@gmail.com> Co-authored-by: Shivam Mishra <scm.mymail@gmail.com> Co-authored-by: Pranav <pranav@chatwoot.com>
175 lines
4.9 KiB
Vue
175 lines
4.9 KiB
Vue
<script>
|
|
import { validEmailsByComma } from './helpers/emailHeadHelper';
|
|
import { useVuelidate } from '@vuelidate/core';
|
|
|
|
export default {
|
|
props: {
|
|
ccEmails: {
|
|
type: String,
|
|
default: '',
|
|
},
|
|
bccEmails: {
|
|
type: String,
|
|
default: '',
|
|
},
|
|
toEmails: {
|
|
type: String,
|
|
default: '',
|
|
},
|
|
},
|
|
setup() {
|
|
return { v$: useVuelidate() };
|
|
},
|
|
data() {
|
|
return {
|
|
showBcc: false,
|
|
ccEmailsVal: '',
|
|
bccEmailsVal: '',
|
|
toEmailsVal: '',
|
|
};
|
|
},
|
|
watch: {
|
|
bccEmails(newVal) {
|
|
if (newVal !== this.bccEmailsVal) {
|
|
this.bccEmailsVal = newVal;
|
|
}
|
|
},
|
|
ccEmails(newVal) {
|
|
if (newVal !== this.ccEmailsVal) {
|
|
this.ccEmailsVal = newVal;
|
|
}
|
|
},
|
|
toEmails(newVal) {
|
|
if (newVal !== this.toEmailsVal) {
|
|
this.toEmailsVal = newVal;
|
|
}
|
|
},
|
|
},
|
|
mounted() {
|
|
this.ccEmailsVal = this.ccEmails;
|
|
this.bccEmailsVal = this.bccEmails;
|
|
this.toEmailsVal = this.toEmails;
|
|
},
|
|
validations: {
|
|
ccEmailsVal: {
|
|
hasValidEmails(value) {
|
|
return validEmailsByComma(value);
|
|
},
|
|
},
|
|
bccEmailsVal: {
|
|
hasValidEmails(value) {
|
|
return validEmailsByComma(value);
|
|
},
|
|
},
|
|
toEmailsVal: {
|
|
hasValidEmails(value) {
|
|
return validEmailsByComma(value);
|
|
},
|
|
},
|
|
},
|
|
methods: {
|
|
handleAddBcc() {
|
|
this.showBcc = true;
|
|
},
|
|
onBlur() {
|
|
this.v$.$touch();
|
|
this.$emit('update:bccEmails', this.bccEmailsVal);
|
|
this.$emit('update:ccEmails', this.ccEmailsVal);
|
|
this.$emit('update:toEmails', this.toEmailsVal);
|
|
},
|
|
},
|
|
};
|
|
</script>
|
|
|
|
<template>
|
|
<div>
|
|
<div v-if="toEmails">
|
|
<div class="input-group small" :class="{ error: v$.toEmailsVal.$error }">
|
|
<label class="input-group-label">
|
|
{{ $t('CONVERSATION.REPLYBOX.EMAIL_HEAD.TO') }}
|
|
</label>
|
|
<div class="rounded-none flex-1 min-w-0 m-0 whitespace-nowrap">
|
|
<woot-input
|
|
v-model.trim="v$.toEmailsVal.$model"
|
|
type="text"
|
|
class="[&>input]:!mb-0 [&>input]:border-transparent [&>input]:h-8 [&>input]:text-sm [&>input]:!border-0 [&>input]:border-none"
|
|
:class="{ error: v$.toEmailsVal.$error }"
|
|
:placeholder="$t('CONVERSATION.REPLYBOX.EMAIL_HEAD.CC.PLACEHOLDER')"
|
|
@blur="onBlur"
|
|
/>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
<div class="input-group-wrap">
|
|
<div class="input-group small" :class="{ error: v$.ccEmailsVal.$error }">
|
|
<label class="input-group-label">
|
|
{{ $t('CONVERSATION.REPLYBOX.EMAIL_HEAD.CC.LABEL') }}
|
|
</label>
|
|
<div class="rounded-none flex-1 min-w-0 m-0 whitespace-nowrap">
|
|
<woot-input
|
|
v-model.trim="v$.ccEmailsVal.$model"
|
|
class="[&>input]:!mb-0 [&>input]:border-transparent [&>input]:h-8 [&>input]:text-sm [&>input]:!border-0 [&>input]:border-none"
|
|
type="text"
|
|
:class="{ error: v$.ccEmailsVal.$error }"
|
|
:placeholder="$t('CONVERSATION.REPLYBOX.EMAIL_HEAD.CC.PLACEHOLDER')"
|
|
@blur="onBlur"
|
|
/>
|
|
</div>
|
|
<woot-button
|
|
v-if="!showBcc"
|
|
variant="clear"
|
|
size="small"
|
|
@click="handleAddBcc"
|
|
>
|
|
{{ $t('CONVERSATION.REPLYBOX.EMAIL_HEAD.ADD_BCC') }}
|
|
</woot-button>
|
|
</div>
|
|
<span v-if="v$.ccEmailsVal.$error" class="message">
|
|
{{ $t('CONVERSATION.REPLYBOX.EMAIL_HEAD.CC.ERROR') }}
|
|
</span>
|
|
</div>
|
|
<div v-if="showBcc" class="input-group-wrap">
|
|
<div class="input-group small" :class="{ error: v$.bccEmailsVal.$error }">
|
|
<label class="input-group-label">
|
|
{{ $t('CONVERSATION.REPLYBOX.EMAIL_HEAD.BCC.LABEL') }}
|
|
</label>
|
|
<div class="rounded-none flex-1 min-w-0 m-0 whitespace-nowrap">
|
|
<woot-input
|
|
v-model.trim="v$.bccEmailsVal.$model"
|
|
type="text"
|
|
class="[&>input]:!mb-0 [&>input]:border-transparent [&>input]:h-8 [&>input]:text-sm [&>input]:!border-0 [&>input]:border-none"
|
|
:class="{ error: v$.bccEmailsVal.$error }"
|
|
:placeholder="
|
|
$t('CONVERSATION.REPLYBOX.EMAIL_HEAD.BCC.PLACEHOLDER')
|
|
"
|
|
@blur="onBlur"
|
|
/>
|
|
</div>
|
|
</div>
|
|
<span v-if="v$.bccEmailsVal.$error" class="message">
|
|
{{ $t('CONVERSATION.REPLYBOX.EMAIL_HEAD.BCC.ERROR') }}
|
|
</span>
|
|
</div>
|
|
</div>
|
|
</template>
|
|
|
|
<style lang="scss" scoped>
|
|
.input-group-wrap .message {
|
|
@apply text-sm text-red-500 dark:text-red-500;
|
|
}
|
|
.input-group {
|
|
@apply border-b border-solid border-slate-75 dark:border-slate-700 my-1 flex items-center gap-2;
|
|
|
|
.input-group-label {
|
|
@apply border-transparent bg-transparent text-xs font-semibold pl-0;
|
|
}
|
|
}
|
|
|
|
.input-group.error {
|
|
@apply border-b-red-500 dark:border-b-red-500;
|
|
.input-group-label {
|
|
@apply text-red-500 dark:text-red-500;
|
|
}
|
|
}
|
|
</style>
|