fix menu code

ui/site/admin-audit.html

@@ -179,8 +179,8 @@ if (conf["custom_css_link"]) {
             <span class="navbar-toggler-icon"></span>
           </button>
           <div class="collapse navbar-collapse" id="navbarNavAltMarkup">
-            <div id="admin-menu" class="navbar-nav">
-            </div>
+            <ul id="admin-menu" class="navbar-nav">
+            </ul>
           </div>
         </nav>
       </div>

ui/site/admin-processing-settings.html

@@ -579,8 +579,8 @@ h4 {display:inline-block; }
             <span class="navbar-toggler-icon"></span>
           </button>
           <div class="collapse navbar-collapse" id="navbarNavAltMarkup">
-            <div id="admin-menu" class="navbar-nav">
-            </div>
+            <ul id="admin-menu" class="navbar-nav">
+            </ul>
           </div>
         </nav>
       </div>

ui/site/admin-view-requests.html

@@ -245,8 +245,8 @@ textarea {min-height:auto;}
             <span class="navbar-toggler-icon"></span>
           </button>
           <div class="collapse navbar-collapse" id="navbarNavAltMarkup">
-            <div id="admin-menu" class="navbar-nav">
-            </div>
+            <ul id="admin-menu" class="navbar-nav">
+            </ul>
           </div>
         </nav>
       </div>

ui/site/site.js

@@ -108,7 +108,7 @@ function showForm(title, message, btn) {
 function prepareDropdownMenu(menu) {
   const currentFile = document.location.pathname.split(/[\/]+/).pop();
   var code = '';
-  for (index = 0; index < menu.length; ++index) {
+  for (var index = 0; index < menu.length; index++) {
     const name = menu[index]["name"];
     const file = menu[index]["file"];
     const style = (file == currentFile) ? ' active' : '';
@@ -120,7 +120,7 @@ function prepareDropdownMenu(menu) {
 function prepareMenu(menu) {
   const currentFile = document.location.pathname.split(/[\/]+/).pop();
   var code = '';
-  for (index = 0; index < menu.length; ++index) {
+  for (var index = 0; index < menu.length; index++) {
     const name = menu[index]["name"];
     if (menu[index]["dropdown"]) {
       code += '<li class="nav-item dropdown">'+
@@ -128,7 +128,6 @@ function prepareMenu(menu) {
         '<div class="dropdown-menu" aria-labelledby="dropdown-'+name+'">'+
         prepareDropdownMenu( menu[index]["dropdown"]) + '</div></li>';
     } else {
-      const name = menu[index]["name"];
       const file = menu[index]["file"];
       const style = (file == currentFile) ? ' active' : '';
       code += '<li class="nav-item">'+
@@ -139,7 +138,7 @@ function prepareMenu(menu) {
 }
 
 function showAdminMenu() {
-  code = prepareMenu(adminMenu);
+  const code = prepareMenu(adminMenu);
   const m = document.getElementById("admin-menu");
   if (m) {
     m.innerHTML = code;
@@ -148,7 +147,7 @@ function showAdminMenu() {
 }
 
 function showUserMenu() {
-  code = prepareMenu(userMenu);
+  const code = prepareMenu(userMenu);
   document.write(code);
 }
 

ui/site/user-agreements.html

@@ -144,9 +144,9 @@ function prepareRow(row) {
                         <span class="navbar-toggler-icon"></span>
                     </button>
                     <div class="collapse navbar-collapse" id="navbarNavAltMarkup">
-                        <div class="navbar-nav">
+                        <ul class="navbar-nav">
 				<script>showUserMenu();</script>
-                        </div>
+                        </ul>
                     </div>
                 </nav>
             </div>

ui/site/user-apps.html

@@ -44,9 +44,9 @@ if (conf["custom_css_link"]) {
                         <span class="navbar-toggler-icon"></span>
                     </button>
                     <div class="collapse navbar-collapse" id="navbarNavAltMarkup">
-                        <div class="navbar-nav">
+                        <ul class="navbar-nav">
 				<script>showUserMenu();</script>
-                        </div>
+                        </ul>
                     </div>
                 </nav>
             </div>

ui/site/user-audit.html

@@ -182,9 +182,9 @@ if (conf["custom_css_link"]) {
             <span class="navbar-toggler-icon"></span>
           </button>
           <div class="collapse navbar-collapse" id="navbarNavAltMarkup">
-            <div class="navbar-nav">
+            <ul class="navbar-nav">
 		    <script>showUserMenu();</script>
-            </div>
+            </ul>
           </div>
         </nav>
       </div>

ui/site/user-profile.html

@@ -45,9 +45,9 @@ if (conf["custom_css_link"]) {
                         <span class="navbar-toggler-icon"></span>
                     </button>
                     <div class="collapse navbar-collapse" id="navbarNavAltMarkup">
-                        <div class="navbar-nav">
+                        <ul class="navbar-nav">
 				<script>showUserMenu();</script>
-                        </div>
+                        </ul>
                     </div>
                 </nav>
             </div>

ui/site/user-requests.html

@@ -192,9 +192,9 @@
                         <span class="navbar-toggler-icon"></span>
                     </button>
                     <div class="collapse navbar-collapse" id="navbarNavAltMarkup">
-                        <div class="navbar-nav">
+                        <ul class="navbar-nav">
 				<script>showUserMenu();</script>
-                        </div>
+                        </ul>
                     </div>
         </nav>
       </div>