From e1ed497d12b376dbcfc67892f40fe37c208347e2 Mon Sep 17 00:00:00 2001 From: Jamil Date: Mon, 2 Dec 2024 09:27:11 -0800 Subject: [PATCH] fix(apple): Expose `MACOSX_DEPLOYMENT_TARGET` in rust apple build script to signal to rustc which macOS to target (#7443) `MACOSX_DEPLOYMENT_TARGET` is a standard env var read by gcc and rustc that determines which version of macOS to target binaries for. This variable was being removed inadvertently in our rust build script. Exposing this var fixes a slew of warnings about object files being built for a newer macOS target than being linked that were showing up in Xcode for some time now. Hasn't caused any issues thus far from what I can tell, but possibly related to #7442 --- rust/connlib/clients/apple/build-rust.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/rust/connlib/clients/apple/build-rust.sh b/rust/connlib/clients/apple/build-rust.sh index 311c58db3..c7be26395 100755 --- a/rust/connlib/clients/apple/build-rust.sh +++ b/rust/connlib/clients/apple/build-rust.sh @@ -12,6 +12,7 @@ cmd=${1:-""} # into our highly evolved Rust-based build system. for var in $(env | awk -F= '{print $1}'); do if [[ "$var" != "HOME" ]] && + [[ "$var" != "MACOSX_DEPLOYMENT_TARGET" ]] && [[ "$var" != "USER" ]] && [[ "$var" != "LOGNAME" ]] && [[ "$var" != "TERM" ]] &&