scottk/kubernetes
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/kubernetes.git synced 2025-11-02 11:18:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use glog.*f when a format string is passed

Browse Source 
ref:
https://godoc.org/github.com/golang/glog

I use the following commands to search all the invalid usage:
$ grep "glog.Warning(" * -r | grep %
$ grep "glog.Info(" * -r | grep %
$ grep "glog.Error(" * -r | grep %
$ grep ").Info(" * -r | grep % | grep "glog.V("
This commit is contained in:
Cao Shufeng
2017-06-21 16:10:06 +08:00
parent 0744964956
commit 0c577c47d5
9 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
federation/pkg/federatedtypes/scheduling.go
View File

@@ -110,7 +110,7 @@ func (a *schedulingAdapter) GetSchedule(obj pkgruntime.Object, key string, clust
fedPref, err := replicapreferences.GetAllocationPreferences(obj, a.preferencesAnnotationName)
if err != nil {
glog.Info("Invalid workload-type specific preference, using default. object: %v, err: %v", obj, err)
glog.Infof("Invalid workload-type specific preference, using default. object: %v, err: %v", obj, err)
}
if fedPref == nil {
fedPref = &fedapi.ReplicaAllocationPreferences{

6
federation/pkg/kubefed/join.go
View File

@@ -209,7 +209,7 @@ func (j *joinFederation) Run(f cmdutil.Factory, cmdOut io.Writer, config util.Ad
glog.V(2).Info("Creating federation system namespace in joining cluster")
_, err = createFederationSystemNamespace(joiningClusterClientset, federationNamespace, federationName, joiningClusterName, dryRun)
if err != nil {
glog.V(2).Info("Error creating federation system namespace in joining cluster: %v", err)
glog.V(2).Infof("Error creating federation system namespace in joining cluster: %v", err)
return err
}
glog.V(2).Info("Created federation system namespace in joining cluster")
@@ -218,7 +218,7 @@ func (j *joinFederation) Run(f cmdutil.Factory, cmdOut io.Writer, config util.Ad
po.LoadingRules.ExplicitPath = kubeconfig
clientConfig, err := po.GetStartingConfig()
if err != nil {
glog.V(2).Info("Could not load clientConfig from %s: %v", kubeconfig, err)
glog.V(2).Infof("Could not load clientConfig from %s: %v", kubeconfig, err)
return err
}
@@ -662,7 +662,7 @@ func populateSecretInHostCluster(clusterClientset, hostClientset internalclients
return nil, err
}
glog.V(2).Info("Getting secret named: %s", sa.Secrets[0].Name)
glog.V(2).Infof("Getting secret named: %s", sa.Secrets[0].Name)
var secret *api.Secret
err = wait.PollImmediate(1*time.Second, serviceAccountSecretTimeout, func() (bool, error) {
var err error