scottk/kubernetes
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/kubernetes.git synced 2025-11-03 19:58:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix hugepages e2e test assertion

Browse Source 
This causes failures in:

- https://testgrid.k8s.io/sig-node-cri-o#ci-crio-cgroupv2-node-e2e-hugepages
- https://testgrid.k8s.io/sig-node-cri-o#ci-crio-cgroupv1-node-e2e-hugepages

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
This commit is contained in:
Sascha Grunert
2024-08-21 10:04:02 +02:00
parent beb696c2c9
commit 14476d88f3
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
test/e2e_node/hugepages_test.go
View File

@@ -225,12 +225,12 @@ var _ = SIGDescribe("HugePages", framework.WithSerial(), feature.HugePages, "[No
restartKubelet(true) restartKubelet(true)
ginkgo.By("verifying that the hugepages-3Mi resource no longer is present") ginkgo.By("verifying that the hugepages-3Mi resource no longer is present")
gomega.Eventually(ctx, func() resource.Quantity { gomega.Eventually(ctx, func() bool {
node, err = f.ClientSet.CoreV1().Nodes().Get(ctx, framework.TestContext.NodeName, metav1.GetOptions{}) node, err = f.ClientSet.CoreV1().Nodes().Get(ctx, framework.TestContext.NodeName, metav1.GetOptions{})
framework.ExpectNoError(err, "while getting node status") framework.ExpectNoError(err, "while getting node status")
// abc, error := node.Status.Capacity["hugepages-3Mi"] _, isPresent := node.Status.Capacity["hugepages-3Mi"]
return node.Status.Capacity["hugepages-3Mi"] return isPresent
}, 30*time.Second, framework.Poll).Should(gomega.BeNil()) }, 30*time.Second, framework.Poll).Should(gomega.BeFalseBecause("hugepages resource should not be present"))
}) })
ginkgo.It("should add resources for new huge page sizes on kubelet restart", func(ctx context.Context) { ginkgo.It("should add resources for new huge page sizes on kubelet restart", func(ctx context.Context) {
@@ -245,11 +245,12 @@ var _ = SIGDescribe("HugePages", framework.WithSerial(), feature.HugePages, "[No
startKubelet() startKubelet()
ginkgo.By("verifying that the hugepages-2Mi resource is present") ginkgo.By("verifying that the hugepages-2Mi resource is present")
gomega.Eventually(ctx, func() resource.Quantity { gomega.Eventually(ctx, func() bool {
node, err := f.ClientSet.CoreV1().Nodes().Get(ctx, framework.TestContext.NodeName, metav1.GetOptions{}) node, err := f.ClientSet.CoreV1().Nodes().Get(ctx, framework.TestContext.NodeName, metav1.GetOptions{})
framework.ExpectNoError(err, "while getting node status") framework.ExpectNoError(err, "while getting node status")
return node.Status.Capacity["hugepages-2Mi"] _, isPresent := node.Status.Capacity["hugepages-2Mi"]
}, 30*time.Second, framework.Poll).ShouldNot(gomega.BeNil()) return isPresent
}, 30*time.Second, framework.Poll).Should(gomega.BeTrueBecause("hugepages resource should be present"))
}) })
ginkgo.When("start the pod", func() { ginkgo.When("start the pod", func() {