scottk/kubernetes
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/kubernetes.git synced 2025-11-03 19:58:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

remove NewCloudNodeController() second return value

Browse Source 
NewCloudNodeController() will never return err,remove it
This commit is contained in:
NickrenREN
2017-02-06 15:33:27 +08:00
committed by NickrenREN
parent 4aa9168536
commit 1dc323a8f9
2 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cmd/cloud-controller-manager/app/controllermanager.go
View File

@@ -208,13 +208,11 @@ func StartControllers(s *options.CloudControllerManagerServer, kubeconfig *restc
}
// Start the CloudNodeController
nodeController, err := nodecontroller.NewCloudNodeController(
nodeController := nodecontroller.NewCloudNodeController(
sharedInformers.Core().V1().Nodes(),
client("cloud-node-controller"), cloud,
s.NodeMonitorPeriod.Duration)
if err != nil {
glog.Fatalf("Failed to initialize nodecontroller: %v", err)
}
nodeController.Run()
time.Sleep(wait.Jitter(s.ControllerStartInterval.Duration, ControllerStartJitter))

4
pkg/controller/cloud/nodecontroller.go
View File

@@ -62,7 +62,7 @@ func NewCloudNodeController(
nodeInformer coreinformers.NodeInformer,
kubeClient clientset.Interface,
cloud cloudprovider.Interface,
nodeMonitorPeriod time.Duration) (*CloudNodeController, error) {
nodeMonitorPeriod time.Duration) *CloudNodeController {
eventBroadcaster := record.NewBroadcaster()
recorder := eventBroadcaster.NewRecorder(api.Scheme, clientv1.EventSource{Component: "cloudcontrollermanager"})
@@ -81,7 +81,7 @@ func NewCloudNodeController(
cloud: cloud,
nodeMonitorPeriod: nodeMonitorPeriod,
}
return cnc, nil
return cnc
}
// This controller deletes a node if kubelet is not reporting