scottk/kubernetes
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/kubernetes.git synced 2025-11-04 04:08:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #72948 from bsalamat/remove_todo

Browse Source 
Cleanup a TODO in preemption logic to reflect the current state
This commit is contained in:
Kubernetes Prow Robot
2019-01-15 22:13:16 -08:00
committed by GitHub
parent 9e3b0a0ebc fa6d17f400
commit 260ca57c98
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
pkg/scheduler/core/generic_scheduler.go
View File

@@ -1036,10 +1036,11 @@ func selectVictimsOnNode(
} }
potentialVictims.Sort() potentialVictims.Sort()
// If the new pod does not fit after removing all the lower priority pods, // If the new pod does not fit after removing all the lower priority pods,
// we are almost done and this node is not suitable for preemption. The only condition // we are almost done and this node is not suitable for preemption. The only
// that we should check is if the "pod" is failing to schedule due to pod affinity // condition that we could check is if the "pod" is failing to schedule due to
// failure. // inter-pod affinity to one or more victims, but we have decided not to
// TODO(bsalamat): Consider checking affinity to lower priority pods if feasible with reasonable performance. // support this case for performance reasons. Having affinity to lower
// priority pods is not a recommended configuration anyway.
if fits, _, err := podFitsOnNode(pod, meta, nodeInfoCopy, fitPredicates, queue, false); !fits { if fits, _, err := podFitsOnNode(pod, meta, nodeInfoCopy, fitPredicates, queue, false); !fits {
if err != nil { if err != nil {
klog.Warningf("Encountered error while selecting victims on node %v: %v", nodeInfo.Node().Name, err) klog.Warningf("Encountered error while selecting victims on node %v: %v", nodeInfo.Node().Name, err)