scottk/kubernetes
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/kubernetes.git synced 2025-11-03 19:58:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Check errors before logging providers

Browse Source 
The logProviders() should check errors firstly, and do not log
providers when providers is null.
This commit is contained in:
FengyunPan
2017-04-22 16:55:32 +08:00
parent a121d1c674
commit 3856b5d76c
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
plugin/pkg/admission/security/podsecuritypolicy/admission.go
View File

@@ -327,13 +327,18 @@ func buildAttributes(info user.Info, namespace string, policy *extensions.PodSec
// logProviders logs what providers were found for the pod as well as any errors that were encountered // logProviders logs what providers were found for the pod as well as any errors that were encountered
// while creating providers. // while creating providers.
func logProviders(pod *api.Pod, providers []psp.Provider, providerCreationErrs []error) { func logProviders(pod *api.Pod, providers []psp.Provider, providerCreationErrs []error) {
for _, err := range providerCreationErrs {
glog.V(4).Infof("provider creation error: %v", err)
}
if len(providers) == 0 {
glog.V(4).Infof("unable to validate pod %s (generate: %s) against any provider.", pod.Name, pod.GenerateName)
return
}
names := make([]string, len(providers)) names := make([]string, len(providers))
for i, p := range providers { for i, p := range providers {
names[i] = p.GetPSPName() names[i] = p.GetPSPName()
} }
glog.V(4).Infof("validating pod %s (generate: %s) against providers %s", pod.Name, pod.GenerateName, strings.Join(names, ",")) glog.V(4).Infof("validating pod %s (generate: %s) against providers: %s", pod.Name, pod.GenerateName, strings.Join(names, ","))
for _, err := range providerCreationErrs {
glog.V(4).Infof("provider creation error: %v", err)
}
} }