scottk/kubernetes
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/kubernetes.git synced 2025-11-03 19:58:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

optimize the unit test

Browse Source 
Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>
This commit is contained in:
Ziqi Zhao
2023-12-05 08:02:03 +08:00
parent 69c40a3396
commit 51495bb4c5
1 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
pkg/kubelet/kubelet_test.go
View File

@@ -3249,7 +3249,7 @@ func TestSyncPodSpans(t *testing.T) {
exp := tracetest.NewInMemoryExporter() exp := tracetest.NewInMemoryExporter()
tp := sdktrace.NewTracerProvider( tp := sdktrace.NewTracerProvider(
sdktrace.WithBatcher(exp), sdktrace.WithSyncer(exp),
) )
kubelet.tracer = tp.Tracer(instrumentationScope) kubelet.tracer = tp.Tracer(instrumentationScope)
@@ -3313,7 +3313,6 @@ func TestSyncPodSpans(t *testing.T) {
_, err = kubelet.SyncPod(context.Background(), kubetypes.SyncPodCreate, pod, nil, &kubecontainer.PodStatus{}) _, err = kubelet.SyncPod(context.Background(), kubetypes.SyncPodCreate, pod, nil, &kubecontainer.PodStatus{})
require.NoError(t, err) require.NoError(t, err)
err = tp.ForceFlush(context.Background())
require.NoError(t, err) require.NoError(t, err)
assert.NotEmpty(t, exp.GetSpans()) assert.NotEmpty(t, exp.GetSpans())
@@ -3331,7 +3330,7 @@ func TestSyncPodSpans(t *testing.T) {
imageServiceSpans := make([]tracetest.SpanStub, 0) imageServiceSpans := make([]tracetest.SpanStub, 0)
runtimeServiceSpans := make([]tracetest.SpanStub, 0) runtimeServiceSpans := make([]tracetest.SpanStub, 0)
for _, span := range exp.GetSpans() { for _, span := range exp.GetSpans() {
if span.SpanContext.TraceID() == rootSpan.SpanContext.TraceID() && span.Parent.SpanID() == rootSpan.SpanContext.SpanID() { if span.SpanContext.TraceID() == rootSpan.SpanContext.TraceID() {
switch { switch {
case strings.HasPrefix(span.Name, "runtime.v1.ImageService"): case strings.HasPrefix(span.Name, "runtime.v1.ImageService"):
imageServiceSpans = append(imageServiceSpans, span) imageServiceSpans = append(imageServiceSpans, span)
@@ -3340,6 +3339,14 @@ func TestSyncPodSpans(t *testing.T) {
} }
} }
} }
assert.NotEmpty(t, imageServiceSpans) assert.NotEmpty(t, imageServiceSpans, "syncPod trace should have image service spans")
assert.NotEmpty(t, runtimeServiceSpans) assert.NotEmpty(t, runtimeServiceSpans, "syncPod trace should have runtime service spans")
for _, span := range imageServiceSpans {
assert.Equal(t, span.Parent.SpanID(), rootSpan.SpanContext.SpanID(), fmt.Sprintf("image service span %s %s should be child of root span", span.Name, span.Parent.SpanID()))
}
for _, span := range runtimeServiceSpans {
assert.Equal(t, span.Parent.SpanID(), rootSpan.SpanContext.SpanID(), fmt.Sprintf("runtime service span %s %s should be child of root span", span.Name, span.Parent.SpanID()))
}
} }