mirror of
				https://github.com/optim-enterprises-bv/kubernetes.git
				synced 2025-11-04 04:08:16 +00:00 
			
		
		
		
	Change FailedScheduling Event message to be more intuitive
This commit is contained in:
		@@ -65,7 +65,7 @@ const (
 | 
			
		||||
	// ErrReasonBindConflict is used for VolumeBindingNoMatch predicate error.
 | 
			
		||||
	ErrReasonBindConflict ConflictReason = "node(s) didn't find available persistent volumes to bind"
 | 
			
		||||
	// ErrReasonNodeConflict is used for VolumeNodeAffinityConflict predicate error.
 | 
			
		||||
	ErrReasonNodeConflict ConflictReason = "node(s) had volume node affinity conflict"
 | 
			
		||||
	ErrReasonNodeConflict ConflictReason = "node(s) didn't match PersistentVolume's node affinity"
 | 
			
		||||
	// ErrReasonNotEnoughSpace is used when a pod cannot start on a node because not enough storage space is available.
 | 
			
		||||
	ErrReasonNotEnoughSpace = "node(s) did not have enough free storage"
 | 
			
		||||
	// ErrReasonPVNotExist is used when a pod has one or more PVC(s) bound to non-existent persistent volume(s)"
 | 
			
		||||
 
 | 
			
		||||
@@ -1120,7 +1120,7 @@ func TestSchedulerWithVolumeBinding(t *testing.T) {
 | 
			
		||||
				FindReasons: volumebinding.ConflictReasons{volumebinding.ErrReasonNodeConflict},
 | 
			
		||||
			},
 | 
			
		||||
			eventReason: "FailedScheduling",
 | 
			
		||||
			expectError: makePredicateError("1 node(s) had volume node affinity conflict"),
 | 
			
		||||
			expectError: makePredicateError("1 node(s) didn't match PersistentVolume's node affinity"),
 | 
			
		||||
		},
 | 
			
		||||
		{
 | 
			
		||||
			name: "unbound/no matches",
 | 
			
		||||
@@ -1136,7 +1136,7 @@ func TestSchedulerWithVolumeBinding(t *testing.T) {
 | 
			
		||||
				FindReasons: volumebinding.ConflictReasons{volumebinding.ErrReasonBindConflict, volumebinding.ErrReasonNodeConflict},
 | 
			
		||||
			},
 | 
			
		||||
			eventReason: "FailedScheduling",
 | 
			
		||||
			expectError: makePredicateError("1 node(s) didn't find available persistent volumes to bind, 1 node(s) had volume node affinity conflict"),
 | 
			
		||||
			expectError: makePredicateError("1 node(s) didn't find available persistent volumes to bind, 1 node(s) didn't match PersistentVolume's node affinity"),
 | 
			
		||||
		},
 | 
			
		||||
		{
 | 
			
		||||
			name:               "unbound/found matches/bind succeeds",
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user