scottk/kubernetes
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/kubernetes.git synced 2025-11-27 11:53:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #127109 from sanposhiho/precheck-move

Browse Source 
feat: disable preCheck when QHint is enabled
This commit is contained in:
Kubernetes Prow Robot
2024-09-05 17:19:57 +01:00
committed by GitHub
parent dfb763b05e 4ee1394b71
commit 52d4972901
3 changed files with 37 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/scheduler/backend/queue/scheduling_queue.go
View File

@@ -111,10 +111,9 @@ type SchedulingQueue interface {
Done(types.UID)
Update(logger klog.Logger, oldPod, newPod *v1.Pod)
Delete(pod *v1.Pod)
// TODO(sanposhiho): move all PreEnqueueCheck to Requeue and delete it from this parameter eventually.
// Some PreEnqueueCheck include event filtering logic based on some in-tree plugins
// and it affect badly to other plugins.
// See https://github.com/kubernetes/kubernetes/issues/110175
// Important Note: preCheck shouldn't include anything that depends on the in-tree plugins' logic.
// (e.g., filter Pods based on added/updated Node's capacity, etc.)
// We know currently some do, but we'll eventually remove them in favor of the scheduling queue hint.
MoveAllToActiveOrBackoffQueue(logger klog.Logger, event framework.ClusterEvent, oldObj, newObj interface{}, preCheck PreEnqueueCheck)
AssignedPodAdded(logger klog.Logger, pod *v1.Pod)
AssignedPodUpdated(logger klog.Logger, oldPod, newPod *v1.Pod, event framework.ClusterEvent)