scottk/kubernetes
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/kubernetes.git synced 2025-10-31 18:28:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

core/v1: add validation and defaulting unit tests for when internalTrafficPolicy is nil and Service type is ExternalName

Browse Source 
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
This commit is contained in:
Andrew Sy Kim
2021-09-08 13:55:41 -04:00
parent 3a927cc6b3
commit 60b38ee180
2 changed files with 27 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/apis/core/validation/validation_test.go
View File

@@ -12281,6 +12281,16 @@ func TestValidateServiceCreate(t *testing.T) {
featureGates: []featuregate.Feature{features.ServiceInternalTrafficPolicy},
numErrs: 1,
},
{
name: "internalTrafficPolicy field nil when type is ExternalName",
tweakSvc: func(s *core.Service) {
s.Spec.InternalTrafficPolicy = nil
s.Spec.Type = core.ServiceTypeExternalName
s.Spec.ExternalName = "foo.bar.com"
},
featureGates: []featuregate.Feature{features.ServiceInternalTrafficPolicy},
numErrs: 0,
},
{
name: "invalid internalTraffic field",
tweakSvc: func(s *core.Service) {