scottk/kubernetes
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/kubernetes.git synced 2025-11-01 02:38:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix typos in pkg/validation and test/cmd

Browse Source 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
This commit is contained in:
Humble Chirammal
2022-09-20 18:34:12 +05:30
parent 6ee3cbd931
commit 6621db7dd1
6 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/apis/core/v1/helper/helpers_test.go
View File

@@ -550,7 +550,7 @@ func TestNodeSelectorRequirementKeyExistsInNodeSelectorTerms(t *testing.T) {
exists: true, exists: true,
}, },
{ {
name: "key existence in terms with one of the keys specfied", name: "key existence in terms with one of the keys specified",
reqs: []v1.NodeSelectorRequirement{ reqs: []v1.NodeSelectorRequirement{
{ {
Key: "key1", Key: "key1",

2
pkg/apis/core/validation/validation.go
View File

@@ -6417,7 +6417,7 @@ func validateWindowsHostProcessPod(podSpec *core.PodSpec, fieldPath *field.Path,
switch { switch {
case containerHostProcess != nil && *containerHostProcess: case containerHostProcess != nil && *containerHostProcess:
// Container explitly sets hostProcess=true // Container explicitly sets hostProcess=true
hostProcessContainerCount++ hostProcessContainerCount++
case containerHostProcess == nil && podHostProcess != nil && *podHostProcess: case containerHostProcess == nil && podHostProcess != nil && *podHostProcess:
// Container inherits hostProcess=true from pod settings // Container inherits hostProcess=true from pod settings

6
pkg/apis/core/validation/validation_test.go
View File

@@ -13384,7 +13384,7 @@ func TestValidateServiceCreate(t *testing.T) {
numErrs: 0, numErrs: 0,
}, },
{ {
name: "nagative healthCheckNodePort field", name: "negative healthCheckNodePort field",
tweakSvc: func(s *core.Service) { tweakSvc: func(s *core.Service) {
s.Spec.Type = core.ServiceTypeLoadBalancer s.Spec.Type = core.ServiceTypeLoadBalancer
s.Spec.AllocateLoadBalancerNodePorts = utilpointer.BoolPtr(true) s.Spec.AllocateLoadBalancerNodePorts = utilpointer.BoolPtr(true)
@@ -13394,7 +13394,7 @@ func TestValidateServiceCreate(t *testing.T) {
numErrs: 1, numErrs: 1,
}, },
{ {
name: "nagative healthCheckNodePort field", name: "negative healthCheckNodePort field",
tweakSvc: func(s *core.Service) { tweakSvc: func(s *core.Service) {
s.Spec.Type = core.ServiceTypeLoadBalancer s.Spec.Type = core.ServiceTypeLoadBalancer
s.Spec.AllocateLoadBalancerNodePorts = utilpointer.BoolPtr(true) s.Spec.AllocateLoadBalancerNodePorts = utilpointer.BoolPtr(true)
@@ -13528,7 +13528,7 @@ func TestValidateServiceCreate(t *testing.T) {
}, },
numErrs: 0, numErrs: 0,
}, },
/* cluster IPs. some tests are reduntant */ /* cluster IPs. some tests are redundant */
{ {
name: "invalid, garbage single ip", name: "invalid, garbage single ip",
tweakSvc: func(s *core.Service) { tweakSvc: func(s *core.Service) {

2
test/cmd/apply.sh
View File

@@ -306,7 +306,7 @@ __EOF__
kubectl delete --kustomize hack/testdata/kustomize kubectl delete --kustomize hack/testdata/kustomize
## kubectl apply multiple resources with one failure during apply phase. ## kubectl apply multiple resources with one failure during apply phase.
# Pre-Condition: namepace does not exist and no POD exists # Pre-Condition: namespace does not exist and no POD exists
output_message=$(! kubectl get namespace multi-resource-ns 2>&1 "${kube_flags[@]:?}") output_message=$(! kubectl get namespace multi-resource-ns 2>&1 "${kube_flags[@]:?}")
kube::test::if_has_string "${output_message}" 'namespaces "multi-resource-ns" not found' kube::test::if_has_string "${output_message}" 'namespaces "multi-resource-ns" not found'
kube::test::wait_object_assert pods "{{range.items}}{{${id_field:?}}}:{{end}}" '' kube::test::wait_object_assert pods "{{range.items}}{{${id_field:?}}}:{{end}}" ''

2
test/cmd/discovery.sh
View File

@@ -27,7 +27,7 @@ run_RESTMapper_evaluation_tests() {
RESTMAPPER_ERROR_FILE="${KUBE_TEMP}/restmapper-error" RESTMAPPER_ERROR_FILE="${KUBE_TEMP}/restmapper-error"
### Non-existent resource type should give a recognizeable error ### Non-existent resource type should give a recognizable error
# Pre-condition: None # Pre-condition: None
# Command # Command
kubectl get "${kube_flags[@]:?}" unknownresourcetype 2>"${RESTMAPPER_ERROR_FILE}" || true kubectl get "${kube_flags[@]:?}" unknownresourcetype 2>"${RESTMAPPER_ERROR_FILE}" || true

2
test/cmd/template-output.sh
View File

@@ -201,7 +201,7 @@ EOF
output_message=$(kubectl "${kube_flags[@]:?}" create service nodeport foo --dry-run=client --tcp=8080 --template="{{ .metadata.name }}:") output_message=$(kubectl "${kube_flags[@]:?}" create service nodeport foo --dry-run=client --tcp=8080 --template="{{ .metadata.name }}:")
kube::test::if_has_string "${output_message}" 'foo:' kube::test::if_has_string "${output_message}" 'foo:'
# check that "config view" ouputs "yaml" as its default output format # check that "config view" outputs "yaml" as its default output format
output_message=$(kubectl "${kube_flags[@]:?}" config view) output_message=$(kubectl "${kube_flags[@]:?}" config view)
kube::test::if_has_string "${output_message}" 'kind: Config' kube::test::if_has_string "${output_message}" 'kind: Config'