scottk/kubernetes
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/kubernetes.git synced 2025-10-31 18:28:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #129174 from RyanAoh/fix-115896

Browse Source 
Remove the limitation on exposing port 10250 externally
This commit is contained in:
Kubernetes Prow Robot
2024-12-13 01:48:32 +01:00
committed by GitHub
parent efea0a0ed7 e8087b3f6a
commit 7a504aa97b
2 changed files with 3 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/apis/core/validation/validation_test.go
View File

@@ -15512,16 +15512,15 @@ func TestValidateServiceCreate(t *testing.T) {
},
numErrs: 0,
}, {
// For now we open firewalls, and its insecure if we open 10250, remove this
// when we have better protections in place.
name: "invalid port type=LoadBalancer",
// Remove the limitation on exposing port 10250 externally
name: "valid port type=LoadBalancer",
tweakSvc: func(s *core.Service) {
s.Spec.Type = core.ServiceTypeLoadBalancer
s.Spec.ExternalTrafficPolicy = core.ServiceExternalTrafficPolicyCluster
s.Spec.AllocateLoadBalancerNodePorts = utilpointer.Bool(true)
s.Spec.Ports = append(s.Spec.Ports, core.ServicePort{Name: "kubelet", Port: 10250, Protocol: "TCP", TargetPort: intstr.FromInt32(12345)})
},
numErrs: 1,
numErrs: 0,
}, {
name: "valid LoadBalancer source range annotation",
tweakSvc: func(s *core.Service) {