scottk/kubernetes
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/kubernetes.git synced 2025-11-02 03:08:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleanup TODO comments from PrintFlags wiring

Browse Source
This commit is contained in:
juanvallejo
2018-05-07 17:47:29 -04:00
parent a67ccaeab1
commit 7b1b107ea4
17 changed files with 208 additions and 193 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/kubectl/cmd/create/create_deployment.go
View File

@@ -56,7 +56,7 @@ func NewCmdCreateDeployment(f cmdutil.Factory, ioStreams genericclioptions.IOStr
Example: deploymentExample,
Run: func(cmd *cobra.Command, args []string) {
cmdutil.CheckErr(options.Complete(f, cmd, args))
cmdutil.CheckErr(options.Run(f))
cmdutil.CheckErr(options.Run())
},
}
@@ -143,13 +143,13 @@ func (o *DeploymentOpts) Complete(f cmdutil.Factory, cmd *cobra.Command, args []
return errUnsupportedGenerator(cmd, generatorName)
}
return o.CreateSubcommandOptions.Complete(cmd, args, generator)
return o.CreateSubcommandOptions.Complete(f, cmd, args, generator)
}
// createDeployment
// 1. Reads user config values from Cobra.
// 2. Sets up the correct Generator object.
// 3. Calls RunCreateSubcommand.
func (o *DeploymentOpts) Run(f cmdutil.Factory) error {
return RunCreateSubcommand(f, o.CreateSubcommandOptions)
func (o *DeploymentOpts) Run() error {
return o.CreateSubcommandOptions.Run()
}