mirror of
				https://github.com/optim-enterprises-bv/kubernetes.git
				synced 2025-11-03 19:58:17 +00:00 
			
		
		
		
	Merge pull request #117380 from yulng/dryrun1
Remove GA feature gates in 1.28 about DryRun
This commit is contained in:
		@@ -1108,8 +1108,6 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS
 | 
				
			|||||||
 | 
					
 | 
				
			||||||
	genericfeatures.CustomResourceValidationExpressions: {Default: true, PreRelease: featuregate.Beta},
 | 
						genericfeatures.CustomResourceValidationExpressions: {Default: true, PreRelease: featuregate.Beta},
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	genericfeatures.DryRun: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.28
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
	genericfeatures.OpenAPIEnums: {Default: true, PreRelease: featuregate.Beta},
 | 
						genericfeatures.OpenAPIEnums: {Default: true, PreRelease: featuregate.Beta},
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	genericfeatures.OpenAPIV3: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.29
 | 
						genericfeatures.OpenAPIV3: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.29
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -112,17 +112,6 @@ const (
 | 
				
			|||||||
	// Enables expression validation for Custom Resource
 | 
						// Enables expression validation for Custom Resource
 | 
				
			||||||
	CustomResourceValidationExpressions featuregate.Feature = "CustomResourceValidationExpressions"
 | 
						CustomResourceValidationExpressions featuregate.Feature = "CustomResourceValidationExpressions"
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	// owner: @apelisse
 | 
					 | 
				
			||||||
	// alpha: v1.12
 | 
					 | 
				
			||||||
	// beta: v1.13
 | 
					 | 
				
			||||||
	// stable: v1.18
 | 
					 | 
				
			||||||
	//
 | 
					 | 
				
			||||||
	// Allow requests to be processed but not stored, so that
 | 
					 | 
				
			||||||
	// validation, merging, mutation can be tested without
 | 
					 | 
				
			||||||
	// committing.
 | 
					 | 
				
			||||||
	DryRun featuregate.Feature = "DryRun"
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
	// owner: @wojtek-t
 | 
					 | 
				
			||||||
	// alpha: v1.20
 | 
						// alpha: v1.20
 | 
				
			||||||
	// beta: v1.21
 | 
						// beta: v1.21
 | 
				
			||||||
	// GA: v1.24
 | 
						// GA: v1.24
 | 
				
			||||||
@@ -253,8 +242,6 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS
 | 
				
			|||||||
 | 
					
 | 
				
			||||||
	CustomResourceValidationExpressions: {Default: true, PreRelease: featuregate.Beta},
 | 
						CustomResourceValidationExpressions: {Default: true, PreRelease: featuregate.Beta},
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	DryRun: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.28
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
	EfficientWatchResumption: {Default: true, PreRelease: featuregate.GA, LockToDefault: true},
 | 
						EfficientWatchResumption: {Default: true, PreRelease: featuregate.GA, LockToDefault: true},
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	KMSv2: {Default: true, PreRelease: featuregate.Beta},
 | 
						KMSv2: {Default: true, PreRelease: featuregate.Beta},
 | 
				
			||||||
 
 | 
				
			|||||||
@@ -28,12 +28,9 @@ import (
 | 
				
			|||||||
	"k8s.io/apimachinery/pkg/runtime/schema"
 | 
						"k8s.io/apimachinery/pkg/runtime/schema"
 | 
				
			||||||
	"k8s.io/apimachinery/pkg/types"
 | 
						"k8s.io/apimachinery/pkg/types"
 | 
				
			||||||
	"k8s.io/apimachinery/pkg/util/sets"
 | 
						"k8s.io/apimachinery/pkg/util/sets"
 | 
				
			||||||
	"k8s.io/apiserver/pkg/features"
 | 
					 | 
				
			||||||
	utilfeature "k8s.io/apiserver/pkg/util/feature"
 | 
					 | 
				
			||||||
	"k8s.io/client-go/dynamic"
 | 
						"k8s.io/client-go/dynamic"
 | 
				
			||||||
	"k8s.io/client-go/kubernetes"
 | 
						"k8s.io/client-go/kubernetes"
 | 
				
			||||||
	"k8s.io/client-go/util/retry"
 | 
						"k8s.io/client-go/util/retry"
 | 
				
			||||||
	featuregatetesting "k8s.io/component-base/featuregate/testing"
 | 
					 | 
				
			||||||
	kubeapiservertesting "k8s.io/kubernetes/cmd/kube-apiserver/app/testing"
 | 
						kubeapiservertesting "k8s.io/kubernetes/cmd/kube-apiserver/app/testing"
 | 
				
			||||||
	"k8s.io/kubernetes/test/integration/etcd"
 | 
						"k8s.io/kubernetes/test/integration/etcd"
 | 
				
			||||||
	"k8s.io/kubernetes/test/integration/framework"
 | 
						"k8s.io/kubernetes/test/integration/framework"
 | 
				
			||||||
@@ -211,7 +208,6 @@ func DryRunDeleteTest(t *testing.T, rsc dynamic.ResourceInterface, name string)
 | 
				
			|||||||
 | 
					
 | 
				
			||||||
// TestDryRun tests dry-run on all types.
 | 
					// TestDryRun tests dry-run on all types.
 | 
				
			||||||
func TestDryRun(t *testing.T) {
 | 
					func TestDryRun(t *testing.T) {
 | 
				
			||||||
	defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.DryRun, true)()
 | 
					 | 
				
			||||||
 | 
					
 | 
				
			||||||
	// start API server
 | 
						// start API server
 | 
				
			||||||
	s, err := kubeapiservertesting.StartTestServer(t, kubeapiservertesting.NewDefaultTestServerOptions(), []string{
 | 
						s, err := kubeapiservertesting.StartTestServer(t, kubeapiservertesting.NewDefaultTestServerOptions(), []string{
 | 
				
			||||||
 
 | 
				
			|||||||
		Reference in New Issue
	
	Block a user