scottk/kubernetes
1
0
Fork 0
mirror of https://github.com/optim-enterprises-bv/kubernetes.git synced 2025-11-03 19:58:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address review comments

Browse Source
This commit is contained in:
xing-yang
2022-11-02 22:37:50 +00:00
parent b4e6bed525
commit 85f5583684
2 changed files with 5 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/controller/podgc/gc_controller.go
View File

@@ -70,7 +70,7 @@ type PodGCController struct {
func init() { func init() {
// Register prometheus metrics // Register prometheus metrics
Register() RegisterMetrics()
} }
func NewPodGC(ctx context.Context, kubeClient clientset.Interface, podInformer coreinformers.PodInformer, func NewPodGC(ctx context.Context, kubeClient clientset.Interface, podInformer coreinformers.PodInformer,

10
pkg/controller/podgc/metrics.go
View File

@@ -24,16 +24,14 @@ import (
) )
const ( const (
podGCController = "pod_gc_collector" podGCController = "pod_gc_collector"
deletingPods = "force_delete_pods_total"
deletingPodsError = "force_delete_pod_errors_total"
) )
var ( var (
deletingPodsTotal = metrics.NewCounterVec( deletingPodsTotal = metrics.NewCounterVec(
&metrics.CounterOpts{ &metrics.CounterOpts{
Subsystem: podGCController, Subsystem: podGCController,
Name: deletingPods, Name: "force_delete_pods_total",
Help: "Number of pods that are being forcefully deleted since the Pod GC Controller started.", Help: "Number of pods that are being forcefully deleted since the Pod GC Controller started.",
StabilityLevel: metrics.ALPHA, StabilityLevel: metrics.ALPHA,
}, },
@@ -42,7 +40,7 @@ var (
deletingPodsErrorTotal = metrics.NewCounterVec( deletingPodsErrorTotal = metrics.NewCounterVec(
&metrics.CounterOpts{ &metrics.CounterOpts{
Subsystem: podGCController, Subsystem: podGCController,
Name: deletingPodsError, Name: "force_delete_pod_errors_total",
Help: "Number of errors encountered when forcefully deleting the pods since the Pod GC Controller started.", Help: "Number of errors encountered when forcefully deleting the pods since the Pod GC Controller started.",
StabilityLevel: metrics.ALPHA, StabilityLevel: metrics.ALPHA,
}, },
@@ -53,7 +51,7 @@ var (
var registerMetrics sync.Once var registerMetrics sync.Once
// Register the metrics that are to be monitored. // Register the metrics that are to be monitored.
func Register() { func RegisterMetrics() {
registerMetrics.Do(func() { registerMetrics.Do(func() {
legacyregistry.MustRegister(deletingPodsTotal) legacyregistry.MustRegister(deletingPodsTotal)
legacyregistry.MustRegister(deletingPodsErrorTotal) legacyregistry.MustRegister(deletingPodsErrorTotal)